diff mbox series

test/event: fix number of queues in eventdev conf

Message ID 20250206143244.524451-1-sthotton@marvell.com (mailing list archive)
State Accepted
Delegated to: Jerin Jacob
Headers
Series test/event: fix number of queues in eventdev conf |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Functional success Functional PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-marvell-Functional success Functional Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-compile-amd64-testing pending Testing pending
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-sample-apps-testing success Testing PASS

Commit Message

Shijith Thotton Feb. 6, 2025, 2:32 p.m. UTC 
The unit test adapter_pollq_instance_get requires three event queues,
but the test suite was only configuring a single queue. This patch
updates the test suite setup function to configure max available queues.

Fixes: a1793ee8aba0 ("eventdev/eth_rx: add adapter instance get API")
Cc: stable@dpdk.org

Signed-off-by: Shijith Thotton <sthotton@marvell.com>
---
 app/test/test_event_eth_rx_adapter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pavan Nikhilesh Bhagavatula Feb. 25, 2025, 1:07 p.m. UTC | #1 
> -----Original Message-----
> From: Shijith Thotton <sthotton@marvell.com>
> Sent: Thursday, February 6, 2025 8:03 PM
> To: Jerin Jacob <jerinj@marvell.com>
> Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>; Shijith Thotton <sthotton@marvell.com>;
> stable@dpdk.org; Naga Harish K S V <s.v.naga.harish.k@intel.com>
> Subject: [PATCH] test/event: fix number of queues in eventdev conf
> 
> The unit test adapter_pollq_instance_get requires three event queues,
> but the test suite was only configuring a single queue. This patch
> updates the test suite setup function to configure max available queues.
> 
> Fixes: a1793ee8aba0 ("eventdev/eth_rx: add adapter instance get API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
>  app/test/test_event_eth_rx_adapter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test/test_event_eth_rx_adapter.c
> b/app/test/test_event_eth_rx_adapter.c
> index 0233c87779..9a60e34352 100644
> --- a/app/test/test_event_eth_rx_adapter.c
> +++ b/app/test/test_event_eth_rx_adapter.c
> @@ -230,7 +230,6 @@ testsuite_setup(void)
>  	}
> 
>  	struct rte_event_dev_config config = {
> -			.nb_event_queues = 1,
>  			.nb_event_ports = 1,
>  	};
> 
> @@ -242,6 +241,7 @@ testsuite_setup(void)
>  			dev_info.max_event_port_enqueue_depth;
>  	config.nb_events_limit =
>  			dev_info.max_num_events;
> +	config.nb_event_queues = dev_info.max_event_queues;
>  	err = rte_event_dev_configure(TEST_DEV_ID, &config);
>  	TEST_ASSERT(err == 0, "Event device initialization failed err %d\n",
>  			err);
> --
> 2.25.1
Jerin Jacob Feb. 26, 2025, 4:20 a.m. UTC | #2 
> -----Original Message-----
> From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> Sent: Tuesday, February 25, 2025 6:37 PM
> To: Shijith Thotton <sthotton@marvell.com>; Jerin Jacob <jerinj@marvell.com>
> Cc: dev@dpdk.org; Shijith Thotton <sthotton@marvell.com>; stable@dpdk.org;
> Naga Harish K S V <s.v.naga.harish.k@intel.com>
> Subject: RE: [PATCH] test/event: fix number of queues in eventdev conf
> 
> 
> 
> > -----Original Message-----
> > From: Shijith Thotton <sthotton@marvell.com>
> > Sent: Thursday, February 6, 2025 8:03 PM
> > To: Jerin Jacob <jerinj@marvell.com>
> > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula
> > <pbhagavatula@marvell.com>; Shijith Thotton <sthotton@marvell.com>;
> > stable@dpdk.org; Naga Harish K S V <s.v.naga.harish.k@intel.com>
> > Subject: [PATCH] test/event: fix number of queues in eventdev conf
> >
> > The unit test adapter_pollq_instance_get requires three event queues,
> > but the test suite was only configuring a single queue. This patch
> > updates the test suite setup function to configure max available queues.
> >
> > Fixes: a1793ee8aba0 ("eventdev/eth_rx: add adapter instance get API")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Shijith Thotton <sthotton@marvell.com>
> Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

Applied to dpdk-next-eventdev/for-main. Thanks
diff mbox series

Patch

diff --git a/app/test/test_event_eth_rx_adapter.c b/app/test/test_event_eth_rx_adapter.c
index 0233c87779..9a60e34352 100644
--- a/app/test/test_event_eth_rx_adapter.c
+++ b/app/test/test_event_eth_rx_adapter.c
@@ -230,7 +230,6 @@  testsuite_setup(void)
 	}
 
 	struct rte_event_dev_config config = {
-			.nb_event_queues = 1,
 			.nb_event_ports = 1,
 	};
 
@@ -242,6 +241,7 @@  testsuite_setup(void)
 			dev_info.max_event_port_enqueue_depth;
 	config.nb_events_limit =
 			dev_info.max_num_events;
+	config.nb_event_queues = dev_info.max_event_queues;
 	err = rte_event_dev_configure(TEST_DEV_ID, &config);
 	TEST_ASSERT(err == 0, "Event device initialization failed err %d\n",
 			err);