Message ID | 20241213092444.2987-1-ming.1.yang@nokia-sbell.com (mailing list archive) |
---|---|
State | New |
Delegated to: | Raslan Darawsheh |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A909E45B7C; Fri, 13 Dec 2024 10:25:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 44E5F402BB; Fri, 13 Dec 2024 10:25:11 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2069.outbound.protection.outlook.com [40.107.21.69]) by mails.dpdk.org (Postfix) with ESMTP id 405F340263 for <dev@dpdk.org>; Fri, 13 Dec 2024 10:25:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VckDRX9ebMa1ghTM1eyK3tRnXslPgUqf3JLj3HftFWq//SCvLvEeXjxzGJ9AtD5Qo7ilxoMh7e1BYFTelEv6SOEoN/zWQMwwd1+zpNyrNu6CTeIulw+sc8+wfGJaEqeLcS68KnXXdVjXsXb829WUf4oZfYh8QFFkTB43NG+p5ivV9fBLb0TRqwoFhjozs3UqUoQuwBAjPfsCaT2FyBgF/hSPsd79fheCqHO36pExSfb+4jL0cPXmsjiPl9YCOyShTzCOMUuSobD+gvHbUUwFdQty7V/R0/P/fZumga8BEGvYUATusszn0gtaztT4pMIrWTJ/zrIxyGDAjAXHfI6iUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lahW9QSwG4rk7ZvgXUc3Ml4jJQXAfcXfNyRGhml5cj4=; b=P/t6BGZldh1NNKfgBDkxG4CJdwFA5ThOx7EKIYKVz/Jeh3JKEHjyJnyGc9/IresyABqYNvoYoz8I7Qj37yTZw/2YAhAAcCYFwqLOdGGiDRetp0h+RlZM28rQg7swX0rYSO5iTwzzMjXyvjdSIA3rUcs2aI3Lo1iYAe0AzmEOUZzaoYZexCNGCbeyCYnbUoysHIposWZUTTEO/YzEuFgjn7eGwA5NOqw/AShunZbxNBMFRAmmNx49/CwydBAVXTIspEiMfewYLlfCn3Bw53h8gILx4AWkpTWqUNQF4yw0VgR+PTcjBBOSC8GckzG4FxTnTkjYV7xw++nWngxSs/ZREg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia-sbell.com; dmarc=pass action=none header.from=nokia-sbell.com; dkim=pass header.d=nokia-sbell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia-sbell.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lahW9QSwG4rk7ZvgXUc3Ml4jJQXAfcXfNyRGhml5cj4=; b=pMt5gCganHYjZAHhA7+LlVJniBooy/two2V9md19gtd+4PElAkjQjZqc/W7JxQI2es+q4ceIXwDtxYJ0W2qNsmm8mG9RjAPh82tTGxY2CCHwIEF68xl4BjNIPfcS9kes67TcGlbmUHnH8cmzu8VRtihxg5dnVQf78WyJ9NJYA4i8gJPI5D2phF//TcLhySNon4l77lODBfplUx5EyRqkF4NfcryaKC3gpqzZo4v3JJbR3REPy9OllVqtpyElmtZaST1G6MOrFenrb242HVfSQI92gNCsY5CQWJ0weT+Uv3AnaANuoGrmQLeYAroBfFc5gaGQoLMQCGT0iqKS2OnhoA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nokia-sbell.com; Received: from VI1PR07MB9898.eurprd07.prod.outlook.com (2603:10a6:800:119::6) by DB9PR07MB9624.eurprd07.prod.outlook.com (2603:10a6:10:306::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8251.15; Fri, 13 Dec 2024 09:25:06 +0000 Received: from VI1PR07MB9898.eurprd07.prod.outlook.com ([fe80::1928:4afb:4eee:1f21]) by VI1PR07MB9898.eurprd07.prod.outlook.com ([fe80::1928:4afb:4eee:1f21%7]) with mapi id 15.20.8251.008; Fri, 13 Dec 2024 09:25:06 +0000 From: Yang Ming <ming.1.yang@nokia-sbell.com> To: Dariusz Sosnowski <dsosnowski@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>, Matan Azrad <matan@nvidia.com> Cc: dev@dpdk.org, Yang Ming <ming.1.yang@nokia-sbell.com> Subject: [PATCH 1/2] net/mlx5: improve socket file path Date: Fri, 13 Dec 2024 17:24:42 +0800 Message-Id: <20241213092444.2987-1-ming.1.yang@nokia-sbell.com> X-Mailer: git-send-email 2.34.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SI2PR01CA0001.apcprd01.prod.exchangelabs.com (2603:1096:4:191::13) To VI1PR07MB9898.eurprd07.prod.outlook.com (2603:10a6:800:119::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR07MB9898:EE_|DB9PR07MB9624:EE_ X-MS-Office365-Filtering-Correlation-Id: 91a389fb-264a-4f00-c158-08dd1b58082e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: P2SXMoj5ujAz/fq4d+zjJhKJpAtPVtFnBOOPdcK8qPfYI5fV8Quq9z21hytveGi6u0as6g0l+B8xrqlj9NCHi6yZ7Y2GlH1P54S+fpANRwYGGQt7PQDHDM6HegdpGKlT/bsEPhFk/fIJBcO0/VN/fu3YblJKxMRzA8fSIWNCG2bzQoMkNhxawPFJ19/34TqiMldl93ucN/MNzJ7JPdbVWgQ8Qs6TeF5zNCe5UV0yDFCHiDnHOEs3ueTFJP9wIufeyKkbFyurdIYsGhM3chTC75GPIklQubE04AVAfCfH9U+IFCE/Ojq4LQXKXfX1W7vWlW1FZlZ5wE+xyqJihHwVkBspqF9XoeBRKdUMUEqDknqPoys6JdU4IeMX0B26phv32S/mA126QcsSQWkMKTQNBEsEMUWqN6tomidPWLIOliiMHJR6fm6EZzd1eYW+1/eex66/RFiS0nRBPK+HKAToIzkakmJyf0UPphYIxdMiHBjWfepLoybgyDxTqkLGjNPDK23Jd9UR238Rz+jK0ZCHrTdeKSQZON+HbbyLhKnUX35wwza3cd1AwnOHNU9ACPxdYnaO/U7R/Y7Izx1pw25X2Wr2PPNdSnj4UDJQszuDuCOYVlRykLC+tOSRAbCmfQo8K6B1+7t1550mfS/inWxngQH5Dmefj62pxF6t9C8FBaqpNMgzrITVKrOv8OMHuc8fKSaQQtBLyqahg9bN6O3XyZTZ669p7DfD3u1VAwKdt1SbNvVJzsEECBuGX8obI4ngeSQ9EHbzE20O4FLV9g1MO0t3gFYZ09+Hiba9jL7fAAcaTUJS8KUzUNo90RC7UqQ/3dhxxqu0fQ10UI1Yif1Oz5wSU1CznRLkDj/uEt4kFnO4CxQWHwIl1rEkf17SR27tF0NIjyTLeGweKnn04efmUkaYDCmNfPrapGzNTxiaotPiykcUVepW7sb9sZvmqI9wxyTKVWMl4oOh01oAgH2DKRKLLKOvc3mWIYI583PqDYwXKzp2i8Da9rtSUJBmwtuFC58Z417nJam/dSqD7dvE/Z0RvEvjP8lhdUFQORQHiy+vEgOlN6RbTGW/Yeb3xAwDNxURZZZKYBUd8/VlKLh3cQzoB7WMUBYzY+fl/vOUc5QnUXC+KTl5NGOSf8VJCTaKKyDHde5GSkDBbAzkWjjK+/p3mG6F/p9+1N+3Mmoic93GCAHgZOcO0I4sET9NI+samoCHsr4QWexCeDTf3PltnQhy3PS7vdDY7SN4aqufp7PeABa67DnnQcYIoVhFJcWLbuftvj8iQqr1ThUwYbAlo4/a+QYz1f3uVYDGCcLX34oWK4OOWAhA5PVCHhrUjBbJH5B9JwFcIrHkZWKjDowdx+Z/JtInjsyxLm4X5PCBU4ufvh8V8n5GWHEob6S9HtvH X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR07MB9898.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: GNYLUv0OdMJQ5Xa1weTeiad7M3uHa5MAXX+Nz3BnHspdha7KgS2Dcbio2NhTirYIN+CBCOgipxr05CNiEsc4N6e6ps0htyKD2N0mky+5X1WCo7sVraugXJXZKxoHStq5gmjiWV7Jcgq0aCMiEsVPboZZ8Ib3C+c7v+XDRKU/K2f2Jp4TSqAh8rzSYx0R8F13X7V5dMhd3i4sgXkAQKfb1dJoNZc8FTFbTjrFxviUGuv5rwmGz3sR9vZacWei881D+/lrlLWXgSNJcKTMi0BnXvrt1GEmm18WFsWsjnUEgNpx/Vz6QI72iWLp8cueTLoLz8QMgU8lE/RQaN4SIa7nL0vNODpUbzVXgH7lpoHFGh9lLesw752YsYLJnsm1yVq4GT7y+tWqW5yXAekt+THyk3gFqjJP9tllyuIgdzWCadTWiJSQR3mgTym1Pq17JhWoxtKJofvRZrwU47DBt3W+a79knH2VaOoG6bbi44BMF7Ycuqy0Xg2o8kU7V7RjFZTwcb6LbAHtHudN8NgJDrkxc60yKtPHNbO6L8kjTYlDnrkdGv7GajhaNC8irGBeN0jhDmHlpfguvNXAMoisOf5QGLn9STpiyAt8ocQCZKRDu7k6rFHdGTAB0q4qYr1YlY5c57wZLb8QIx1+2l4rpoydnQ32q6eX+iQ2RuV1jCsrVe5XFQjlxwUUyk/HzRO769j/xuChpVmdTu7ppL4romjMs0QO6k8KShRTuAvCh6rHOeLS+ZgTe6pj3ZRI4rqB2qEjocwh+kG18xVf8lwk2/Iw1NGsy9wZD+wrO9iQdMOTdhyz7sjXWou3rJu4/7H1jc9JWETnARVRca50FeJLzwGOGHsuEMYmKrOxg6glEUZPHAp2Gpi2S+IB0BVqiusUPtUQW1E1IYM48j0ddA2JZ+2xIV+3YamcXpwgpq/aDfJZ+Y6cm06zxJWccOPTTVe08sidd7lPGLK8txfI98GhS4SzlvPQsHagDg+EhpaAcYQZBMcJjhFYR0MfgwDZYbtT5bg8LYAOyN4tTN4y6JLjjWXfZEhAiE3cvKaevH/q0gZ815/aoA+vFi089RyKPEwEFVjM0OPb5uMhXXV5gconynmXPYM7397uzj2kYrsude/VCB4K6NyERT7KG4W6tVkTsg1c5Ja6DRdgzt19NvcnWwFhbiijC9/3754ByW3l6gioESyztM+q/NbPtOiYFN+b8tNxHUH3U//NF9rihKyZZv4YGpHT0babNjao2UnAwIk9UWnjdwM2pSwg+dpaEOOBIZu9CHJ4PXSPU+uK5S01sFca8euiIbluTTe54pAU4xv1eX/UoScTo5tVBPYX8vHQ4zunYeFfZR4LWWH4ZCGA1Butfsn+LDqn9OAoQaOlebtxz2AMK7FFDYOJ5pOsPqPvCY7Gfb0ax+6/e8zUjqH47hSoicTUZERWC/GhlolwacTfBLNMb300oI4zQIhtvOKiPVD/ZVRo163XsThcGu7rOsoazH1oHtUD2SND50caNETcraGJnmcGHeO8mgCfNwWdT5tSKbLFRLM13Y++HSoz/1Ng1cppy3vRv+kKl2uuqX7AyM7Hx7XOG+GBBrqWL0/wS+/VqAqioWmZ2mCocyoMRqlqBg== X-OriginatorOrg: nokia-sbell.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91a389fb-264a-4f00-c158-08dd1b58082e X-MS-Exchange-CrossTenant-AuthSource: VI1PR07MB9898.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2024 09:25:06.6188 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QWYHeURe2yaAmPYFkU+sY9AWG+YivkGDKwXKOOL4o1dHtKzBJVlob/W9xxLnzzuCz3N0duAZa1pryhyvwXnAGEJfBa4MQq2E+4q4ocP8X1A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR07MB9624 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
[1/2] net/mlx5: improve socket file path
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
Commit Message
Yang Ming
Dec. 13, 2024, 9:24 a.m. UTC
1. /var/tmp is hard code which is not a good style
2. /var/tmp may be not allowed to be written via container's
read only mode.
Signed-off-by: Yang Ming <ming.1.yang@nokia-sbell.com>
---
drivers/net/mlx5/linux/mlx5_socket.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
Comments
On Fri, 13 Dec 2024 17:24:42 +0800 Yang Ming <ming.1.yang@nokia-sbell.com> wrote: > 1. /var/tmp is hard code which is not a good style > 2. /var/tmp may be not allowed to be written via container's > read only mode. > > Signed-off-by: Yang Ming <ming.1.yang@nokia-sbell.com> Since this is a unix domain socket, why not use abstract socket that doesn't have to be associated with filesystem?
On Fri, Dec 13, 2024 at 09:12:39AM -0800, Stephen Hemminger wrote: > On Fri, 13 Dec 2024 17:24:42 +0800 > Yang Ming <ming.1.yang@nokia-sbell.com> wrote: > > > 1. /var/tmp is hard code which is not a good style > > 2. /var/tmp may be not allowed to be written via container's > > read only mode. > > > > Signed-off-by: Yang Ming <ming.1.yang@nokia-sbell.com> > > Since this is a unix domain socket, why not use abstract socket > that doesn't have to be associated with filesystem? In general, I think we should avoid abstract sockets in DPDK. Primary reason is that they are linux-specific. Last time I checked other unixes, like BSD, don't support them. A secondary concern is that having a filesystem path allows permission checks, so for e.g. telemetry sockets, only users with appropriate permissions can connect. With an abstract socket we'd have to open up the area of user authentication. /Bruce
On 2024/12/14 01:16, Bruce Richardson wrote: > On Fri, Dec 13, 2024 at 09:12:39AM -0800, Stephen Hemminger wrote: >> On Fri, 13 Dec 2024 17:24:42 +0800 >> Yang Ming<ming.1.yang@nokia-sbell.com> wrote: >> >>> 1. /var/tmp is hard code which is not a good style >>> 2. /var/tmp may be not allowed to be written via container's >>> read only mode. >>> >>> Signed-off-by: Yang Ming<ming.1.yang@nokia-sbell.com> >> Since this is a unix domain socket, why not use abstract socket >> that doesn't have to be associated with filesystem? > In general, I think we should avoid abstract sockets in DPDK. Primary > reason is that they are linux-specific. Last time I checked other unixes, > like BSD, don't support them. A secondary concern is that having a > filesystem path allows permission checks, so for e.g. telemetry sockets, > only users with appropriate permissions can connect. With an abstract socket > we'd have to open up the area of user authentication. > > /Bruce > Hi Stephen & Bruce, I'm not sure whether abstract socket is a good idea. Maybe it can be improved further or step by step. But we don't need to discuss it for this commit. We do this improvement because "/var/tmp" and "/var/log" can't be write in Readonly mode of container except that we add /var/ specfic for DPDK application in container's setting. But nearly all DPDK modules have already used common runtime path returned from `rte_eal_get_runtime_dir()`. Why not we apply this common path for Mellanox NIC?
diff --git a/drivers/net/mlx5/linux/mlx5_socket.c b/drivers/net/mlx5/linux/mlx5_socket.c index 6ce0e59643..7fa6e5345c 100644 --- a/drivers/net/mlx5/linux/mlx5_socket.c +++ b/drivers/net/mlx5/linux/mlx5_socket.c @@ -20,7 +20,7 @@ /* PMD socket service for tools. */ -#define MLX5_SOCKET_PATH "/var/tmp/dpdk_net_mlx5_%d" +#define MLX5_SOCKET_FNAME "dpdk_net_mlx5" #define MLX5_ALL_PORT_IDS 0xffff int server_socket = -1; /* Unix socket for primary process. */ @@ -177,8 +177,8 @@ mlx5_pmd_socket_init(void) ret = fcntl(server_socket, F_SETFL, flags | O_NONBLOCK); if (ret < 0) goto close; - snprintf(sun.sun_path, sizeof(sun.sun_path), MLX5_SOCKET_PATH, - getpid()); + snprintf(sun.sun_path, sizeof(sun.sun_path), "%s/%s_%d", + rte_eal_get_runtime_dir(), MLX5_SOCKET_FNAME, getpid()); remove(sun.sun_path); ret = bind(server_socket, (const struct sockaddr *)&sun, sizeof(sun)); if (ret < 0) { @@ -223,6 +223,7 @@ mlx5_pmd_socket_uninit(void) mlx5_pmd_socket_handle, NULL); claim_zero(close(server_socket)); server_socket = -1; - MKSTR(path, MLX5_SOCKET_PATH, getpid()); + MKSTR(path, "%s/%s_%d", rte_eal_get_runtime_dir(), MLX5_SOCKET_FNAME, + getpid()); claim_zero(remove(path)); }