net/ena: fix missing default llq policy

Message ID 20241212152455.510-1-shaibran@amazon.com (mailing list archive)
State Accepted
Delegated to: Stephen Hemminger
Headers
Series net/ena: fix missing default llq policy |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/github-robot: build success github build: passed
ci/iol-marvell-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-compile-amd64-testing warning Testing issues
ci/iol-abi-testing success Testing PASS

Commit Message

Brandes, Shai Dec. 12, 2024, 3:24 p.m. UTC
From: Shai Brandes <shaibran@amazon.com>

The driver failed to set a default llq_header_policy,
causing LLQ to be disabled when the devarg value is
not specified by the application.

Fixes: d7918d19d25e ("net/ena: restructure LLQ policy user setting")
Cc: stable@dpdk.org
Signed-off-by: Yosef Raisman <yraisman@amazon.com>
Signed-off-by: Shai Brandes <shaibran@amazon.com>
---
 drivers/net/ena/ena_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Stephen Hemminger Jan. 14, 2025, 11:36 p.m. UTC | #1
On Thu, 12 Dec 2024 17:24:55 +0200
<shaibran@amazon.com> wrote:

> From: Shai Brandes <shaibran@amazon.com>
> 
> The driver failed to set a default llq_header_policy,
> causing LLQ to be disabled when the devarg value is
> not specified by the application.
> 
> Fixes: d7918d19d25e ("net/ena: restructure LLQ policy user setting")
> Cc: stable@dpdk.org
> Signed-off-by: Yosef Raisman <yraisman@amazon.com>
> Signed-off-by: Shai Brandes <shaibran@amazon.com>
> ---

Multiple signed-off-by's is good, but please send a patch to
add Yosef to the .mailmap file.

$ ./devtools/check-git-log.sh
Contributor name/email mismatch with .mailmap: 
	Yosef Raisman <yraisman@amazon.com> is unknown in .mailmap
  

Patch

diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index bba48ea1cc..aea2e5c929 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -2330,6 +2330,7 @@  static int eth_ena_dev_init(struct rte_eth_dev *eth_dev)
 
 	/* Assign default devargs values */
 	adapter->missing_tx_completion_to = ENA_TX_TIMEOUT;
+	adapter->llq_header_policy = ENA_LLQ_POLICY_RECOMMENDED;
 
 	/* Get user bypass */
 	rc = ena_parse_devargs(adapter, pci_dev->device.devargs);