diff mbox series

[2/3] eventdev: fix uninitialized variable

Message ID 20241125064755.3943-3-wenwux.ma@intel.com (mailing list archive)
State New
Delegated to: Thomas Monjalon
Headers
Series fix uninitialized variable |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Wenwu Ma Nov. 25, 2024, 6:47 a.m. UTC 
This patch fixes the variable 'events' may be used uninitialized.

Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation")
Cc: stable@dpdk.org

Signed-off-by: Wenwu Ma <wenwux.ma@intel.com>
---
 lib/eventdev/rte_event_crypto_adapter.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Gujjar, Abhinandan S Nov. 27, 2024, 10:49 a.m. UTC | #1 
> -----Original Message-----
> From: Ma, WenwuX <wenwux.ma@intel.com>
> Sent: Monday, November 25, 2024 12:18 PM
> To: ajit.khaparde@broadcom.com; somnath.kotur@broadcom.com;
> amitprakashs@marvell.com; Gujjar, Abhinandan S
> <abhinandan.gujjar@intel.com>; dev@dpdk.org; stable@dpdk.org
> Cc: Liao, TingtingX <tingtingx.liao@intel.com>; Ma, WenwuX
> <wenwux.ma@intel.com>
> Subject: [PATCH 2/3] eventdev: fix uninitialized variable
> 
> This patch fixes the variable 'events' may be used uninitialized.
> 
> Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wenwu Ma <wenwux.ma@intel.com>
> ---
>  lib/eventdev/rte_event_crypto_adapter.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/eventdev/rte_event_crypto_adapter.c
> b/lib/eventdev/rte_event_crypto_adapter.c
> index 939ca1cad9..1ca839510b 100644
> --- a/lib/eventdev/rte_event_crypto_adapter.c
> +++ b/lib/eventdev/rte_event_crypto_adapter.c
> @@ -685,6 +685,7 @@ eca_ops_enqueue_burst(struct
> event_crypto_adapter *adapter,
>  	nb_ev = 0;
>  	retry = 0;
>  	nb_enqueued = 0;
> +	memset(events, 0, sizeof(events));
There is a rte_memcpy() at line number 699 which is copying response information as event into this.
So, that will initialize all the event fields. We don't require to initialize events here.

>  	num = RTE_MIN(num, BATCH_SIZE);
>  	for (i = 0; i < num; i++) {
>  		struct rte_event *ev = &events[nb_ev++];
> --
> 2.34.1
diff mbox series

Patch

diff --git a/lib/eventdev/rte_event_crypto_adapter.c b/lib/eventdev/rte_event_crypto_adapter.c
index 939ca1cad9..1ca839510b 100644
--- a/lib/eventdev/rte_event_crypto_adapter.c
+++ b/lib/eventdev/rte_event_crypto_adapter.c
@@ -685,6 +685,7 @@  eca_ops_enqueue_burst(struct event_crypto_adapter *adapter,
 	nb_ev = 0;
 	retry = 0;
 	nb_enqueued = 0;
+	memset(events, 0, sizeof(events));
 	num = RTE_MIN(num, BATCH_SIZE);
 	for (i = 0; i < num; i++) {
 		struct rte_event *ev = &events[nb_ev++];