[v2] doc: update match with compare result item limitation

Message ID 20241106093415.1062069-1-suanmingm@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series [v2] doc: update match with compare result item limitation |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Functional success Functional PASS
ci/iol-compile-amd64-testing pending Testing pending
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS

Commit Message

Suanming Mou Nov. 6, 2024, 9:34 a.m. UTC
In switch mode, when ``repr_matching_en`` flag is enabled in the devarg,
the match with compare result item is not supported to the ``ingress``
rule as an implicit REPRESENTED_PORT need to be added to the matcher.
That REPRESENTED_PORT item conflicts with the single item limitation for
match with compare result item.

Fixes: cb25df7ce9d6 ("net/mlx5: support comparison matching")
Cc: stable@dpdk.org

Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
---

v2: Add `repr_matching_en`` enabled by default explanation.

---
 doc/guides/nics/mlx5.rst | 5 +++++
 1 file changed, 5 insertions(+)
  

Comments

Bing Zhao Nov. 12, 2024, 7:13 a.m. UTC | #1
Thanks.

> -----Original Message-----
> From: Suanming Mou <suanmingm@nvidia.com>
> Sent: Wednesday, November 6, 2024 5:34 PM
> To: Dariusz Sosnowski <dsosnowski@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Bing Zhao <bingz@nvidia.com>; Ori Kam
> <orika@nvidia.com>; Matan Azrad <matan@nvidia.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH v2] doc: update match with compare result item limitation
> 
> In switch mode, when ``repr_matching_en`` flag is enabled in the devarg,
> the match with compare result item is not supported to the ``ingress``
> rule as an implicit REPRESENTED_PORT need to be added to the matcher.
> That REPRESENTED_PORT item conflicts with the single item limitation for
> match with compare result item.
> 
> Fixes: cb25df7ce9d6 ("net/mlx5: support comparison matching")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>

Acked-by: Bing Zhao <bingz@nvidia.com>

> ---
> 
> v2: Add `repr_matching_en`` enabled by default explanation.
> 
> ---
>  doc/guides/nics/mlx5.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index
> 7ced6ca8f9..64933a0823 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -460,6 +460,11 @@ Limitations
>    - The field type ``RTE_FLOW_FIELD_VALUE`` must be the base (``b``)
> field.
>    - The field type ``RTE_FLOW_FIELD_RANDOM`` can only be compared with
>      ``RTE_FLOW_FIELD_VALUE``.
> +  - In switch mode, when ``repr_matching_en`` flag is enabled (by
> default)
> +    in the devarg, the match with compare result item is not supported to
> +    the ``ingress`` rule as an implicit REPRESENTED_PORT need to be added
> to
> +    the matcher. That REPRESENTED_PORT item conflicts with the single
> item
> +    limitation for match with compare result item.
> 
>  - No Tx metadata go to the E-Switch steering domain for the Flow group 0.
>    The flows within group 0 and set metadata action are rejected by
> hardware.
> --
> 2.34.1
  
Raslan Darawsheh Nov. 26, 2024, 8:10 a.m. UTC | #2
Hi,

From: Suanming Mou <suanmingm@nvidia.com>
Sent: Wednesday, November 6, 2024 11:34 AM
To: Dariusz Sosnowski; Slava Ovsiienko; Bing Zhao; Ori Kam; Matan Azrad
Cc: dev@dpdk.org; stable@dpdk.org
Subject: [PATCH v2] doc: update match with compare result item limitation

In switch mode, when ``repr_matching_en`` flag is enabled in the devarg,
the match with compare result item is not supported to the ``ingress``
rule as an implicit REPRESENTED_PORT need to be added to the matcher.
That REPRESENTED_PORT item conflicts with the single item limitation for
match with compare result item.

Fixes: cb25df7ce9d6 ("net/mlx5: support comparison matching")
Cc: stable@dpdk.org

Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
---

v2: Add `repr_matching_en`` enabled by default explanation.

----

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh
  

Patch

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 7ced6ca8f9..64933a0823 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -460,6 +460,11 @@  Limitations
   - The field type ``RTE_FLOW_FIELD_VALUE`` must be the base (``b``) field.
   - The field type ``RTE_FLOW_FIELD_RANDOM`` can only be compared with
     ``RTE_FLOW_FIELD_VALUE``.
+  - In switch mode, when ``repr_matching_en`` flag is enabled (by default)
+    in the devarg, the match with compare result item is not supported to
+    the ``ingress`` rule as an implicit REPRESENTED_PORT need to be added to
+    the matcher. That REPRESENTED_PORT item conflicts with the single item
+    limitation for match with compare result item.
 
 - No Tx metadata go to the E-Switch steering domain for the Flow group 0.
   The flows within group 0 and set metadata action are rejected by hardware.