diff mbox series

[v1] examples/fips_validation: prehash input for RSA

Message ID 20241029060107.1135-1-gmuthukrishn@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series [v1] examples/fips_validation: prehash input for RSA |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Functional success Functional PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-marvell-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS

Commit Message

Gowrishankar Muthukrishnan Oct. 29, 2024, 6:01 a.m. UTC 
Plain text needs to be prehashed for RSA as well in asymmetric
crypto validation.

Fixes: 12ede9ac497f ("examples/fips_validation: support EdDSA")

Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
---
 examples/fips_validation/main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Dooley, Brian Oct. 30, 2024, 11:29 a.m. UTC | #1 
> -----Original Message-----
> From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> Sent: Tuesday 29 October 2024 06:01
> To: dev@dpdk.org; Dooley, Brian <brian.dooley@intel.com>; Gowrishankar
> Muthukrishnan <gmuthukrishn@marvell.com>
> Cc: Anoob Joseph <anoobj@marvell.com>; Akhil Goyal <gakhil@marvell.com>
> Subject: [PATCH v1] examples/fips_validation: prehash input for RSA
> 
> Plain text needs to be prehashed for RSA as well in asymmetric crypto
> validation.
> 
> Fixes: 12ede9ac497f ("examples/fips_validation: support EdDSA")
> 
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> ---
>  examples/fips_validation/main.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/examples/fips_validation/main.c
> b/examples/fips_validation/main.c index b34015ad9f..f21826e9d7 100644
> --- a/examples/fips_validation/main.c
> +++ b/examples/fips_validation/main.c
> @@ -1940,7 +1940,8 @@ fips_run_test(void)
>  		return fips_run_asym_test();
>  	}
> 
> -	if (info.algo == FIPS_TEST_ALGO_ECDSA) {
> +	if (info.algo == FIPS_TEST_ALGO_ECDSA ||
> +	    info.algo == FIPS_TEST_ALGO_RSA) {
>  		vec.cipher_auth.digest.len =
> 
> 	parse_test_sha_hash_size(info.interim_info.ecdsa_data.auth);
>  		test_ops.prepare_sym_xform = prepare_sha_xform;
> --
> 2.37.1

Acked-by: Brian Dooley <brian.dooley@intel.com>
Akhil Goyal Nov. 19, 2024, 9:10 a.m. UTC | #2 
> > Subject: [PATCH v1] examples/fips_validation: prehash input for RSA
> >
> > Plain text needs to be prehashed for RSA as well in asymmetric crypto
> > validation.
> >
> > Fixes: 12ede9ac497f ("examples/fips_validation: support EdDSA")
> >
> > Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> Acked-by: Brian Dooley <brian.dooley@intel.com>
Applied to dpdk-next-crypto
Thanks.
diff mbox series

Patch

diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c
index b34015ad9f..f21826e9d7 100644
--- a/examples/fips_validation/main.c
+++ b/examples/fips_validation/main.c
@@ -1940,7 +1940,8 @@  fips_run_test(void)
 		return fips_run_asym_test();
 	}
 
-	if (info.algo == FIPS_TEST_ALGO_ECDSA) {
+	if (info.algo == FIPS_TEST_ALGO_ECDSA ||
+	    info.algo == FIPS_TEST_ALGO_RSA) {
 		vec.cipher_auth.digest.len =
 			parse_test_sha_hash_size(info.interim_info.ecdsa_data.auth);
 		test_ops.prepare_sym_xform = prepare_sha_xform;