[v2] common/cnxk: allow enabling IOVA field in mbuf
Checks
Commit Message
The value of RTE_IOVA_IN_MBUF has always been disabled on CNXK
platforms, as IOVA in the mbuf is unnecessary. This update changes that
behavior to respect the value set by the user. A warning message will be
printed if the build is configured to enable IOVA on the CNXK platform.
Signed-off-by: Shijith Thotton <sthotton@marvell.com>
---
v2:
- Don't override the default value of RTE_IOVA_IN_MBUF in CNXK platform.
- Print a warning message if IOVA in mbuf is enabled on CNXK platform.
config/arm/meson.build | 8 ++------
drivers/common/cnxk/meson.build | 6 ++++++
2 files changed, 8 insertions(+), 6 deletions(-)
Comments
On Fri, Oct 25, 2024 at 03:20:40PM +0530, Shijith Thotton wrote:
> The value of RTE_IOVA_IN_MBUF has always been disabled on CNXK platforms,
> as IOVA in the mbuf is unnecessary. This update changes that behavior to
> respect the value set by the user. A warning message will be printed if
> the build is configured to enable IOVA on the CNXK platform.
>
> Signed-off-by: Shijith Thotton <sthotton@marvell.com> --- v2: - Don't
> override the default value of RTE_IOVA_IN_MBUF in CNXK platform. - Print
> a warning message if IOVA in mbuf is enabled on CNXK platform.
>
> config/arm/meson.build | 8 ++------
> drivers/common/cnxk/meson.build | 6 ++++++ 2 files changed, 8
> insertions(+), 6 deletions(-)
>
I think you probably need some doc updates for this. The current doc (cnxk
platform guide) says "Meson build option enable_iova_as_pa is disabled on
CNXK platforms." This is no longer true. Instead, you probably need to put
- in more than one place in the docs, I suggest - a note telling the user
that the option should be disabled.
/Bruce
>On Fri, Oct 25, 2024 at 03: 20: 40PM +0530, Shijith Thotton wrote: > The value
>of RTE_IOVA_IN_MBUF has always been disabled on CNXK platforms, > as
>IOVA in the mbuf is unnecessary. This update changes that behavior to >
>respect the value
>
>On Fri, Oct 25, 2024 at 03:20:40PM +0530, Shijith Thotton wrote:
>> The value of RTE_IOVA_IN_MBUF has always been disabled on CNXK
>platforms,
>> as IOVA in the mbuf is unnecessary. This update changes that behavior to
>> respect the value set by the user. A warning message will be printed if
>> the build is configured to enable IOVA on the CNXK platform.
>>
>> Signed-off-by: Shijith Thotton <sthotton@marvell.com> --- v2: - Don't
>> override the default value of RTE_IOVA_IN_MBUF in CNXK platform. - Print
>> a warning message if IOVA in mbuf is enabled on CNXK platform.
>>
>> config/arm/meson.build | 8 ++------
>> drivers/common/cnxk/meson.build | 6 ++++++ 2 files changed, 8
>> insertions(+), 6 deletions(-)
>>
>I think you probably need some doc updates for this. The current doc (cnxk
>platform guide) says "Meson build option enable_iova_as_pa is disabled on
>CNXK platforms." This is no longer true. Instead, you probably need to put
>- in more than one place in the docs, I suggest - a note telling the user
>that the option should be disabled.
>
Thanks, will update the documentation.
@@ -459,10 +459,7 @@ soc_cn9k = {
'description': 'Marvell OCTEON 9',
'implementer': '0x43',
'part_number': '0xb2',
- 'numa': false,
- 'flags': [
- ['RTE_IOVA_IN_MBUF', 0]
- ]
+ 'numa': false
}
soc_cn10k = {
@@ -471,8 +468,7 @@ soc_cn10k = {
'flags': [
['RTE_MAX_LCORE', 24],
['RTE_MAX_NUMA_NODES', 1],
- ['RTE_MEMPOOL_ALIGN', 128],
- ['RTE_IOVA_IN_MBUF', 0]
+ ['RTE_MEMPOOL_ALIGN', 128]
],
'part_number': '0xd49',
'extra_march_features': ['crypto'],
@@ -108,4 +108,10 @@ deps += ['bus_pci', 'net', 'telemetry']
require_iova_in_mbuf = false
+cnxk_socs = ['cn9k', 'cn10k', 'cn20k']
+
+if dpdk_conf.get('RTE_IOVA_IN_MBUF') == 1 and soc_type in cnxk_socs
+ warning('IOVA in mbuf is not required on platform ' + soc_type)
+endif
+
annotate_locks = false