From patchwork Wed Aug 7 19:36:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dean Marx X-Patchwork-Id: 143006 X-Patchwork-Delegate: juraj.linkes@pantheon.tech Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C34645760; Wed, 7 Aug 2024 21:36:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E5E7B4113D; Wed, 7 Aug 2024 21:36:05 +0200 (CEST) Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by mails.dpdk.org (Postfix) with ESMTP id 2AC3740E27 for ; Wed, 7 Aug 2024 21:36:04 +0200 (CEST) Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-6b5dfcfb165so1687566d6.0 for ; Wed, 07 Aug 2024 12:36:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1723059363; x=1723664163; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hvMQ/JhzgtcsC6KtWk+vZQG8OZO7EdzJexOK4bU6b2k=; b=Cz6lA4WHmJW6uInZpOEyzyccBc2ibeVRfmJhfYNSIeOqg13JngaFfWYY07ZBKEtSyY ZVC03x6BLOlqD7Qb7yvMkXS9a5UvkQhnuR1zatVtHgN7Xi/vtzYOUVvWA/XJHd+2ZvCh Xizwms+QywrrvFE1HwVtQu8dE2TPMehQGvQjI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723059363; x=1723664163; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hvMQ/JhzgtcsC6KtWk+vZQG8OZO7EdzJexOK4bU6b2k=; b=hzttCi8BK9hsVwForpG3iXfSvQzJzlainMJ1h2CS81DjKhCTajXTJ21/4vXWNq5fp3 AqzpVqbvMhQThpsaxx+nYajzCIbOMiKP21cgAnDwPxElNwTuAMDM21zXDBX2cFe5d2oU wRQN1BwFVPC2xFez0aRFQJow13Adz/QmjU4Y2zTsPolyBQ7ezAToT/dHWbEUtGCVWdm/ j3KX4cquoiVI7LHHquBcUJNAUsPKq6jPrEcWJ20UADTmHHYLqY8d69PQcEVJznsu7zh0 7khn7AAL6mqt1OxgUejWux0OgURwg90ERBEwhm/X5XQ35iwwDNOqUyKSNL1VHJV+7VSt Ls8Q== X-Gm-Message-State: AOJu0YyCMPhkiWCSK6cLrDYVSR79ZD5bKJIEWOg2ISmByRKW/re6bvh5 As0JQ7jLeMUBSOzzlveQkTLvfbzAflCxEX6Qr/D7Ir1kOdl99pfyf19z0A8A0UA= X-Google-Smtp-Source: AGHT+IHontkZjhb1UBOHqhEMvxxdRJtdWRDyGzrVfDnIbfh3L1rlr8la5Tpd6+2I2IL9m53tvwgQEg== X-Received: by 2002:a05:6214:5546:b0:6b9:5d27:92 with SMTP id 6a1803df08f44-6bb983a96cemr237738286d6.8.1723059363456; Wed, 07 Aug 2024 12:36:03 -0700 (PDT) Received: from dean-laptop.iol.unh.edu ([2606:4100:3880:1271:f9bd:24da:464d:6294]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6bb9c78ecc7sm59757536d6.35.2024.08.07.12.36.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 12:36:02 -0700 (PDT) From: Dean Marx To: probb@iol.unh.edu, npratte@iol.unh.edu, jspewock@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, juraj.linkes@pantheon.tech Cc: dev@dpdk.org, Dean Marx Subject: [PATCH v9 2/2] dts: initial queue start/stop suite implementation Date: Wed, 7 Aug 2024 15:36:11 -0400 Message-ID: <20240807193611.23060-3-dmarx@iol.unh.edu> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240807193611.23060-1-dmarx@iol.unh.edu> References: <20240724183209.11192-1-dmarx@iol.unh.edu> <20240807193611.23060-1-dmarx@iol.unh.edu> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This suite tests the ability of the Poll Mode Driver to enable and disable Rx/Tx queues on a port. Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestSuite_queue_start_stop.py | 91 ++++++++++++++++++++++ 2 files changed, 93 insertions(+), 1 deletion(-) create mode 100644 dts/tests/TestSuite_queue_start_stop.py diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json index f02a310bb5..9882ddb3d8 100644 --- a/dts/framework/config/conf_yaml_schema.json +++ b/dts/framework/config/conf_yaml_schema.json @@ -187,7 +187,8 @@ "enum": [ "hello_world", "os_udp", - "pmd_buffer_scatter" + "pmd_buffer_scatter", + "queue_start_stop" ] }, "test_target": { diff --git a/dts/tests/TestSuite_queue_start_stop.py b/dts/tests/TestSuite_queue_start_stop.py new file mode 100644 index 0000000000..7533f0b395 --- /dev/null +++ b/dts/tests/TestSuite_queue_start_stop.py @@ -0,0 +1,91 @@ +# SPDX-License-Identifier: BSD-3-Clause +# Copyright(c) 2024 University of New Hampshire + +"""Rx/Tx queue start and stop functionality suite. + +This suite tests the ability of the poll mode driver to start and +stop either the Rx or Tx queue (depending on the port) during runtime, +and verify that packets are not received when one is disabled. + +Given a paired port topology, the Rx queue will be disabled on port 0, +and the Tx queue will be disabled on port 1. + +""" + +from scapy.layers.inet import IP # type: ignore[import-untyped] +from scapy.layers.l2 import Ether # type: ignore[import-untyped] +from scapy.packet import Raw # type: ignore[import-untyped] + +from framework.remote_session.testpmd_shell import SimpleForwardingModes, TestPmdShell +from framework.test_suite import TestSuite + + +class TestQueueStartStop(TestSuite): + """DPDK Queue start/stop test suite. + + Ensures Rx/Tx queue on a port can be disabled and enabled. + Verifies packets are not received when either queue is disabled. + The suite contains two test cases, Rx queue start/stop and + Tx queue start/stop, which each disable the corresponding + queue and verify that packets are not received/forwarded. + """ + + def set_up_suite(self) -> None: + """Set up the test suite. + + Setup: + Verify that at least two ports are open for session. + """ + self.verify(len(self._port_links) > 1, "Not enough ports") + + def send_packet_and_verify(self, should_receive: bool = True) -> None: + """Generate a packet, send to the DUT, and verify it is forwarded back. + + Args: + should_receive: Indicate whether the packet should be received. + """ + packet = Ether() / IP() / Raw(load="xxxxx") + received = self.send_packet_and_capture(packet) + contains_packet = any( + packet.haslayer(Raw) and b"xxxxx" in packet.load for packet in received + ) + self.verify( + should_receive == contains_packet, + f"Packet was {'dropped' if should_receive else 'received'}", + ) + + def test_rx_queue_start_stop(self) -> None: + """Verify packets are not received by port 0 when Rx queue is disabled. + + Test: + Create an interactive testpmd session, stop Rx queue on port 0, verify + packets are not received. + """ + with TestPmdShell(node=self.sut_node) as testpmd: + testpmd.set_forward_mode(SimpleForwardingModes.mac) + testpmd.stop_port_queue(0, 0, True) + testpmd.start() + self.send_packet_and_verify(should_receive=False) + stats = testpmd.show_port_stats(port_id=0) + self.verify( + stats.rx_packets == 0, + "Packets were received on Rx queue when it should've been disabled", + ) + + def test_tx_queue_start_stop(self) -> None: + """Verify packets are not forwarded by port 1 when Tx queue is disabled. + + Test: + Create an interactive testpmd session, stop Tx queue on port 1, verify + packets are not forwarded. + """ + with TestPmdShell(node=self.sut_node) as testpmd: + testpmd.set_forward_mode(SimpleForwardingModes.mac) + testpmd.stop_port_queue(1, 0, False) + testpmd.start() + self.send_packet_and_verify(should_receive=False) + stats = testpmd.show_port_stats(port_id=1) + self.verify( + stats.tx_packets == 0, + "Packets were forwarded on Tx queue when it should've been disabled", + )