diff mbox series

[3/4] test: make red test part of fast suite

Message ID 20240718191049.84865-4-stephen@networkplumber.org (mailing list archive)
State Rejected, archived
Delegated to: David Marchand
Headers
Series Enable more unit tests |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger July 18, 2024, 7:07 p.m. UTC 
The red tests were not run because not part of any suite.
Meson warning is:
 WARNING: Test "red_autotest" is not defined in any test suite

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 app/test/test_red.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bruce Richardson July 19, 2024, 9:14 a.m. UTC | #1 
On Thu, Jul 18, 2024 at 12:07:14PM -0700, Stephen Hemminger wrote:
> The red tests were not run because not part of any suite.
> Meson warning is:
>  WARNING: Test "red_autotest" is not defined in any test suite
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> ---
>  app/test/test_red.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test/test_red.c b/app/test/test_red.c
> index aa7538d51a..4bb17dce7a 100644
> --- a/app/test/test_red.c
> +++ b/app/test/test_red.c
> @@ -1877,6 +1877,6 @@ test_red_all(void)
>  
>  #endif /* !RTE_EXEC_ENV_WINDOWS */
>  
> -REGISTER_TEST_COMMAND(red_autotest, test_red);
> +REGISTER_FAST_TEST(red_autotest, true, true, test_red);
>  REGISTER_PERF_TEST(red_perf, test_red_perf);
>  REGISTER_PERF_TEST(red_all, test_red_all);
> -- 
> 2.43.0
>
David Marchand Aug. 6, 2024, 12:28 p.m. UTC | #2 
On Thu, Jul 18, 2024 at 9:11 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The red tests were not run because not part of any suite.
> Meson warning is:
>  WARNING: Test "red_autotest" is not defined in any test suite
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

There is an open bz about this unit test.
https://bugs.dpdk.org/show_bug.cgi?id=826
Bruce Richardson Aug. 6, 2024, 12:49 p.m. UTC | #3 
On Tue, Aug 06, 2024 at 02:28:13PM +0200, David Marchand wrote:
> On Thu, Jul 18, 2024 at 9:11 PM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > The red tests were not run because not part of any suite.
> > Meson warning is:
> >  WARNING: Test "red_autotest" is not defined in any test suite
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> There is an open bz about this unit test.
> https://bugs.dpdk.org/show_bug.cgi?id=826
> 
Do we need a "broken tests" placeholder suite, or is it better to just
leave the broken tests unassigned and warning in meson?

/Bruce
Stephen Hemminger Aug. 8, 2024, 4:12 p.m. UTC | #4 
On Tue, 6 Aug 2024 14:28:13 +0200
David Marchand <david.marchand@redhat.com> wrote:

> On Thu, Jul 18, 2024 at 9:11 PM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > The red tests were not run because not part of any suite.
> > Meson warning is:
> >  WARNING: Test "red_autotest" is not defined in any test suite
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>  
> 
> There is an open bz about this unit test.
> https://bugs.dpdk.org/show_bug.cgi?id=826
> 
> 

So bug reported but no action taken. Maybe time to turn off RED then :-)
David Marchand Oct. 4, 2024, 12:17 p.m. UTC | #5 
On Thu, Aug 8, 2024 at 6:18 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Tue, 6 Aug 2024 14:28:13 +0200
> David Marchand <david.marchand@redhat.com> wrote:
>
> > On Thu, Jul 18, 2024 at 9:11 PM Stephen Hemminger
> > <stephen@networkplumber.org> wrote:
> > >
> > > The red tests were not run because not part of any suite.
> > > Meson warning is:
> > >  WARNING: Test "red_autotest" is not defined in any test suite
> > >
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >
> > There is an open bz about this unit test.
> > https://bugs.dpdk.org/show_bug.cgi?id=826
> >
> So bug reported but no action taken. Maybe time to turn off RED then :-)
>

That's an option :-) but we did not announce it in before v24.11 LTS,
so it's late.
Can we schedule this for next LTS?
diff mbox series

Patch

diff --git a/app/test/test_red.c b/app/test/test_red.c
index aa7538d51a..4bb17dce7a 100644
--- a/app/test/test_red.c
+++ b/app/test/test_red.c
@@ -1877,6 +1877,6 @@  test_red_all(void)
 
 #endif /* !RTE_EXEC_ENV_WINDOWS */
 
-REGISTER_TEST_COMMAND(red_autotest, test_red);
+REGISTER_FAST_TEST(red_autotest, true, true, test_red);
 REGISTER_PERF_TEST(red_perf, test_red_perf);
 REGISTER_PERF_TEST(red_all, test_red_all);