diff mbox series

[2/2] net/nfp: fix AVX2 vector Rx function memory overrun

Message ID 20240717032445.442348-3-chaoyong.he@corigine.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series fix coverity issues |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-marvell-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS

Commit Message

Chaoyong He July 17, 2024, 3:24 a.m. UTC 
From: Long Wu <long.wu@corigine.com>

CI found that the 'rxb' in 'nfp_net_vec_avx2_recv_pkts()' may
cause memory overrun.

Coverity issue:439964
Fixes: b67555307628 ("net/nfp: add AVX2 Rx")

Signed-off-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
 drivers/net/nfp/nfp_rxtx_vec_avx2.c | 41 ++++++++++++++++++-----------
 1 file changed, 25 insertions(+), 16 deletions(-)
diff mbox series

Patch

diff --git a/drivers/net/nfp/nfp_rxtx_vec_avx2.c b/drivers/net/nfp/nfp_rxtx_vec_avx2.c
index 508ec7faa5..2a033133a1 100644
--- a/drivers/net/nfp/nfp_rxtx_vec_avx2.c
+++ b/drivers/net/nfp/nfp_rxtx_vec_avx2.c
@@ -117,29 +117,48 @@  nfp_vec_avx2_recv_set_rxpkt1(struct nfp_net_rxq *rxq,
 	nfp_net_rx_cksum(rxq, rxds, rx_pkt);
 }
 
-static inline void
+static inline int
 nfp_vec_avx2_recv1(struct nfp_net_rxq *rxq,
 		struct nfp_net_rx_desc *rxds,
-		struct rte_mbuf *rxb,
+		struct rte_mbuf **rxb,
 		struct rte_mbuf *rx_pkt)
 {
+	/* Allocate a new mbuf into the software ring. */
+	if (rte_pktmbuf_alloc_bulk(rxq->mem_pool, rxb, 1) < 0) {
+		PMD_RX_LOG(DEBUG, "RX mbuf alloc failed port_id=%u queue_id=%hu",
+				rxq->port_id, rxq->qidx);
+		nfp_net_mbuf_alloc_failed(rxq);
+		return -ENOMEM;
+	}
+
 	nfp_vec_avx2_recv_set_rxpkt1(rxq, rxds, rx_pkt);
 
-	nfp_vec_avx2_recv_set_des1(rxq, rxds, rxb);
+	nfp_vec_avx2_recv_set_des1(rxq, rxds, *rxb);
+
+	return 0;
 }
 
-static inline void
+static inline int
 nfp_vec_avx2_recv4(struct nfp_net_rxq *rxq,
 		struct nfp_net_rx_desc *rxds,
 		struct rte_mbuf **rxb,
 		struct rte_mbuf **rx_pkts)
 {
+	/* Allocate 4 new mbufs into the software ring. */
+	if (rte_pktmbuf_alloc_bulk(rxq->mem_pool, rxb, 4) < 0) {
+		PMD_RX_LOG(DEBUG, "RX mbuf bulk alloc failed port_id=%u queue_id=%hu",
+				rxq->port_id, rxq->qidx);
+		return -ENOMEM;
+	}
+
 	nfp_vec_avx2_recv_set_rxpkt1(rxq, rxds, rx_pkts[0]);
 	nfp_vec_avx2_recv_set_rxpkt1(rxq, rxds + 1, rx_pkts[1]);
 	nfp_vec_avx2_recv_set_rxpkt1(rxq, rxds + 2, rx_pkts[2]);
 	nfp_vec_avx2_recv_set_rxpkt1(rxq, rxds + 3, rx_pkts[3]);
 
 	nfp_vec_avx2_recv_set_des4(rxq, rxds, rxb);
+
+	return 0;
 }
 
 static inline bool
@@ -215,15 +234,8 @@  nfp_net_vec_avx2_recv_pkts(void *rx_queue,
 			_mm_storel_epi64((void *)&rx_pkts[avail],
 					_mm_loadu_si128((void *)rxb));
 
-			/* Allocate a new mbuf into the software ring. */
-			if (rte_pktmbuf_alloc_bulk(rxq->mem_pool, rxb, 1) < 0) {
-				PMD_RX_LOG(DEBUG, "RX mbuf alloc failed port_id=%u queue_id=%hu",
-						rxq->port_id, rxq->qidx);
-				nfp_net_mbuf_alloc_failed(rxq);
+			if (nfp_vec_avx2_recv1(rxq, rxds, rxb, rx_pkts[avail]) != 0)
 				goto recv_end;
-			}
-
-			nfp_vec_avx2_recv1(rxq, rxds, *rxb, rx_pkts[avail]);
 
 			avail++;
 			nb_hold++;
@@ -237,14 +249,11 @@  nfp_net_vec_avx2_recv_pkts(void *rx_queue,
 		_mm256_storeu_si256((void *)&rx_pkts[avail],
 				_mm256_loadu_si256((void *)rxb));
 
-		/* Allocate 4 new mbufs into the software ring. */
-		if (rte_pktmbuf_alloc_bulk(rxq->mem_pool, rxb, 4) < 0) {
+		if (nfp_vec_avx2_recv4(rxq, rxds, rxb, &rx_pkts[avail]) != 0) {
 			burst_receive = false;
 			continue;
 		}
 
-		nfp_vec_avx2_recv4(rxq, rxds, rxb, &rx_pkts[avail]);
-
 		avail += 4;
 		nb_hold += 4;
 	}