From patchwork Thu Jun 6 23:31:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 140846 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B9EA44178; Fri, 7 Jun 2024 01:31:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0937242D66; Fri, 7 Jun 2024 01:31:29 +0200 (CEST) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mails.dpdk.org (Postfix) with ESMTP id 5133442831 for ; Fri, 7 Jun 2024 01:31:27 +0200 (CEST) Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-6c4926bf9baso1201864a12.2 for ; Thu, 06 Jun 2024 16:31:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1717716685; x=1718321485; darn=dpdk.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=/H+OQbKeMtNAYf9weuGuT7Aft2ZxG64nvRTyjt7NpXk=; b=WZxzUj0IQmS7eZ/Flwx/yNu2d3wNrJOf+AHZPoBTe6TC/vfLIg58NaDk0VGVXndd0x FWO3HtuSb5CguqFvCooxLOHOSMZltjXjFhffFsFPO8BNtRLGCysMhq6tkQOIsbVq5JvM bqaiEpKyMKoTy0xpRBWDloq88zw+LmZyFddKk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717716685; x=1718321485; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/H+OQbKeMtNAYf9weuGuT7Aft2ZxG64nvRTyjt7NpXk=; b=ImM430qmlnz2NA4Bfd7puJK2FutaNge4HVGDTy8S37gv6Lcc+k9XuTvMN8vEqi/Vp9 mJRGYX2O7vNc3czvImZqx/4LXkJFO/98/Ww2JP1WGVlFftxtZ09m7lWItenvTkkj3uUG CV9+jajwMoZB9TNQ+yEK3e0bOxbwcguUllBaN8HV5dWwlFhdCndYQU8ZvSHbseS4WliL ObpAKGuX+CaonR8y49BQo09lhhouikCE+RqVDvQQuGIGKWTEvgFiFJxKpt6IAklxsWCm ilyoyPAsjOAMc0OMZc5oJj8/FCcKrx3Bf+B5StAoF0MN+WfSmN2gbNTt7duUXYf25bBC B4ww== X-Gm-Message-State: AOJu0YzydPPLAzIApDZN8q/zUCdfODpCkCmFQUJEadAIlxbPUJphLCqp TeegiQwS1jWBNnSN6geuuD6DDtsLr8zGIq9Nu8o9KCCdxbMsfuLUz208LaQ8tenJqem52MiNTFs 1+CJSRJBYZouxHfqfPWJBcBrpBa7GrVb0Rn5njFXlemazkWyWue25x59ke6Obzn7d9YdEYWkaIM GbwWAxe2bqPWGWsQ91MwoLcUcznKjT X-Google-Smtp-Source: AGHT+IEWxkA796Hn5oklNgycm2iQ/GfznQrD6oTSjW3dmpx4Mym0tbmJEUMmSxUU6gwUD9z+KkqoeQ== X-Received: by 2002:a17:90b:b13:b0:2b3:28df:96b1 with SMTP id 98e67ed59e1d1-2c2bcad0facmr947120a91.7.1717716685239; Thu, 06 Jun 2024 16:31:25 -0700 (PDT) Received: from localhost.localdomain ([2605:a601:a780:1400:18ae:5c68:8e66:e211]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c29c23fc94sm2262765a91.29.2024.06.06.16.31.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 16:31:24 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: stable@dpdk.org, Damodharam Ammepalli Subject: [PATCH 3/3] net/bnxt: fix backing store logging Date: Thu, 6 Jun 2024 16:31:16 -0700 Message-Id: <20240606233116.38445-4-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20240606233116.38445-1-ajit.khaparde@broadcom.com> References: <20240606233116.38445-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Backing store type count can increase with newer firmware. So a static bnxt_backing_store_types can cause unnecessary faults. Instead of logging the string for the backing store type, just log the value provided by the firmware. Fixes: fe2f715ca580 ("net/bnxt: support backing store v2") Cc: stable@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Damodharam Ammepalli --- drivers/net/bnxt/bnxt_hwrm.c | 48 ++++-------------------------------- 1 file changed, 5 insertions(+), 43 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 9ea5cc090f..fc142672f6 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -31,43 +31,6 @@ struct bnxt_plcmodes_cfg { uint16_t hds_threshold; }; -const char *bnxt_backing_store_types[] = { - "Queue pair", - "Shared receive queue", - "Completion queue", - "Virtual NIC", - "Statistic context", - "Slow-path TQM ring", - "Fast-path TQM ring", - "Unused", - "Unused", - "Unused", - "Unused", - "Unused", - "Unused", - "Unused", - "MR and MAV Context", - "TIM", - "Unused", - "Unused", - "Unused", - "Tx key context", - "Rx key context", - "Mid-path TQM ring", - "SQ Doorbell shadow region", - "RQ Doorbell shadow region", - "SRQ Doorbell shadow region", - "CQ Doorbell shadow region", - "QUIC Tx key context", - "QUIC Rx key context", - "Invalid type", - "Invalid type", - "Invalid type", - "Invalid type", - "Invalid type", - "Invalid type" -}; - const char *media_type[] = { "Unknown", "Twisted Pair", "Direct Attached Copper", "Fiber" }; @@ -6402,8 +6365,8 @@ int bnxt_hwrm_func_backing_store_qcaps_v2(struct bnxt *bp) ctxm->split[i] = rte_le_to_cpu_32(*p); PMD_DRV_LOG(DEBUG, - "type:%s size:%d multiple:%d max:%d min:%d split:%d init_val:%d init_off:%d init:%d bmap:0x%x\n", - bnxt_backing_store_types[ctxm->type], ctxm->entry_size, + "type:0x%x size:%d multiple:%d max:%d min:%d split:%d init_val:%d init_off:%d init:%d bmap:0x%x\n", + ctxm->type, ctxm->entry_size, ctxm->entry_multiple, ctxm->max_entries, ctxm->min_entries, ctxm->split_entry_cnt, init_val, init_off, BNXT_CTX_INIT_VALID(flags), ctxm->instance_bmap); @@ -6446,8 +6409,7 @@ int bnxt_hwrm_func_backing_store_types_count(struct bnxt *bp) HWRM_UNLOCK(); if (flags & HWRM_FUNC_BACKING_STORE_QCAPS_V2_OUTPUT_FLAGS_TYPE_VALID) { - PMD_DRV_LOG(DEBUG, "Valid types 0x%x - %s\n", - req.type, bnxt_backing_store_types[req.type]); + PMD_DRV_LOG(DEBUG, "Valid types 0x%x\n", req.type); types++; } } while (type != HWRM_FUNC_BACKING_STORE_QCAPS_V2_OUTPUT_TYPE_INVALID); @@ -6625,8 +6587,8 @@ int bnxt_hwrm_func_backing_store_cfg_v2(struct bnxt *bp, &req.page_size_pbl_level, &req.page_dir); PMD_DRV_LOG(DEBUG, - "Backing store config V2 type:%s last %d, instance %d, hw %d\n", - bnxt_backing_store_types[req.type], ctxm->last, j, w); + "Backing store config V2 type:0x%x last %d, instance %d, hw %d\n", + req.type, ctxm->last, j, w); if (ctxm->last && i == (w - 1)) req.flags = rte_cpu_to_le_32(BACKING_STORE_CFG_V2_IN_FLG_CFG_ALL_DONE);