From patchwork Tue May 7 12:42:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkat Kumar Ande X-Patchwork-Id: 139969 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9743243FC9; Tue, 7 May 2024 14:44:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21924433B6; Tue, 7 May 2024 14:43:56 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2079.outbound.protection.outlook.com [40.107.223.79]) by mails.dpdk.org (Postfix) with ESMTP id 24F85433A5; Tue, 7 May 2024 14:43:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gAVOQLwCwoG4OPbRvcE1/fh1XKfK31soFCRj3Q5HObpSS9kkr7PxuEojQBwNZjurxDNYyuhMaS4nHR1z94m5iXBdJahTOckCzfuqDqkwahE/cdSNOjU3QHBH7vegz81MQsaVcL0BZ90rIVvE583Jl2X1VT/F0MD8I7KA7dSoDjogwUCZFbPsaMrEWhCzXvXdY3l/MEbdZ4AAu01/PPv9M+Ci2cduKjd6hZEi3NFR1giKp9pyTuNDqSrz4xubiICCDfIjRxmbgjkz2U14MoqPTidlfRK40HsTZBHRiPOO/KuLpe8/NksYfOpVMwR5Do4JTd1g3UZRnY1bveOrcPoL9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g6VQZQqpG5NPBEPGBvEJKe0Q+PPM2+Ca+RmPZdwJABU=; b=lTh31rtSkX2ZKEIl426BD8FsNQZPCd2NfDxS/RI3z9nDsM6Zf6S4oMrrdiLdIcq0A6w8kC6l+aIA9l4VkEiPYyzY3/KM5Bq/OsfFZu40oVOqgIG+alrda6qDsZcKoDVYAARCAKObV66H8HjSYOcdc4l+K9rlgLd5myHRLlIeY4lL4+BBPK4x34TFViT5XmKpSTlFHf6dWO2C+0/8Uv/Q2WjB3Nyn7/Absz37j0JX/mKfLg1LPxlMun7+INbn/ehqfxz2YliszZ816zXyaKN9+JkYRo7VvUMEjLOZq1pSZDESIXzo8yJjE7YlTzyL8N/daGWm5c6TPggdE4M9Y75RgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g6VQZQqpG5NPBEPGBvEJKe0Q+PPM2+Ca+RmPZdwJABU=; b=RN82hsf2wS/k5PKRVDlWfzhekN5JfmULrPoey2/ziUQhpXwepjfN0qHG1qRT5a7IlApbfg78q+QDVHWHIHZ+e59HzpbEa/G3Ks8KLv6f4K9eWjN+lDw1yFYbOvmHF4l9z1RpiXPH7fBAgcgeUxP7cXHq4HUshr07pAgKziHj8Go= Received: from SA1P222CA0010.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:22c::12) by IA0PR12MB8351.namprd12.prod.outlook.com (2603:10b6:208:40e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42; Tue, 7 May 2024 12:43:48 +0000 Received: from SN1PEPF00036F40.namprd05.prod.outlook.com (2603:10b6:806:22c:cafe::7d) by SA1P222CA0010.outlook.office365.com (2603:10b6:806:22c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42 via Frontend Transport; Tue, 7 May 2024 12:43:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SN1PEPF00036F40.mail.protection.outlook.com (10.167.248.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7544.18 via Frontend Transport; Tue, 7 May 2024 12:43:47 +0000 Received: from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 7 May 2024 07:43:45 -0500 From: Venkat Kumar Ande To: CC: , Venkat Kumar Ande , Subject: [PATCH v2 06/25] net/axgbe: yellow carp devices do not need rrc Date: Tue, 7 May 2024 18:12:46 +0530 Message-ID: <20240507124305.2318-6-venkatkumar.ande@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240507124305.2318-1-venkatkumar.ande@amd.com> References: <20240412125013.10498-1-VenkatKumar.Ande@amd.com> <20240507124305.2318-1-venkatkumar.ande@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF00036F40:EE_|IA0PR12MB8351:EE_ X-MS-Office365-Filtering-Correlation-Id: 518f642b-b6a1-49f9-4532-08dc6e9356ea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|376005|36860700004|1800799015|82310400017; X-Microsoft-Antispam-Message-Info: OLIQ+qkuoA/z+h933tox80X1HqBiTmNoOzGM2/bKkziAXoXEc92u7hFngtP8+az5rBCTTOw6uQ69HP4xHi0mXdHRbvCkTUSnOJzdrL7+wzzNtObnr0OfPrvY3+l8/sVNyxDeB2QU3mYkMBBFt2sz2Rb5cuUbnRrg8vGXmqXm8L/qbo6wnVyph4bm2bgdI5zLwh4iL52IjttYs+keFhjg86KrqB+Bny7ZF3lABnwYeeCY1uMZ4uakzlgl4E8c3IyRlIku03+UMcwYr6BmDssh8L2Dip2V1fZO8f9otnNp5lhlTWliCpuW4Jepbj5m0rAlpN6C9DcAyMeAQQDgzSAjsHpbDXEagA7fB+KJfTZkPnShCkv1YQmwaGlHzWYgX2evRO3DWlIvai1q0tAGQEI/Uh0PJuDp6i2sBAFUOgqRDeLsVUWYIGuKxKc16tAKmKbQV/QrcQoTGhv4xbs+wbb/oEv4+eHElp5WlhFP17UKQv9oC89tHkYvwRN4FW1o+JIfsIh4nyAJ+JTCwlD/E9pjKeyQgY/TtTIw20ngYGUm8IAbHqwFCk7Nrr34YapB4+7sGRAwRbJ9KTau72nMSb6q06ldX9XFMFCFJLdZiLw73QqFTwJ58xS74FSDDtdRV01CRdnYQJ0hV/yQMrB3ptniFqdGwtkJqdsMsj3ainFq813yJrKzGuHc2UymTcGIEuFV4WxgekY489NeyEp2y0aXTPlb6zT7Kn2r/Mn1tjigrhzCZYC70Gv2lrnwXwuW4tZE9SPF+FUdd6ogx5/Oy2vBM0ZvvAGZBurIrO8w+BELwBolAiiMDgL9lmfAtZObnij45F/uAljuNT+8ujIbOoHl+31rQN6rNmUM9fXuRgbJc1MTkLNJPJ3bW36MlFibmzEc0+TlwWMx4YSLPN+KfmbfQTWUMeyy92KIdj8k7/KcB1B29XIVNyxD9OsIDvqhvpnR+jHrB+c41EIq4zUsBpByA8DxBSwtkK4A7PMubXUU5LbYM9bW7IuEy8Z4wVK9tmBEp7bYJoLgfnaYngyrhjxgSO4Tc5Lo1yxBgs8XqgbLD+rmdBVVsVatSWWJyCr6xe5ArP3v2jCmUNHyi9LyWlLTUzRY0D9TpfL9RMPxAKBTq2ZFkAEFoFzJ2zxzS8VY+sgS73OHBC5LpP9vkxdxlIJ4uJEF0CJK5BDcEZll0cgByp4aj08kreeSY7soC3mKgULzmuC9tvBH0JFELUAkpPNlE82/G3h3P47mxht1IYoGN7apgXErYKae491BmqwLCsvXWsPARsWnnQffjzMKvSUMBuSf4ICx8HGYWlylIisZCIKccy5RNpzFOt9+nVrWIGs5hGMnsuLj2PAl/61dMh3AWUgZJ8U1o8iPnyFNubdNTkMbKPPWF6e2LoLIRyvRnn/Z X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(376005)(36860700004)(1800799015)(82310400017); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 12:43:47.6428 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 518f642b-b6a1-49f9-4532-08dc6e9356ea X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF00036F40.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8351 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Link stability issues are noticed on Yellow carp platforms when Receiver Reset Cycle is issued. Since the CDR workaround is disabled on these platforms, the Receiver Reset Cycle is not needed. So, avoid issuing rrc on Yellow carp platforms. Without the fix the user will not get the link UP. Fixes: a5c7273771e8 ("net/axgbe: add phy programming APIs") Cc: stable@dpdk.org Signed-off-by: Venkat Kumar Ande --- drivers/net/axgbe/axgbe_ethdev.c | 5 +++++ drivers/net/axgbe/axgbe_ethdev.h | 1 + drivers/net/axgbe/axgbe_phy_impl.c | 2 +- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c index e5d8f7db02..86c2ec64e0 100644 --- a/drivers/net/axgbe/axgbe_ethdev.c +++ b/drivers/net/axgbe/axgbe_ethdev.c @@ -208,6 +208,7 @@ static struct axgbe_version_data axgbe_v2a = { .ecc_support = 1, .i2c_support = 1, .an_cdr_workaround = 1, + .enable_rrc = 1, }; static struct axgbe_version_data axgbe_v2b = { @@ -220,6 +221,7 @@ static struct axgbe_version_data axgbe_v2b = { .ecc_support = 1, .i2c_support = 1, .an_cdr_workaround = 1, + .enable_rrc = 1, }; static const struct rte_eth_desc_lim rx_desc_lim = { @@ -2269,6 +2271,9 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev) /* Yellow Carp devices do not need cdr workaround */ pdata->vdata->an_cdr_workaround = 0; + + /* Yellow Carp devices do not need rrc */ + pdata->vdata->enable_rrc = 0; } else { unknown_cpu = 1; } diff --git a/drivers/net/axgbe/axgbe_ethdev.h b/drivers/net/axgbe/axgbe_ethdev.h index df5d63c493..f122dfd516 100644 --- a/drivers/net/axgbe/axgbe_ethdev.h +++ b/drivers/net/axgbe/axgbe_ethdev.h @@ -463,6 +463,7 @@ struct axgbe_version_data { unsigned int ecc_support; unsigned int i2c_support; unsigned int an_cdr_workaround; + unsigned int enable_rrc; }; struct axgbe_mmc_stats { diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c index ee9dcbe3da..f51830f800 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -1708,7 +1708,7 @@ static int axgbe_phy_link_status(struct axgbe_port *pdata, int *an_restart) } /* No link, attempt a receiver reset cycle */ - if (phy_data->rrc_count++) { + if (pdata->vdata->enable_rrc && phy_data->rrc_count++) { phy_data->rrc_count = 0; axgbe_phy_rrc(pdata); }