From patchwork Tue May 7 12:42:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkat Kumar Ande X-Patchwork-Id: 139977 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F08943FC9; Tue, 7 May 2024 14:45:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6BBF3433CC; Tue, 7 May 2024 14:44:15 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2069.outbound.protection.outlook.com [40.107.244.69]) by mails.dpdk.org (Postfix) with ESMTP id B2365433B4 for ; Tue, 7 May 2024 14:44:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hN9XbgGRCR4kzcCoVlxJYUhmN1GDxOUGiraQwRfBwn9ZaTHtJcRneBNoTzqFoO/Yat5tGnWKIn7rmi++44jKaPvuoRkMeINQBdCPSs8oPwytbELrjk5IdLSmut4c+gXwgaVZEVcFOTdYW2wVeldXObCd9P94CIrQYAuLDGkGMJvQ+TywG00FHM55nRTRriMo9PuE/3v6M7FtWKMPniGQ2icrppB34B63raau0B9TUowvczns0AzFZtxGh0CY7m7enm5gBoPNV/qM0Ek35H6b1SjkYQRS6+mgPTKApqbrMR34nXIE7pAGcegabaXHxklEeYxAAYgTE4Upjfa5bpWJTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2xP0v/ui/VwTAlj9C4RWXzuoVFZIVFRHLaZg8tcZvE4=; b=Ha02tFaS8QWNp2Vu+4kjv3Si1vp8335Fz6LGyoa18onMtG/TudUnCBKU90aK1jOZrf8QaO5fvTQ4oTQAUskSYLgdppmMtSGmcxA953NWvMtoeo9XJuPlNNKzPTS8Cg640HeTei/uABsYQ37asBvpXoi2/DRTEwNGoUwR2Ec8q2HkU8+Ld8WpJR7rjmOrB7zAFAuEBgXXuS7kdifOZIxzn0hlb796dRVxL9rw83xnm7lm9OnzDUzJku9FDJKFTbCUxBHHbf+0wzwdGPVQGdmefm7AIZpvDDnN1KJtqt8SmwpPmTa2ZwZQbOx251bwe0tta17Dz+6sQHISHZ5WL5yjmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2xP0v/ui/VwTAlj9C4RWXzuoVFZIVFRHLaZg8tcZvE4=; b=3UGDn0qEZKT8bjTOsP5mWFOq2YkQgaUU0FelW8jT5ttD2Sf2p6oUHl90vhUyLRvncqhuwg5iuD8ptuM2T8HupJILFiB/K5iXtSa9engNGZmUavQtjSRcXrO+gzW4EwN9s17OVH3BJ05Djk1UUY6c7MIc09MtAB4QaPIaerxqUHs= Received: from PR2P264CA0010.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::22) by SA3PR12MB9105.namprd12.prod.outlook.com (2603:10b6:806:382::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Tue, 7 May 2024 12:44:10 +0000 Received: from SN1PEPF00036F42.namprd05.prod.outlook.com (2603:10a6:101:0:cafe::1b) by PR2P264CA0010.outlook.office365.com (2603:10a6:101::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42 via Frontend Transport; Tue, 7 May 2024 12:44:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SN1PEPF00036F42.mail.protection.outlook.com (10.167.248.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7544.18 via Frontend Transport; Tue, 7 May 2024 12:44:08 +0000 Received: from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 7 May 2024 07:44:06 -0500 From: Venkat Kumar Ande To: CC: , Venkat Kumar Ande Subject: [PATCH v2 14/25] net/axgbe: remove field of SFP diagnostic support Date: Tue, 7 May 2024 18:12:54 +0530 Message-ID: <20240507124305.2318-14-venkatkumar.ande@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240507124305.2318-1-venkatkumar.ande@amd.com> References: <20240412125013.10498-1-VenkatKumar.Ande@amd.com> <20240507124305.2318-1-venkatkumar.ande@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF00036F42:EE_|SA3PR12MB9105:EE_ X-MS-Office365-Filtering-Correlation-Id: 94769724-587b-486f-5b35-08dc6e93637d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|1800799015|376005|36860700004|82310400017; X-Microsoft-Antispam-Message-Info: drntu6FHXNMZar+xcG5G0ZEGGIZi6Z4ePhwW0wxpv/ZLzfeBqAveAfymuN/5zC38XboSccij2dfjrB+suPt3h7OkiijY0L+uz8/jHYCGcCFENUSG0bIjYTrjmDZ5v9xUlPsvF2VErwwe85/EzAVDlZOfIQ5pOtWtuKaD4nYaj4dH2eWYiDvrFDu6L1R7fulhk4MLJUMLtAtze9jwHRe0FDFKMJFtJzbH0BUyN1YFfeMqLvmqmkwafzu037APzKvShcFy8A5Bb/PDYFSSM4Iq2L9XB3g5SotpgrpV6Rsx5iwjxY7agnQLFNHi45bF+fycNK5sJHp/wJUaZ09yio9QoB4Vsf+4zlqxvzJ5rnVthTBoegOKs1HYPMS2fvd13seu9kUQqm3MPb3Dxj9XqSXh8q6fyiX2snTa9pz94dnMrOG+vAXuuUL38Bq/+OU4ZiYflIx4OR7yRqyu4XcPKjY34258WdBil20vyb45zY1tGOj2ttyhTvXRsGBp9/op8MH0lwiOdfAf5QoVfTmzx0lBPu3uFnKFQTZZAoaMB0yloiPi0RtaJE8fvExWlDO8ySLCt6XgZnoMsMK4qQV/va5TVdHt1QKSEXvD/uwinpf0Blne9c+RAyYbvlEnCMV0Jiz97ZV4ljE3DyNAxvunJM/krPdb7L5p/1fBYMoASq7a5dgW2Skz3Lj0pwgeTXIVa1+9CkFAmbsPTXXeWqVuXBKsD7XORm/BKUFmeSkMXkNmQ5d5Not86jk4Zcrk2DosgX1jW2Lw6mCfULJjrv3fj2CvGIY7qc7UHwO3ejUBU8AFyZMBsWR1tDXyIYQ10DdwkRhLXZt4iHYOBTtVfcumh0qrcTLHKrkeqC3DMww5QJraIXhJ/U11v6ijL7RHdfJdRH0nu1SakUzYphm7ljmbqTxtixJjw47NzaB9QW0nwqpD78NXh13N1C1hbjUwWSrNgTbagvxKOMQWUo08+VlMafqtGbOW7cgjUI5Mp1r/GnzS2U4ZqJxUw9oHYBgXXqPMGDxMW6h9WrgWXwMKjAzDFJWdLm0KNzs8KnZiXvMeSBLlVElHDIwx7vUjAc44hst48SaXJ9xF3Asj8DYO4vOuZ3tR32eR0CKEOQcb4bsBKLkmNLXQj0JEfLcmBan/ebUR15+C/lNVlPK0Js13q9aW7PzPfRbXBzzJ8DEwf+G+8mBUBGxIW53r1/rIhgYnKvTxcNs6kwLMvSjyFMxk4TmFz4NODGpl2ZAWoRhyVsW0+tme2cqDisFUFnjvo5P9WUEBJwvtW35wIXo01kTyUFCptNvzBi888jCPRoGa/eFVPELJjsOBOpWFeWCZ9YwdXJZk+vYxZcXpXHawbuZsWgyB0aXOAumyvmn+qTEFkBNMTM43RQxn+OwGe2wrJN3vf052Wt6A X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(1800799015)(376005)(36860700004)(82310400017); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 12:44:08.7081 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 94769724-587b-486f-5b35-08dc6e93637d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF00036F42.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9105 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver currently sets an indication of whether the SFP supports, and that the driver can obtain, diagnostics data. This isn't currently used by the driver. Remove this field and the logic supporting it. Signed-off-by: Venkat Kumar Ande Acked-by: Selwin Sebastian Signed-off-by: Venkat Kumar Ande --- drivers/net/axgbe/axgbe_phy_impl.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c index d2a2b124be..4dab2ccad0 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -219,7 +219,6 @@ struct axgbe_phy_data { unsigned int sfp_rx_los; unsigned int sfp_tx_fault; unsigned int sfp_mod_absent; - unsigned int sfp_diags; unsigned int sfp_changed; unsigned int sfp_phy_avail; unsigned int sfp_cable_len; @@ -702,14 +701,6 @@ static int axgbe_phy_sfp_read_eeprom(struct axgbe_port *pdata) if (memcmp(&phy_data->sfp_eeprom, &sfp_eeprom, sizeof(sfp_eeprom))) { phy_data->sfp_changed = 1; memcpy(&phy_data->sfp_eeprom, &sfp_eeprom, sizeof(sfp_eeprom)); - - if (sfp_eeprom.extd[AXGBE_SFP_EXTD_SFF_8472]) { - uint8_t diag_type; - diag_type = sfp_eeprom.extd[AXGBE_SFP_EXTD_DIAG]; - - if (!(diag_type & AXGBE_SFP_EXTD_DIAG_ADDR_CHANGE)) - phy_data->sfp_diags = 1; - } } else { phy_data->sfp_changed = 0; } @@ -770,7 +761,6 @@ static void axgbe_phy_sfp_reset(struct axgbe_phy_data *phy_data) phy_data->sfp_rx_los = 0; phy_data->sfp_tx_fault = 0; phy_data->sfp_mod_absent = 1; - phy_data->sfp_diags = 0; phy_data->sfp_base = AXGBE_SFP_BASE_UNKNOWN; phy_data->sfp_cable = AXGBE_SFP_CABLE_UNKNOWN; phy_data->sfp_speed = AXGBE_SFP_SPEED_UNKNOWN;