From patchwork Thu May 2 02:49:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 139787 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 420D543F63; Thu, 2 May 2024 04:52:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F4A2402DD; Thu, 2 May 2024 04:52:17 +0200 (CEST) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id 7F0BD402C5 for ; Thu, 2 May 2024 04:52:13 +0200 (CEST) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6ecff9df447so7146746b3a.1 for ; Wed, 01 May 2024 19:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1714618332; x=1715223132; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nQflKhToqXQy5/HFwbUg/VVDegoBYmRvbf0vhBIdcqA=; b=pOdUIDTL6dzl+xkyRJbE/AVHxoa1hdsvKO7OC8as7Aa8CKgKVCTUmmApLriysl5K3+ xHxIWfn/5nMlf714eKFWzu0whaKxSHZBFstLThWTxCp28vtFPT6/a8u6L9j9BMQ0vdlJ OL4+cPe5yr65KS2sjRHSWwhL2vF6mNnn6wHZrz3jY9+bOWDTI6l0fA5C+zoFqS91GOoZ mPtaHL9CVRAQLwzEH56PmarjJ8xkFjxYdJJBX/mOVyMTf6mSrjApNDgh8oYRl4JgrjB5 EhAdOd5iv17kfFn0C3d4Me/SK8qxtjXTBrzNbjzl2tvejd8Nz0nDz/t3zrGUtEtEFsfn jgBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714618332; x=1715223132; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nQflKhToqXQy5/HFwbUg/VVDegoBYmRvbf0vhBIdcqA=; b=CSlZ9rkC+cG4GB5eQE8DmyWdGyITlrQ3WZNTVzxsvELrFyMqJpOwq9EIEJYSZ0sDjg jn18/k7n9FAp96JCktPwldiHsDjqANrBB4/+urOiYqlQjGtnb9f4tUbcxjGOH86ZDxOm fBTKqFnct6YbSjjy48ltsvaWfYX614AbROvbL9C42+F7RkoEt2uv0yd1p/RQVTGhsx4e Nhjsvuj/6z1AaJfOcavBaXmylS3gSoOpCXfDPthyJRMCr1qcIRlIXFCyu4FNdDRplLuL cTjdEE+VcEYyv3LlWxEeWq22zXhyeqB702xm/ZoRnjMwQR9vyrg6422Pe00pNDW8e71D cp1w== X-Gm-Message-State: AOJu0Yz7yGHXurVV0gK7E/s0rcHHvO8NaMEX1dd4fLDWGiVVsktIvdWd 2ghKreNeQs9c1wEaUWI8P4LiDGz46YEcJ3A8pBIO6/bJKU7AkF/UyHAhpR3I3EVJATcnyrDao4F Op8s= X-Google-Smtp-Source: AGHT+IHVkMECuK8mFa+jPU6/VQ3J440fOxAEHFmDpTHZEPXqDNHTT5V/fsPrXguZ0kYlxxLovwBBkA== X-Received: by 2002:a05:6a00:80a:b0:6ed:21d5:fc2c with SMTP id m10-20020a056a00080a00b006ed21d5fc2cmr5803322pfk.26.1714618332398; Wed, 01 May 2024 19:52:12 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id z19-20020aa78893000000b006ecfc3a8d6csm104818pfe.124.2024.05.01.19.52.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 19:52:11 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v11 2/9] net/tap: remove unused fields Date: Wed, 1 May 2024 19:49:21 -0700 Message-ID: <20240502025201.28322-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240502025201.28322-1-stephen@networkplumber.org> References: <20240130034925.44869-1-stephen@networkplumber.org> <20240502025201.28322-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver doesn't support these other hash types, and there is no reason to implement these in future. The rss_flows list was set but never used. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.h | 4 +--- drivers/net/tap/tap_flow.c | 1 - drivers/net/tap/tap_rss.h | 6 ------ 3 files changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.h b/drivers/net/tap/rte_eth_tap.h index dc8201020b..1bcf92ce80 100644 --- a/drivers/net/tap/rte_eth_tap.h +++ b/drivers/net/tap/rte_eth_tap.h @@ -77,14 +77,12 @@ struct pmd_internals { int ioctl_sock; /* socket for ioctl calls */ int nlsk_fd; /* Netlink socket fd */ int flow_isolate; /* 1 if flow isolation is enabled */ - int flower_support; /* 1 if kernel supports, else 0 */ - int flower_vlan_support; /* 1 if kernel supports, else 0 */ int rss_enabled; /* 1 if RSS is enabled, else 0 */ int persist; /* 1 if keep link up, else 0 */ /* implicit rules set when RSS is enabled */ int map_fd; /* BPF RSS map fd */ int bpf_fd[RTE_PMD_TAP_MAX_QUEUES];/* List of bpf fds per queue */ - LIST_HEAD(tap_rss_flows, rte_flow) rss_flows; + LIST_HEAD(tap_flows, rte_flow) flows; /* rte_flow rules */ /* implicit rte_flow rules set when a remote device is active */ LIST_HEAD(tap_implicit_flows, rte_flow) implicit_flows; diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c index a78fd50cd4..8fccd599f0 100644 --- a/drivers/net/tap/tap_flow.c +++ b/drivers/net/tap/tap_flow.c @@ -1958,7 +1958,6 @@ static int rss_enable(struct pmd_internals *pmd, errno, strerror(errno)); return err; } - LIST_INSERT_HEAD(&pmd->rss_flows, rss_flow, next); } pmd->rss_enabled = 1; diff --git a/drivers/net/tap/tap_rss.h b/drivers/net/tap/tap_rss.h index dff46a012f..8766ffc244 100644 --- a/drivers/net/tap/tap_rss.h +++ b/drivers/net/tap/tap_rss.h @@ -21,12 +21,6 @@ enum hash_field { HASH_FIELD_IPV4_L3_L4, /* IPv4 src/dst addr + L4 src/dst ports */ HASH_FIELD_IPV6_L3, /* IPv6 src/dst addr */ HASH_FIELD_IPV6_L3_L4, /* IPv6 src/dst addr + L4 src/dst ports */ - HASH_FIELD_L2_SRC, /* Ethernet src addr */ - HASH_FIELD_L2_DST, /* Ethernet dst addr */ - HASH_FIELD_L3_SRC, /* L3 src addr */ - HASH_FIELD_L3_DST, /* L3 dst addr */ - HASH_FIELD_L4_SRC, /* TCP/UDP src ports */ - HASH_FIELD_L4_DST, /* TCP/UDP dst ports */ }; struct rss_key {