From patchwork Tue Apr 30 12:08:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Mattias_R=C3=B6nnblom?= X-Patchwork-Id: 139734 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09FB443F54; Tue, 30 Apr 2024 14:18:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 082F1402C6; Tue, 30 Apr 2024 14:18:37 +0200 (CEST) Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2046.outbound.protection.outlook.com [40.107.249.46]) by mails.dpdk.org (Postfix) with ESMTP id 9D7DE402AA for ; Tue, 30 Apr 2024 14:18:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DE7Z3BeA6ZAW8lIbHh+cH56JW0LLZ5RpjfN/kFqvXbiBoAUIxhLpV1tVV5+GE+y/I13mcH8f95ChFa1qJHDO9Yj4QL2DMzCYXFMlnvQnMuDI9gP2Jkpqfsktmp8UvpZAewYVQYQFEG7qS+w6B97wC+lrn3qRYJwyudFi+PYLEZFH+IKZCkT91FZGCijGs8cBDJtJIO2OTdgVRWJVN+7WiSCir3jxzcK1zWwsTlykz6s78uNDG6L0BhLGIwuP705o2xvj2WN2ZxZQzeUQ84topsN9RUyZZEIZNjWFjYxxLwSQmAvlNr+eNN3sfAWyoyD2zV+A55LwTEqLrTc3vzDOPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AvPWbCvgzyOJyxa/j0ge/ILRgogIdQ9NHvtGx46yEDw=; b=XYXnaM0gd32ROnKt02XBbNvPWZj2sKyOGoBi/nyn48Bs/kbNNloxP9j4YH4xfAwchT9ax4QrliA+2SCsDfT9EOoZMTRXUzpJ25v7/UixThMTko1ak/7zlSg96rlcO3F8i9obZk957t9G8ZGmlxS1GbpXbHK375NqAVGJ3pNoyDDXh4PxktGC3K230dCJf69Nw2bSD5KHrKmdldCHDpijX3yt1YBAbPzeLtztKNFx800DA2mpk5EJir1lVtvTTJfB26ZAZ6NrP4Idi3KRciO6NsJymubmRrbsl9n2x7uSwhRIMPBm4wwNNDfPcWPsfkJzs1RWXNQiDQbuR18LyZv3IA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AvPWbCvgzyOJyxa/j0ge/ILRgogIdQ9NHvtGx46yEDw=; b=GhxTzfR57OMLb6lpoLvN47In+NBy0YohgLQCEj5xJCCbTyQnlHPWD6KfhmldHhE0rdFiYDXooX2ZRq7qf8st77Ff9HayVeqg1B9VoYn5Nx3djbHGPdUhHISKTmgvrfNz7SqwSpBXY+5fKHlkHTr/WHaQDkr5epSHzQu3PL1FSfLHtKe49FkmmRJZiCr/0HWqQ5mq8JOgw2EiWmNVGiwFixua4ocvH8vU/4FJjNEmGHB9vhv7cEYVX+IId0mA0Jrn+ZLqEu9A8nSFZiQ4L7fvgXaGZWhXmIWAleHBylsY00jLtHHChvdmCdYG8hEvLNvMVvzoCDCcou+1NfvSLqdmdQ== Received: from AS9PR06CA0077.eurprd06.prod.outlook.com (2603:10a6:20b:464::24) by PA4PR07MB7248.eurprd07.prod.outlook.com (2603:10a6:102:d7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.36; Tue, 30 Apr 2024 12:18:32 +0000 Received: from AMS0EPF00000190.eurprd05.prod.outlook.com (2603:10a6:20b:464:cafe::1) by AS9PR06CA0077.outlook.office365.com (2603:10a6:20b:464::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34 via Frontend Transport; Tue, 30 Apr 2024 12:18:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by AMS0EPF00000190.mail.protection.outlook.com (10.167.16.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.19 via Frontend Transport; Tue, 30 Apr 2024 12:18:32 +0000 Received: from seliicinfr00049.seli.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.69) with Microsoft SMTP Server id 15.2.1544.9; Tue, 30 Apr 2024 14:18:32 +0200 Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100]) by seliicinfr00049.seli.gic.ericsson.se (Postfix) with ESMTP id 2DBDA380061; Tue, 30 Apr 2024 14:18:32 +0200 (CEST) From: =?utf-8?q?Mattias_R=C3=B6nnblom?= To: CC: , Heng Wang , "Stephen Hemminger" , Tyler Retzlaff , =?utf-8?q?Morten_Br=C3=B8rup?= , =?utf-8?q?Mattia?= =?utf-8?q?s_R=C3=B6nnblom?= Subject: [RFC v5 3/6] eal: add exactly-once bit access functions Date: Tue, 30 Apr 2024 14:08:07 +0200 Message-ID: <20240430120810.108928-4-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240430120810.108928-1-mattias.ronnblom@ericsson.com> References: <20240430095523.108688-2-mattias.ronnblom@ericsson.com> <20240430120810.108928-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS0EPF00000190:EE_|PA4PR07MB7248:EE_ X-MS-Office365-Filtering-Correlation-Id: 649f8bb2-bf90-4098-7ace-08dc690fa704 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|1800799015|82310400014|376005|36860700004; X-Microsoft-Antispam-Message-Info: =?utf-8?q?SbWkFmMW9lCjpnxXZJlb1q2c9EkbsnF?= =?utf-8?q?5mgPd8ELPQw1rFaVt+g91VvWoKjekJvl7nDHSmaTR6RXSEUdOwved5N/3obBQkj9K?= =?utf-8?q?VMJxyZ1O8ELD2eTvI7kAOaGmdXLgcGb+dHDOGdNaHTVXKz6c0dupM34vjxovaVGMB?= =?utf-8?q?3JxCBc8+razn2Vq2T0OdV4NRCYusX3c17qdMjKME58rk/Z5RXDyqdsXew50l4cI4m?= =?utf-8?q?akzu/kDTsa6I+EqrUOQKVXJmDpe864xOW0JOFrzvoMhU/D9fAiaAKztZCTCbH0dwi?= =?utf-8?q?7y5TSTrS/qyZhA7V+2UXgxIem7nV9HW61Zo+0Be0GSfu4TGsXNTfTa9nTDRjWujv+?= =?utf-8?q?wLNmc6fncg7WHvJqbJ3ZmbWndfODVw/FG87O+qI+sttQTySe1LCl6MdszhMaUwj7J?= =?utf-8?q?Ufkp4LI+Q4WYVIVuSx/9N+RlxMw65nQo64VJY8FbipKcOWhfSakIqOUvbXf9Lvi/P?= =?utf-8?q?CEVAQUAxn4uJWlQ/z+uUM9UyXlGGbPFAzXOZSEcRbGcr8/IDoR6FVbZFAX4XmKLtl?= =?utf-8?q?95rEPwWx5Ldev+SXV5sUhgKx5gDWKmTl3CGbcvg/ws6KIO5rEyQlqsjzMKwDGDFcL?= =?utf-8?q?Uz/NQTs2ma9F/iox/GtPyWUrfUh4FC7iV75+2JAZ2uHf9armeFaFYPAhipBpd+5jT?= =?utf-8?q?HNUgbHyEDNwSoj7XVjnkNdIgYx4oje4hEqVEQ/+EfWgtRKcMIqDumtam5rWh3QFd7?= =?utf-8?q?dhEgiu4jy1fv9b7rwbmAtvCW8hET9YMdlgBmgjxciKSG+LBkCTx+Q+v1ydlBHgzwk?= =?utf-8?q?QbBC8rPojahx2K8DvD4cilgI/2xkuM/qFdhakpJ01VmXQiqIkQhKMquK9NLOrbWqd?= =?utf-8?q?kdWe0zNtEsIFVHPvYh68BlOVdciQa42q24Xwz7OP2rWMDX1bzaBAy53pcILpL3TQm?= =?utf-8?q?6Eaai3vrYIF2sjwAp66z2FMMI9+3NLOoyoNwdmxhoEQHVoMGDJ5LW3l2B40HuFaKC?= =?utf-8?q?WG4cN9XDEZrv3ufiAc8Yj3DDaSQUF3FRGlzAby/uNPT3E97B9MA0YXHqpxq1EUnfk?= =?utf-8?q?V5rmAtybII39bFMjlzt12ghv6bkCh+19lrNbJnX/GnAn57/MC8O21oSlGFqz8Y0z+?= =?utf-8?q?hbqHjVyCl8K8L+6swLiKoJMFGgY9e1X6tFixt0WbH6Z/vhGbGOqQkwZPSeVpGkgIj?= =?utf-8?q?hlCpiZO8BlfinSgkF7QVVXoHFXROiIzBjg2k7I01s86Ie485CDiXs8ew9zCIeAfqD?= =?utf-8?q?RKRvKLKMPqxYYfJ4dDIvIL2dnhzCYLAnBtI9QViUK2UXXOtVlJynocybiIpYeivSD?= =?utf-8?q?Sn7ULQ2OnPZy5N504JR0kn++jPVs5pRNCtjFF6eEgYfrvz2zO1Nm8e9o0vl0p/tBa?= =?utf-8?q?oXh/ZCA2QYKC?= X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230031)(1800799015)(82310400014)(376005)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2024 12:18:32.6813 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 649f8bb2-bf90-4098-7ace-08dc690fa704 X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF00000190.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR07MB7248 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add bit test/set/clear/assign functions which prevents certain compiler optimizations and guarantees that program-level memory loads and/or stores will actually occur. These functions are useful when interacting with memory-mapped hardware devices. The "once" family of functions does not promise atomicity and provides no memory ordering guarantees beyond the C11 relaxed memory model. RFC v3: * Work around lack of C++ support for _Generic (Tyler Retzlaff). Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff --- lib/eal/include/rte_bitops.h | 195 +++++++++++++++++++++++++++++++++++ 1 file changed, 195 insertions(+) diff --git a/lib/eal/include/rte_bitops.h b/lib/eal/include/rte_bitops.h index 9d426f1602..f77bd83e97 100644 --- a/lib/eal/include/rte_bitops.h +++ b/lib/eal/include/rte_bitops.h @@ -224,6 +224,177 @@ extern "C" { uint32_t *: __rte_bit_flip32, \ uint64_t *: __rte_bit_flip64)(addr, nr) +/** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Generic selection macro to test exactly once the value of a bit in + * a 32-bit or 64-bit word. The type of operation depends on the type + * of the @c addr parameter. + * + * This function is guaranteed to result in exactly one memory load + * (e.g., it may not be eliminate or merged by the compiler). + * + * \code{.c} + * rte_bit_once_set(addr, 17); + * if (rte_bit_once_test(addr, 17)) { + * ... + * } + * \endcode + * + * In the above example, rte_bit_once_set() may not be removed by + * the compiler, which would be allowed in case rte_bit_set() and + * rte_bit_test() was used. + * + * \code{.c} + * while (rte_bit_once_test(addr, 17); + * ; + * \endcode + * + * In case rte_bit_test(addr, 17) was used instead, the resulting + * object code could (and in many cases would be) replaced with + * the equivalent to + * \code{.c} + * if (rte_bit_test(addr, 17)) { + * for (;;) // spin forever + * ; + * } + * \endcode + * + * rte_bit_once_test() does not give any guarantees in regards to + * memory ordering or atomicity. + * + * The regular bit set operations (e.g., rte_bit_test()) should be + * preferred over the "once" family of operations (e.g., + * rte_bit_once_test()) if possible, since the latter may prevent + * optimizations crucial for run-time performance. + * + * @param addr + * A pointer to the word to query. + * @param nr + * The index of the bit. + * @return + * Returns true if the bit is set, and false otherwise. + */ + +#define rte_bit_once_test(addr, nr) \ + _Generic((addr), \ + uint32_t *: __rte_bit_once_test32, \ + uint64_t *: __rte_bit_once_test64)(addr, nr) + +/** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Set bit in word exactly once. + * + * Set bit specified by @c nr in the word pointed to by @c addr to '1' + * exactly once. + * + * This function is guaranteed to result in exactly one memory load + * and exactly one memory store, *or* an atomic bit set operation. + * + * See rte_bit_test_once32() for more information and uses cases for + * the "once" class of functions. + * + * This macro does not give any guarantees in regards to memory + * ordering or atomicity. + * + * @param addr + * A pointer to the word to modify. + * @param nr + * The index of the bit. + */ + +#define rte_bit_once_set(addr, nr) \ + _Generic((addr), \ + uint32_t *: __rte_bit_once_set32, \ + uint64_t *: __rte_bit_once_set64)(addr, nr) + +/** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Clear bit in word exactly once. + * + * Set bit specified by @c nr in the word pointed to by @c addr to '0' + * exactly once. + * + * This function is guaranteed to result in exactly one memory load + * and exactly one memory store, *or* an atomic bit clear operation. + * + * See rte_bit_test_once32() for more information and uses cases for + * the "once" class of functions. + * + * This macro does not give any guarantees in regards to memory + * ordering or atomicity. + * + * @param addr + * A pointer to the word to modify. + * @param nr + * The index of the bit. + */ +#define rte_bit_once_clear(addr, nr) \ + _Generic((addr), \ + uint32_t *: __rte_bit_once_clear32, \ + uint64_t *: __rte_bit_once_clear64)(addr, nr) + +/** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Assign a value to bit in a word exactly once. + * + * Set bit specified by @c nr in the word pointed to by @c addr to the + * value indicated by @c value exactly once. + * + * This function is guaranteed to result in exactly one memory load + * and exactly one memory store, *or* an atomic bit clear operation. + * + * This function does not give any guarantees in regards to memory + * ordering or atomicity. + * + * @param addr + * A pointer to the word to modify. + * @param nr + * The index of the bit. + * @param value + * The new value of the bit - true for '1', or false for '0'. + */ +#define rte_bit_once_assign(addr, nr, value) \ + _Generic((addr), \ + uint32_t *: __rte_bit_once_assign32, \ + uint64_t *: __rte_bit_once_assign64)(addr, nr, value) + +/** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Flip bit in word, reading and writing exactly once. + * + * Change the value of a bit to '0' if '1' or '1' if '0' in a 32-bit + * or 64-bit word. The type of operation depends on the type of the @c + * addr parameter. + * + * This function is guaranteed to result in exactly one memory load + * and exactly one memory store, *or* an atomic bit flip operation. + * + * See rte_bit_test_once32() for more information and uses cases for + * the "once" class of functions. + * + * This macro does not give any guarantees in regards to memory + * ordering or atomicity. + * + * @param addr + * A pointer to the word to modify. + * @param nr + * The index of the bit. + */ +#define rte_bit_once_flip(addr, nr) \ + _Generic((addr), \ + uint32_t *: __rte_bit_once_flip32, \ + uint64_t *: __rte_bit_once_flip64)(addr, nr) + #define __RTE_GEN_BIT_TEST(family, fun, qualifier, size) \ __rte_experimental \ static inline bool \ @@ -296,6 +467,18 @@ __RTE_GEN_BIT_CLEAR(, clear,, 64) __RTE_GEN_BIT_ASSIGN(, assign,, 64) __RTE_GEN_BIT_FLIP(, flip,, 64) +__RTE_GEN_BIT_TEST(once_, test, volatile, 32) +__RTE_GEN_BIT_SET(once_, set, volatile, 32) +__RTE_GEN_BIT_CLEAR(once_, clear, volatile, 32) +__RTE_GEN_BIT_ASSIGN(once_, assign, volatile, 32) +__RTE_GEN_BIT_FLIP(once_, flip, volatile, 32) + +__RTE_GEN_BIT_TEST(once_, test, volatile, 64) +__RTE_GEN_BIT_SET(once_, set, volatile, 64) +__RTE_GEN_BIT_CLEAR(once_, clear, volatile, 64) +__RTE_GEN_BIT_ASSIGN(once_, assign, volatile, 64) +__RTE_GEN_BIT_FLIP(once_, flip, volatile, 64) + /*------------------------ 32-bit relaxed operations ------------------------*/ /** @@ -991,6 +1174,12 @@ rte_log2_u64(uint64_t v) #undef rte_bit_assign #undef rte_bit_flip +#undef rte_bit_once_test +#undef rte_bit_once_set +#undef rte_bit_once_clear +#undef rte_bit_once_assign +#undef rte_bit_once_flip + #define __RTE_BIT_OVERLOAD_SZ_2(fun, qualifier, size, arg1_type, arg1_name) \ static inline void \ rte_bit_ ## fun(qualifier uint ## size ## _t *addr, \ @@ -1040,6 +1229,12 @@ __RTE_BIT_OVERLOAD_2(clear,, unsigned int, nr) __RTE_BIT_OVERLOAD_3(assign,, unsigned int, nr, bool, value) __RTE_BIT_OVERLOAD_2(flip,, unsigned int, nr) +__RTE_BIT_OVERLOAD_2R(once_test, const volatile, bool, unsigned int, nr) +__RTE_BIT_OVERLOAD_2(once_set, volatile, unsigned int, nr) +__RTE_BIT_OVERLOAD_2(once_clear, volatile, unsigned int, nr) +__RTE_BIT_OVERLOAD_3(once_assign, volatile, unsigned int, nr, bool, value) +__RTE_BIT_OVERLOAD_2(once_flip, volatile, unsigned int, nr) + #endif #endif /* _RTE_BITOPS_H_ */