[v2] config/arm: add Ampere AmpereOneX platform

Message ID 20240411092332.237904-1-jiangyutang@os.amperecomputing.com (mailing list archive)
State Superseded
Delegated to: Thomas Monjalon
Headers
Series [v2] config/arm: add Ampere AmpereOneX platform |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS

Commit Message

Yutang Jiang April 11, 2024, 9:23 a.m. UTC
  Signed-off-by: Yutang Jiang <jiangyutang@os.amperecomputing.com>
---
 config/arm/arm64_ampereonex_linux_gcc | 16 ++++++++++++++++
 config/arm/meson.build                | 19 +++++++++++++++++++
 2 files changed, 35 insertions(+)
 create mode 100644 config/arm/arm64_ampereonex_linux_gcc
  

Comments

Thomas Monjalon June 19, 2024, 7:43 p.m. UTC | #1
11/04/2024 11:23, Yutang Jiang:
> Signed-off-by: Yutang Jiang <jiangyutang@os.amperecomputing.com>

Would be good to have a small description of the platform in the commit log.

And it is still waiting for review from Arm.
  
Ruifeng Wang June 20, 2024, 8:40 a.m. UTC | #2
On 2024/4/11 5:23 PM, Yutang Jiang wrote:
> Signed-off-by: Yutang Jiang <jiangyutang@os.amperecomputing.com>
> ---
>   config/arm/arm64_ampereonex_linux_gcc | 16 ++++++++++++++++
>   config/arm/meson.build                | 19 +++++++++++++++++++
>   2 files changed, 35 insertions(+)
>   create mode 100644 config/arm/arm64_ampereonex_linux_gcc
> 
> diff --git a/config/arm/arm64_ampereonex_linux_gcc b/config/arm/arm64_ampereonex_linux_gcc
> new file mode 100644
> index 0000000000..c5c334fdb7
> --- /dev/null
> +++ b/config/arm/arm64_ampereonex_linux_gcc
> @@ -0,0 +1,16 @@
> +[binaries]
> +c = ['ccache', 'aarch64-linux-gnu-gcc']
> +cpp = ['ccache', 'aarch64-linux-gnu-g++']
> +ar = 'aarch64-linux-gnu-gcc-ar'
> +strip = 'aarch64-linux-gnu-strip'
> +pkgconfig = 'aarch64-linux-gnu-pkg-config'

This variable is changed to remove some meson warning [1]. Please update 
accordingly.

With suggested change:
Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>

PS: you can take received ack from the previous version.

[1] 
https://patches.dpdk.org/project/dpdk/patch/20240617151458.1005103-1-david.marchand@redhat.com/

Thanks.
> +pcap-config = ''
> +
> +[host_machine]
<snip>
  
Yutang Jiang June 27, 2024, 2:53 a.m. UTC | #3
Thank you, Ruifeng.
I noticed that variable patch, and have updated and submitted a new v3 patch.

> -----Original Message-----
> From: Ruifeng Wang <Ruifeng.Wang@arm.com>
> Sent: Thursday, June 20, 2024 4:41 PM
> To: Yutang Jiang OS <jiangyutang@os.amperecomputing.com>;
> dev@dpdk.org
> Cc: Open Source Submission <patches@amperecomputing.com>; Yutang Jiang
> <yutang.jiang@amperecomputing.com>; nd@arm.com;
> juraj.linkes@pantheon.tech; wathsala.vithanage@arm.com
> Subject: Re: [PATCH v2] config/arm: add Ampere AmpereOneX platform
> 
> [EXTERNAL EMAIL NOTICE: This email originated from an external sender.
> Please be mindful of safe email handling and proprietary information
> protection practices.]
> 
> 
> On 2024/4/11 5:23 PM, Yutang Jiang wrote:
> > Signed-off-by: Yutang Jiang <jiangyutang@os.amperecomputing.com>
> > ---
> >   config/arm/arm64_ampereonex_linux_gcc | 16 ++++++++++++++++
> >   config/arm/meson.build                | 19 +++++++++++++++++++
> >   2 files changed, 35 insertions(+)
> >   create mode 100644 config/arm/arm64_ampereonex_linux_gcc
> >
> > diff --git a/config/arm/arm64_ampereonex_linux_gcc
> > b/config/arm/arm64_ampereonex_linux_gcc
> > new file mode 100644
> > index 0000000000..c5c334fdb7
> > --- /dev/null
> > +++ b/config/arm/arm64_ampereonex_linux_gcc
> > @@ -0,0 +1,16 @@
> > +[binaries]
> > +c = ['ccache', 'aarch64-linux-gnu-gcc'] cpp = ['ccache',
> > +'aarch64-linux-gnu-g++'] ar = 'aarch64-linux-gnu-gcc-ar'
> > +strip = 'aarch64-linux-gnu-strip'
> > +pkgconfig = 'aarch64-linux-gnu-pkg-config'
> 
> This variable is changed to remove some meson warning [1]. Please update
> accordingly.
> 
> With suggested change:
> Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>
> 
> PS: you can take received ack from the previous version.
> 
> [1]
> https://patches.dpdk.org/project/dpdk/patch/20240617151458.1005103-
> 1-david.marchand@redhat.com/
> 
> Thanks.
> > +pcap-config = ''
> > +
> > +[host_machine]
> <snip>
  
Yutang Jiang June 27, 2024, 3:03 a.m. UTC | #4
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday, June 20, 2024 3:44 AM
> To: ruifeng.wang@arm.com; wathsala.vithanage@arm.com;
> honnappa.nagarahalli@arm.com
> Cc: dev@dpdk.org; Open Source Submission
> <patches@amperecomputing.com>; Yutang Jiang
> <yutang.jiang@amperecomputing.com>; Yutang Jiang OS
> <jiangyutang@os.amperecomputing.com>; nd@arm.com;
> juraj.linkes@pantheon.tech; Yutang Jiang OS
> <jiangyutang@os.amperecomputing.com>
> Subject: Re: [PATCH v2] config/arm: add Ampere AmpereOneX platform
> 
> [EXTERNAL EMAIL NOTICE: This email originated from an external sender.
> Please be mindful of safe email handling and proprietary information
> protection practices.]
> 
> 
> 11/04/2024 11:23, Yutang Jiang:
> > Signed-off-by: Yutang Jiang <jiangyutang@os.amperecomputing.com>
> 
> Would be good to have a small description of the platform in the commit log.
[Yutang Jiang
  

Patch

diff --git a/config/arm/arm64_ampereonex_linux_gcc b/config/arm/arm64_ampereonex_linux_gcc
new file mode 100644
index 0000000000..c5c334fdb7
--- /dev/null
+++ b/config/arm/arm64_ampereonex_linux_gcc
@@ -0,0 +1,16 @@ 
+[binaries]
+c = ['ccache', 'aarch64-linux-gnu-gcc']
+cpp = ['ccache', 'aarch64-linux-gnu-g++']
+ar = 'aarch64-linux-gnu-gcc-ar'
+strip = 'aarch64-linux-gnu-strip'
+pkgconfig = 'aarch64-linux-gnu-pkg-config'
+pcap-config = ''
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv8.6-a'
+endian = 'little'
+
+[properties]
+platform = 'ampereonex'
diff --git a/config/arm/meson.build b/config/arm/meson.build
index a45aa9e466..40d63b5e4b 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -210,6 +210,16 @@  implementer_ampere = {
                 ['RTE_MAX_LCORE', 320],
                 ['RTE_MAX_NUMA_NODES', 8]
             ]
+        },
+        '0xac4': {
+            'march': 'armv8.6-a',
+            'march_features': ['crc', 'crypto'],
+            'mcpu': 'ampere1a',
+            'flags': [
+                ['RTE_MACHINE', '"AmpereOneX"'],
+                ['RTE_MAX_LCORE', 384],
+                ['RTE_MAX_NUMA_NODES', 8]
+            ]
         }
     }
 }
@@ -371,6 +381,13 @@  soc_ampereone = {
     'numa': true
 }
 
+soc_ampereonex = {
+    'description': 'Ampere AmpereOneX',
+    'implementer': '0xc0',
+    'part_number': '0xac4',
+    'numa': true
+}
+
 soc_armada = {
     'description': 'Marvell ARMADA',
     'implementer': '0x41',
@@ -621,6 +638,7 @@  generic:         Generic un-optimized build for armv8 aarch64 execution mode.
 generic_aarch32: Generic un-optimized build for armv8 aarch32 execution mode.
 altra:           Ampere Altra/AltraMax
 ampereone:       Ampere AmpereOne
+ampereonex:      Ampere AmpereOneX
 armada:          Marvell ARMADA
 bluefield:       NVIDIA BlueField
 bluefield3:      NVIDIA BlueField-3
@@ -658,6 +676,7 @@  socs = {
     'generic_aarch32': soc_generic_aarch32,
     'altra': soc_altra,
     'ampereone': soc_ampereone,
+    'ampereonex': soc_ampereonex,
     'armada': soc_armada,
     'bluefield': soc_bluefield,
     'bluefield3': soc_bluefield3,