From patchwork Tue Apr 9 03:40:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 139201 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8FAFF43DD9; Tue, 9 Apr 2024 05:42:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC44C40684; Tue, 9 Apr 2024 05:42:45 +0200 (CEST) Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) by mails.dpdk.org (Postfix) with ESMTP id 5B14F402B9 for ; Tue, 9 Apr 2024 05:42:41 +0200 (CEST) Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-5aa2bd6f651so1492708eaf.0 for ; Mon, 08 Apr 2024 20:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1712634160; x=1713238960; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nQflKhToqXQy5/HFwbUg/VVDegoBYmRvbf0vhBIdcqA=; b=0G2JLpP6vc4ogUZzEszs3j8rzPrXxxkBAfI6ySUm+m/zo8ktNABg2B99uDFuFi6WQA D0M9CJ2b3upP1OMX/TRkWAzr/ajeDvf3XmON64kZl6Xq9tQ0C/l5M0Bk3o6ynKg3cGX4 ViTJ68h7wJHVHaJZnpHOiwXVfGVE82e0IQEudOndKgDARw6XP+t0im023TxkSkYKMySD FC0cBL8lU74JyknT9BEIC3Qwb01XXhzPQTCP83HdU2jQAnQqhl63hgqIrRGMSUS1NGYM HGvlU/jm46uFGbJCMfYWgF8mNH40TBVnF5mEi5yYD2rYdDiT816FFxOoAmpGaa2/Gkyb JFGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712634160; x=1713238960; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nQflKhToqXQy5/HFwbUg/VVDegoBYmRvbf0vhBIdcqA=; b=iQ2L3j9rMYt514RcFCJr0+JVlhRQH/Qzy42Eb7IekEv7X66J1Tp65ctvGUJ8sSfZ9s W2sBHbRnaDNfnlcKnntF9GvLUqUKpW7bb3p/35LbG91+21oQFx9Yi30Md/wvNpoMyfnK JTZe6LTFi+CpGDrkrWKRKps4uKJxUzV0cGX9ym8D+rvTW0TKakhqn+yKydA6F4/QIif6 B6vxuoemDbhpn+7i1giEBs/37erDv+ucKDaEEDlm0Pf9rwrwjvoZ4bNahv+p9iRE4cHU cIbHzmAJBM9fERl2eNk73KfKcLOkvrXf0gDcHlrK3qy2hIFyqSbLirAi6M690BZVStaY e/wg== X-Gm-Message-State: AOJu0Yxw8iPvqs1iPlO3PWRPrVCTSNvPZPm29HymQL7vIs5I8vNlQzWN NAUlcDWmXGa/CEGgPAW5EKL2vi6rvTXZeRbgtFu2eKI92jcF7ZIs+4ID5gstr33kRpFr6WtG4rU dZ9M= X-Google-Smtp-Source: AGHT+IH+9mJtB5Le1pGkRESrZR2E6Rp96UeQOzl/xhykF1KK5Fa7nlC1oc0VyBw1q/L3q5mEbBEztQ== X-Received: by 2002:a05:6358:7c16:b0:183:90a2:f4ce with SMTP id p22-20020a0563587c1600b0018390a2f4cemr10661261rwf.0.1712634160647; Mon, 08 Apr 2024 20:42:40 -0700 (PDT) Received: from hermes.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id gm24-20020a17090b101800b0029de90f4d44sm9238197pjb.9.2024.04.08.20.42.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 20:42:40 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v8 2/8] net/tap: remove unused fields Date: Mon, 8 Apr 2024 20:40:31 -0700 Message-ID: <20240409034237.433270-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240409034237.433270-1-stephen@networkplumber.org> References: <20240130034925.44869-1-stephen@networkplumber.org> <20240409034237.433270-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver doesn't support these other hash types, and there is no reason to implement these in future. The rss_flows list was set but never used. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.h | 4 +--- drivers/net/tap/tap_flow.c | 1 - drivers/net/tap/tap_rss.h | 6 ------ 3 files changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.h b/drivers/net/tap/rte_eth_tap.h index dc8201020b..1bcf92ce80 100644 --- a/drivers/net/tap/rte_eth_tap.h +++ b/drivers/net/tap/rte_eth_tap.h @@ -77,14 +77,12 @@ struct pmd_internals { int ioctl_sock; /* socket for ioctl calls */ int nlsk_fd; /* Netlink socket fd */ int flow_isolate; /* 1 if flow isolation is enabled */ - int flower_support; /* 1 if kernel supports, else 0 */ - int flower_vlan_support; /* 1 if kernel supports, else 0 */ int rss_enabled; /* 1 if RSS is enabled, else 0 */ int persist; /* 1 if keep link up, else 0 */ /* implicit rules set when RSS is enabled */ int map_fd; /* BPF RSS map fd */ int bpf_fd[RTE_PMD_TAP_MAX_QUEUES];/* List of bpf fds per queue */ - LIST_HEAD(tap_rss_flows, rte_flow) rss_flows; + LIST_HEAD(tap_flows, rte_flow) flows; /* rte_flow rules */ /* implicit rte_flow rules set when a remote device is active */ LIST_HEAD(tap_implicit_flows, rte_flow) implicit_flows; diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c index a78fd50cd4..8fccd599f0 100644 --- a/drivers/net/tap/tap_flow.c +++ b/drivers/net/tap/tap_flow.c @@ -1958,7 +1958,6 @@ static int rss_enable(struct pmd_internals *pmd, errno, strerror(errno)); return err; } - LIST_INSERT_HEAD(&pmd->rss_flows, rss_flow, next); } pmd->rss_enabled = 1; diff --git a/drivers/net/tap/tap_rss.h b/drivers/net/tap/tap_rss.h index dff46a012f..8766ffc244 100644 --- a/drivers/net/tap/tap_rss.h +++ b/drivers/net/tap/tap_rss.h @@ -21,12 +21,6 @@ enum hash_field { HASH_FIELD_IPV4_L3_L4, /* IPv4 src/dst addr + L4 src/dst ports */ HASH_FIELD_IPV6_L3, /* IPv6 src/dst addr */ HASH_FIELD_IPV6_L3_L4, /* IPv6 src/dst addr + L4 src/dst ports */ - HASH_FIELD_L2_SRC, /* Ethernet src addr */ - HASH_FIELD_L2_DST, /* Ethernet dst addr */ - HASH_FIELD_L3_SRC, /* L3 src addr */ - HASH_FIELD_L3_DST, /* L3 dst addr */ - HASH_FIELD_L4_SRC, /* TCP/UDP src ports */ - HASH_FIELD_L4_DST, /* TCP/UDP dst ports */ }; struct rss_key {