From patchwork Mon Apr 8 21:18:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 139192 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6113943DD2; Mon, 8 Apr 2024 23:24:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 767A84067D; Mon, 8 Apr 2024 23:24:46 +0200 (CEST) Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) by mails.dpdk.org (Postfix) with ESMTP id 3DF0D40633 for ; Mon, 8 Apr 2024 23:24:44 +0200 (CEST) Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-22edf22ab08so2117933fac.2 for ; Mon, 08 Apr 2024 14:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1712611483; x=1713216283; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nQflKhToqXQy5/HFwbUg/VVDegoBYmRvbf0vhBIdcqA=; b=yd5FnNWXS2DIV2/qVEz0QlNth4nAh7gp8N0rxcG7gvzU4X9aqSN0uL7bylFBoeZeyQ EpOpntigxsdFPrbP9/y45Vg9cqDKLe1FRm11UyA8rWGoqoMlE9Cl5DL3thJSCsUMhecg mzp3OONOoNyhud5jrV7JTyWNcyIo5Ll7KyT3GlO0gASTrFdh6DRyOdXPdA9HMMgLiJVV tpaHIuAve5Keb0cgkSGO8rm4s9thKrzZz1coUP9vywl7z/lYLdy/b7ucfDDbtVRr03wA c5B7knS1iO/WhaRg06wOukij0sG9KwXj4sRrgDMzMK+0dVv68VGHepj6tqeONPX5tHNR UFLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712611483; x=1713216283; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nQflKhToqXQy5/HFwbUg/VVDegoBYmRvbf0vhBIdcqA=; b=vrWTbzwnNQFTZPiUKBtNJUba0wiQ+uS35E8jmIMQ3LUeT38u6LXlYqLdVw0PsY7e45 I2m6/hT3Cbx867zjfIyflKq+3r1EJhwEC/tS/JNZO/6eMBf8R94uIYE7NYzYI9aLg3Qd npmsPQvQZv/4G7ZKi7F6+houSFR+lv83TJfvwifcoER7pZdWP0/SsligB1ItiQ20xm6L aDk2oJvm0nIujWlZC3KGe6zXoWN4D0YwZiV+7QAh2SztZDdYTn67ldUlM1ggpVtfQlXS wROSIik5nYEisYpl0olwOvWqaiT2ZXHhm5aUAdn+U2IEAgHCQZgn3Ggl0y/znhTBdDrU juLw== X-Gm-Message-State: AOJu0YzjwvpCiZNNIxKyD5AkJSpisaCuEWnKgYuBNn813jdK2Y71dCTL vUKmdHiKd4JktXmTx/dAgawX0U3f9ijYth2j8qL09PMQ+iiREqDkWFcLe1rqyNDYXn3TqOW2VMM tLhY= X-Google-Smtp-Source: AGHT+IENwBknIfqVraW6rG0Fh7ckbz/LsPsRFIFwWErdMoYjT8AloTqkjjEbWHizUheBFaiGiRb/bA== X-Received: by 2002:a05:6870:238e:b0:22e:c787:5fa2 with SMTP id e14-20020a056870238e00b0022ec7875fa2mr10838330oap.58.1712611483615; Mon, 08 Apr 2024 14:24:43 -0700 (PDT) Received: from hermes.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id f16-20020a633810000000b005e43cce33f8sm6924725pga.88.2024.04.08.14.24.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 14:24:43 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v7 2/8] net/tap: remove unused fields Date: Mon, 8 Apr 2024 14:18:33 -0700 Message-ID: <20240408212438.414099-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240408212438.414099-1-stephen@networkplumber.org> References: <20240130034925.44869-1-stephen@networkplumber.org> <20240408212438.414099-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver doesn't support these other hash types, and there is no reason to implement these in future. The rss_flows list was set but never used. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.h | 4 +--- drivers/net/tap/tap_flow.c | 1 - drivers/net/tap/tap_rss.h | 6 ------ 3 files changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.h b/drivers/net/tap/rte_eth_tap.h index dc8201020b..1bcf92ce80 100644 --- a/drivers/net/tap/rte_eth_tap.h +++ b/drivers/net/tap/rte_eth_tap.h @@ -77,14 +77,12 @@ struct pmd_internals { int ioctl_sock; /* socket for ioctl calls */ int nlsk_fd; /* Netlink socket fd */ int flow_isolate; /* 1 if flow isolation is enabled */ - int flower_support; /* 1 if kernel supports, else 0 */ - int flower_vlan_support; /* 1 if kernel supports, else 0 */ int rss_enabled; /* 1 if RSS is enabled, else 0 */ int persist; /* 1 if keep link up, else 0 */ /* implicit rules set when RSS is enabled */ int map_fd; /* BPF RSS map fd */ int bpf_fd[RTE_PMD_TAP_MAX_QUEUES];/* List of bpf fds per queue */ - LIST_HEAD(tap_rss_flows, rte_flow) rss_flows; + LIST_HEAD(tap_flows, rte_flow) flows; /* rte_flow rules */ /* implicit rte_flow rules set when a remote device is active */ LIST_HEAD(tap_implicit_flows, rte_flow) implicit_flows; diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c index a78fd50cd4..8fccd599f0 100644 --- a/drivers/net/tap/tap_flow.c +++ b/drivers/net/tap/tap_flow.c @@ -1958,7 +1958,6 @@ static int rss_enable(struct pmd_internals *pmd, errno, strerror(errno)); return err; } - LIST_INSERT_HEAD(&pmd->rss_flows, rss_flow, next); } pmd->rss_enabled = 1; diff --git a/drivers/net/tap/tap_rss.h b/drivers/net/tap/tap_rss.h index dff46a012f..8766ffc244 100644 --- a/drivers/net/tap/tap_rss.h +++ b/drivers/net/tap/tap_rss.h @@ -21,12 +21,6 @@ enum hash_field { HASH_FIELD_IPV4_L3_L4, /* IPv4 src/dst addr + L4 src/dst ports */ HASH_FIELD_IPV6_L3, /* IPv6 src/dst addr */ HASH_FIELD_IPV6_L3_L4, /* IPv6 src/dst addr + L4 src/dst ports */ - HASH_FIELD_L2_SRC, /* Ethernet src addr */ - HASH_FIELD_L2_DST, /* Ethernet dst addr */ - HASH_FIELD_L3_SRC, /* L3 src addr */ - HASH_FIELD_L3_DST, /* L3 dst addr */ - HASH_FIELD_L4_SRC, /* TCP/UDP src ports */ - HASH_FIELD_L4_DST, /* TCP/UDP dst ports */ }; struct rss_key {