From patchwork Mon Apr 8 15:16:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiyang He X-Patchwork-Id: 139183 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D894143DA6; Mon, 8 Apr 2024 09:55:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F0C240289; Mon, 8 Apr 2024 09:55:26 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mails.dpdk.org (Postfix) with ESMTP id 735B640041; Mon, 8 Apr 2024 09:55:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712562925; x=1744098925; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=qlNKdD3rlTJqXpACSp4g3veudHB0lfWVYFzwMBAEP2A=; b=GUGwdtFAg9k+tiKP8JXWMYJFm+OhB3MjAekKy2kvzsspYCMFLzqPFeeX hO3SU6k3Zx/m7/BI3ejRhUH6EKaMkTewDmhSBvmPFXhGSEYwZhUzQcPF2 YtHhVl+R00CaE5btZwofjC0e3Bu00t/3SSUqdMCuWdCSyRf/PIozISQR3 LT3iufd01g+03l3W8r6zN+bQZhOKfYDGYXl0wplqHb60az1bEc1ieUNZt lm3CS363Ugag3UpR3DEWRw6/8Ae1SYBkD2Gk+Fo285ZCp5/m5XrwOqgc+ asv5BhFbF/T0X2TSMQrqLpRkDbkZ0qJDNF996JCVkYcvz5jpSoZdTz2Uw A==; X-CSE-ConnectionGUID: AytfgYyYT5arJM+ZWDS/xw== X-CSE-MsgGUID: hCtqbJx/TGaJcdBMptHRqA== X-IronPort-AV: E=McAfee;i="6600,9927,11037"; a="7692681" X-IronPort-AV: E=Sophos;i="6.07,186,1708416000"; d="scan'208";a="7692681" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 00:55:24 -0700 X-CSE-ConnectionGUID: DlNTGPRbTHmROGzJMukgWw== X-CSE-MsgGUID: bgXiiqbjQk+RxmgDjnUK+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,186,1708416000"; d="scan'208";a="19762990" Received: from unknown (HELO dpdk..) ([10.239.252.115]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 00:55:22 -0700 From: Shiyang He To: dev@dpdk.org Cc: stable@dpdk.org, Shiyang He , Qi Zhang , Murphy Yang Subject: [PATCH] net/ice: fix EIPT check is always true Date: Mon, 8 Apr 2024 15:16:17 +0000 Message-Id: <20240408151617.2095307-1-shiyangx.he@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When enabling hardware outer UDP TX offload checksum, the EIPT judgment is always true because ICE_TX_CTX_EIPT_NONE = 0x0. This patch fixes it by checking the non-zero EIPT flag. Fixes: 2ed011776334 ("net/ice: fix outer UDP Tx checksum offload") Cc: stable@dpdk.org Signed-off-by: Shiyang He --- drivers/net/ice/ice_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index 13aabe97a5..3e2264de7d 100644 --- a/drivers/net/ice/ice_rxtx.c +++ b/drivers/net/ice/ice_rxtx.c @@ -2751,7 +2751,7 @@ ice_parse_tunneling_params(uint64_t ol_flags, * Calculate the tunneling UDP checksum. * Shall be set only if L4TUNT = 01b and EIPT is not zero */ - if (!(*cd_tunneling & ICE_TX_CTX_EIPT_NONE) && + if ((*cd_tunneling & ICE_TXD_CTX_QW0_EIPT_M) != ICE_TX_CTX_EIPT_NONE && (*cd_tunneling & ICE_TXD_CTX_UDP_TUNNELING) && (ol_flags & RTE_MBUF_F_TX_OUTER_UDP_CKSUM)) *cd_tunneling |= ICE_TXD_CTX_QW0_L4T_CS_M;