From patchwork Thu Mar 28 13:08:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Coquelin X-Patchwork-Id: 138955 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7BAF43D6C; Thu, 28 Mar 2024 14:08:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E794427D7; Thu, 28 Mar 2024 14:08:36 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id DFF0341144 for ; Thu, 28 Mar 2024 14:08:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711631314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tlkgagNfOx55GYlEWV5qajJcL6HD3V1SKEah2NHAuGg=; b=XOuBBWRn0xjS6n65XduocbLt/1PCqWzt728jfb7vo/B4i5VDiHGHNQHTVbqHqIKE7KSHqY WYlH3Elr3n6aOTzPJJH+h70froPzeIXwypJEpxwgD7uDsR/z459pyyBnsl3fo/dy/K2vQ1 UPhKeA1IVLnUjjwGseLhgSJ7VVhtKAk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-60-1a_JOoEQPTWgaJHKe-NsMg-1; Thu, 28 Mar 2024 09:08:31 -0400 X-MC-Unique: 1a_JOoEQPTWgaJHKe-NsMg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B616B80FAE4; Thu, 28 Mar 2024 13:08:23 +0000 (UTC) Received: from max-p1.redhat.com (unknown [10.39.208.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0455A492BD0; Thu, 28 Mar 2024 13:08:21 +0000 (UTC) From: Maxime Coquelin To: dev@dpdk.org, david.marchand@redhat.com, chenbox@nvidia.com Cc: Maxime Coquelin Subject: [PATCH v2 1/4] net/virtio-user: rename queue iterator Date: Thu, 28 Mar 2024 14:08:10 +0100 Message-ID: <20240328130813.3696005-2-maxime.coquelin@redhat.com> In-Reply-To: <20240328130813.3696005-1-maxime.coquelin@redhat.com> References: <20240328130813.3696005-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This is a preliminary rework to prepare for iterating over queues for non-setup operations. Also, remove the error log that does not provide much information given the callbacks already provide one. Acked-by: David Marchand Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c index 4fdfe70e7c..c3d44880f5 100644 --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c @@ -129,7 +129,7 @@ virtio_user_kick_queue(struct virtio_user_dev *dev, uint32_t queue_sel) } static int -virtio_user_queue_setup(struct virtio_user_dev *dev, +virtio_user_foreach_queue(struct virtio_user_dev *dev, int (*fn)(struct virtio_user_dev *, uint32_t)) { uint32_t i, nr_vq; @@ -138,12 +138,9 @@ virtio_user_queue_setup(struct virtio_user_dev *dev, if (dev->hw_cvq) nr_vq++; - for (i = 0; i < nr_vq; i++) { - if (fn(dev, i) < 0) { - PMD_DRV_LOG(ERR, "(%s) setup VQ %u failed", dev->path, i); + for (i = 0; i < nr_vq; i++) + if (fn(dev, i) < 0) return -1; - } - } return 0; } @@ -157,7 +154,7 @@ virtio_user_dev_set_features(struct virtio_user_dev *dev) pthread_mutex_lock(&dev->mutex); /* Step 0: tell vhost to create queues */ - if (virtio_user_queue_setup(dev, virtio_user_create_queue) < 0) + if (virtio_user_foreach_queue(dev, virtio_user_create_queue) < 0) goto error; features = dev->features; @@ -205,7 +202,7 @@ virtio_user_start_device(struct virtio_user_dev *dev) goto error; /* Step 3: kick queues */ - ret = virtio_user_queue_setup(dev, virtio_user_kick_queue); + ret = virtio_user_foreach_queue(dev, virtio_user_kick_queue); if (ret < 0) goto error;