From patchwork Wed Mar 27 23:28:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 138942 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B16E43D5B; Thu, 28 Mar 2024 00:30:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3970942D2B; Thu, 28 Mar 2024 00:30:23 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 0DFBD41140 for ; Thu, 28 Mar 2024 00:30:17 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1e00d1e13acso3044065ad.0 for ; Wed, 27 Mar 2024 16:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711582216; x=1712187016; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H26hsjphdH2pd0aElhNbFTheietDSMGNDC4gVBIN+HU=; b=i4/xepa7Eg9tsxVBH9U0xiDvRpXOM9FGfX1b3u5wk20IneCq4lN7PvCZ6VD1ZXO8/k y6IF/jN2E14TTeL0QS+wTlEGI50PY0K7gzR3GsXsPuU2QlCPXqlVZ7H94pSR07RMNbtn G+uav2O8NiVqAzyuEFOy85By2Dst7OZEMvi7b7aeuQLKNBXhbDmB0wr0eL32A6hELWGe UNE9HWAk9UjNpmPt7w8LjENiPf7i/cOVNCJruFIW/Pps9imd5Ky6WAGT2NtPyTr+zxzw KIR+4J9CYZwr6oeyE7ut2FEArtgo4v7uZxtc3JX1eadSxtejEzS2w5GPjxw7dryytVTS yoNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711582216; x=1712187016; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H26hsjphdH2pd0aElhNbFTheietDSMGNDC4gVBIN+HU=; b=spXeTlmoCQpv/dBIcGOXOO5VFGCggNkGJRRUVzZM1c6LSkQRR/y9BOQM3Z7QNAqHL5 GaZVPmI9dTXErBwKnpo59f7QB+IC9ulWkDdJmM1OBT7YfCg7P5TGAceIDxAaxJsFzyAb dTfQdtJC/ND4f2Mu02EsHNXSJmO6Y9wREsYMPUD5WVD5X5WswNb/4Qnic5E0AItU8VjW ah59yTcKcjTqdnaX7+01BU89C0klmlI7VnLUXLEWaKTy26WEdm0y+tfhh4NAFFy2os12 7GMssq+HbAPLytCvpkQspkvknQ9hkuPj00ju56L126H6VifAsJbW5Z8wd+biaeIBbhns nRSA== X-Gm-Message-State: AOJu0YwNkoUEyGSti4KjTONu4GoODNgKZ+9+hvX/IswczkNqcXL6Pl3s 3ytS6MqFtfBkfuOsYfQNV2gH+kNEj9xFtWfmNJAU8Lq2J8Dms02TjZOzYPSvqITZaU6n8NfDCrv x X-Google-Smtp-Source: AGHT+IFY7E3kttn75hGh1TS1JXahfyp34FzLJiUfNoXj+0DloOuvLR3Ddff+jsP1QWAtreXW3/tomg== X-Received: by 2002:a17:902:e80b:b0:1e0:f2a7:ebc2 with SMTP id u11-20020a170902e80b00b001e0f2a7ebc2mr1374011plg.24.1711582216198; Wed, 27 Mar 2024 16:30:16 -0700 (PDT) Received: from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203]) by smtp.gmail.com with ESMTPSA id n15-20020a170902e54f00b001e0fdc6e4ebsm80772plf.175.2024.03.27.16.30.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 16:30:15 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Bruce Richardson Subject: [PATCH v17 06/15] eal: do not duplicate rte_init_alert() messages Date: Wed, 27 Mar 2024 16:28:29 -0700 Message-ID: <20240327233001.83505-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240327233001.83505-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20240327233001.83505-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index 9825bcea0b..17b56f38aa 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -529,8 +529,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* Launch threads, called at application init(). */ diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index bffeb1f34e..23dc26b124 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -840,8 +840,7 @@ static int rte_eal_vfio_setup(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /*