From patchwork Tue Mar 19 08:55:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 138479 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5551243CF8; Tue, 19 Mar 2024 09:55:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CFB0E40A79; Tue, 19 Mar 2024 09:55:30 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2090.outbound.protection.outlook.com [40.107.212.90]) by mails.dpdk.org (Postfix) with ESMTP id 6109E40298; Tue, 19 Mar 2024 09:55:29 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NT+1K5naFNJ+d8fFmLQ/CFI29uhGfQCEEkb5PVIjvDjY8BKljhMTuq18bL8Ft6XHuo0mV/8Ahm5L/+1zZ32GIEXJqfVZu0CdmiGBhbuqqWHWqMnvKqSuIvdLU9ITLO8Riyn0ULWDKtDo6BjQdpCpt2EOodgWSzeFH5u6qD2ATNAszZh7kyOmncO/j3aGFIh9eKB+BqyK0u5mZCRIWG9oKnyygqU9wfCSpxDZz4XSWbcCsRhfszC48qJZuvAvlslpnj1xtQQg4PeglsvzjqoqcRQ/z7aVUGVZov1xMmdT9Xw1EB4nDOaop7TOmzR+p6HCyaF3yjaob+eOOLKup+oLKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rszuxJmM/TqYvhjymbW0i13JcLDbQtb+ONF8AdSglSw=; b=GxKC20oMBgvM+SXmptkLeSNXgQqjLxwttgfPhD7dLgysjPh33hS8s6pWCVq0PU3GQooY0GoFxYOWtKAlJ5QcgzMUdaYWtStKhX5Xs0HpziMaHlE2ivFtgfRlkkwRovZm/enJq2gxhgPdjcpvNwtWq+rri7IznkSMpuxSim19Inj6ISLzmP89kr/z2oJp/SbhugMQkLYVy5qHrQ7j7f1w2iuW8z3/6zHh7eIGQaeLHMUTs+7h6Un0wpUBezlm9q2zowBPXYpEkpKrOUcKfUU2Y3CoUlBJU/bXvwoRF6n5fqcd6paBpNbzf2yhxGQixCVVf2fO5b3lXdhRQh22kckDbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rszuxJmM/TqYvhjymbW0i13JcLDbQtb+ONF8AdSglSw=; b=T3LyoOlg6ssRprmFo/PH2Za6xRBh9yv16+dI35THCpWAOUC7o02KBe73B/fhPSDU/ufnPOFavlvQhrDD1RHBrwV9j0gRM/5Dlr0vcZ+mpsY8Lc483wxYf9OJWh+ClqLe25A/l2qdijrN5MB82P10b1txTNNxGP3BU48HJmGQKuE= Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by SJ0PR13MB5788.namprd13.prod.outlook.com (2603:10b6:a03:3eb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.26; Tue, 19 Mar 2024 08:55:26 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7386.025; Tue, 19 Mar 2024 08:55:26 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , shihong.wang@corigine.com, stable@dpdk.org, Long Wu , Peng Zhang Subject: [PATCH] net/nfp: fix uninitialized variable Date: Tue, 19 Mar 2024 16:55:07 +0800 Message-Id: <20240319085507.438387-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 X-ClientProxiedBy: SJ0PR03CA0011.namprd03.prod.outlook.com (2603:10b6:a03:33a::16) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|SJ0PR13MB5788:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WA5fZbdwxixIia5vwqTvtw49U7ZRLaUokqR415UmSvE9NQH7/ztlGeVutOtqLNBjrKGxwN9I2NP8BX1xlLtMsgRNMhmtM6CIxgnAVm39xcKJSjVZ9x2dkExm4l1wD33PQ4hnIujEfrYwX4jJunzl1jCsojyuD7ytW4wJxVVI8+FXTDyKDZv5jwkS59K1vD2uBW8+ZVdGb0y92A/Vrwn/YEGt2Kiov6dZsU/uHIVP0aYUNbWALb0wYBsc5mehvagOhr5Rml3RDMcqtfXXZowOD/O9SjdAQNfvj8sFWuPskhi+oL9bieX76U6vfmEIUY5a7egi9Jh2szebXjYF0bGhSNqnH9zRn59cNyO+IbpAMoXtyLFzt0i5CGIMKGagWB4c9owYeBh67ktpDnGOPWQSd+0s7HoSOga76Lwpk0F9ca/7vF7SxGOtUKhuj7DPTktcgOWgRxtz77zsmvFGbuIS5DwI49js0CV0HXdf/0W9Nei6gNSkk08l8u6bdI3HBrYxlUu0LR5Qk7u1fN2qysijCMsnCksr/e15Ej/4jchVT5AhcLiHZn3FCVZohfLBnNscm3B+GKISCp2/Jmc3C5xLUWUc2JMNZYacQuHYtkfGL47k5dOHXi67yGUvCI0sTO+X9EdMd/9Q5wXBigLcQz/fE14ZytW/j/9Lmehq5oQH9j4+yT0qOvySxIQvTDNf1MtwpkiGZ30+vkorp+nAqffIiA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(52116005)(376005)(1800799015)(38350700005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: FQaWhmXGZKci+InTFETYemqb/VINyKpw7BtSf1jj7jW4qfD817rCVEdR6IR4Y+v08AmmLofybu8E0aqLohftUTymaK3RE+cnB08bXPz8QUyqLvL7cg3A8WqQeeCCEoyubzx5heYVCg1JBIr9o65UbugqnjxzaDRyHBGuPPKU3BMdVik3/ndoHoqkmZss3v9jPRDv3rQOz0xy8c14gz9r+4G1kHQZH7meBQPAl7VqwwlUtBZ2HIQQLMt5nZiRt0MpvGvzYnLm9YD9pSKj3yBND31vFC3lHAqXmVtPj6PuoQESpEMwq8FRsEnP2kN0gXY3z+mDZSlnYmF91G7Td4mgJGsx/ohg0LXlKa03gMMAO2rux0hUIeYdi3IEos3iBivL1QZAfBXJCuWl+CbvtO/lqqzdX0/q/S2w9mcgrqdFsnHNfdAiASIXquzKDVq7dq16kViPSLu2QgThw2FSeNhNlqy9AgItyxP/v9LvQzOfZDNl549S1KrAID7japg2dQDh6PeGuXdlAviNhnoqy4FpRf9MCywOFR2cThV2/4z0LCzw5foGbAFMe1eSsyqUJafsEb8tkkw8vPOus34+6dbb+pbKmmte6Xd1sC3AXGtHXwPIo4QYDhbss3mFfeK7yhVMpZIpJ03JgoPv0nx44NEC+OM/OVUjUhDfTXy9xVCNfGVdr0iK+KpZhhNPWOEvRMMSVtf6IsYzT9yM/Ov+HhC/1zHj2xYFGEAYxI7BzG5DU4wVhXUarGsFP0MRZQflBg3LQS052asph4iJnjxchj8c0IMtL01pZh1aLriHctHzSwfWow5vg9Zz8HvYsxsLNrKmhnCnPpGiJG7bTs4gnXEsnvDJFVFzV0DddN0RqKYvWz6K5twnguVtVNv3ZDMemZYMwMXiK5yIQhxzfGO1RtWkIXkMv9P0THBCQvCn7zTCYK3jhgI9GYBz9puWiMsIOgsFVU1PHHROcKLvcXXLv6cYkEBAHqjILSog85SV6Y3tafhqGhpv9FkMmmdlMfg9awvykMGvZBAwKG9g2/ia78V7PtnTUJU3zxP4Gr08NSKEyLSdFu5kaeJWYEYZ7qI/PKT4yThUbUX0DOp1tKgb9se3/fMIhr/eFQ2PMtfIgYAOxuTQ9IcTBlKVzlDGHWbe78kkl6ARk3K7Fdc+JpRZzDFwZkbnAxmRWdnr9ybiTFM6mLU48pngSBl5nNeNqXmXjUHsRoS37WQnZwgFZVjQ62t7/imVBINgW4wMD6JV6qigc1bKt8mW67X5HxvGMMLDZbD4Zx9F6hWCf0O7/Feib4Ul78rqT64gKlSFPjI8KhVxTV0V0aMlPZbES+rL3Ph1p/sDO10dat2DRS8yHl+t/e9qnOYLLySnIbZVujl1mK1R+Jn9U1HhSPI4lbvI2QPHUSFMtB11n843LHGkcZa93C5kTT9sOB3LgZCvLUIq3iu24gqKRSgezsxs84TbHOAeuuiakMgTAgDrZdq+skiRS1IyDv7mApp/RFjsJ7V7RX9pNBm8GZI8FaReXBaQVLgYtxgIKoa9iJ5Teh7PqptpO5i6ACkK0r6TXaNOWsJ4H91Dp0+xedyJdG3DrbNqJdnsnU9e0XsuxkLVByQsOKUNU2GY4Q== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b4c74f7-857a-41a1-360f-08dc47f251b5 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2024 08:55:26.1582 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zbJCXc2Pvu304qrRXu0+pj1yGG4VqY8UaKsi6wW/XLZ62S7YmKgpUbHh1vyIW0GFCWLqloIWJ5raowqC5ZSKE/RXmWhVlk4FNJZbu3fy5os= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR13MB5788 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org CI found in the logic of 'nfp_aesgcm_iv_update()', the variable 'cfg_iv' may used uninitialized in some case. Coverity issue: 415808 Fixes: 36361ca7fea2 ("net/nfp: fix data endianness problem") Cc: shihong.wang@corigine.com Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ipsec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_ipsec.c b/drivers/net/nfp/nfp_ipsec.c index 205d1d594c..647bc2bb6d 100644 --- a/drivers/net/nfp/nfp_ipsec.c +++ b/drivers/net/nfp/nfp_ipsec.c @@ -526,7 +526,7 @@ nfp_aesgcm_iv_update(struct ipsec_add_sa *cfg, char *iv_b; char *iv_str; const rte_be32_t *iv_value; - uint8_t cfg_iv[NFP_ESP_IV_LENGTH]; + uint8_t cfg_iv[NFP_ESP_IV_LENGTH] = {}; iv_str = strdup(iv_string); if (iv_str == NULL) {