From patchwork Thu Mar 14 07:05:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 138340 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E323B43CAB; Thu, 14 Mar 2024 08:06:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5235A42E63; Thu, 14 Mar 2024 08:06:08 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2091.outbound.protection.outlook.com [40.107.220.91]) by mails.dpdk.org (Postfix) with ESMTP id 58E7042E4C; Thu, 14 Mar 2024 08:06:05 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LDWyOIln7N3LB21pb0oSBR+vnptxZZ5yPTXlxypOOB9u4OrY1j/Q0Ohdu1+L0erFOPlBv2IvvQDvZGDK/vcAxX/zyP2OpFGdu1rxY5yP0UXCooJlcUpBYEJEdDzSyUtAgCuFJO6vTepKAxSy8kC4YG/cTQmYTbK+3lMtekx2m6ByEoasZk+kI1pYBY9O3r5UbGTKeq/ovepgEzAo/0XKtePdr8/pD/Pmg8wUt7kZ9H67IF/lsJtWlkO9w7HGZ7FT8KdHUXzpQ80JB//sPC4uT40lwjiMDXDQlTi72dUfELwRswB6ExfFMl34iQfPijchipzEd66KYFYGO0YzjLAytA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lYyea+SHyUtstUQBTNwuiaui4P6HKzoY2nH6zaWhB4k=; b=c1XW57fOa+0p8bRBDq4GR1pY685/iZ1cn0+WOG+0rKTyJiJMaKiOOvCisB5SBC92w5/InVzc2sagPsAvaCbq/JjyKj237GUebgsvCiqZiibGbZcxJ+0RWE/vsP6dxWO+FZEWLdV7fwhqAfIGU0stSpGVotzqEwOBca6MPom4axEV/BA8sh4rKMNxcvNKDknaq8KOgkQq7I5LR9/CBBi+yqu+dNOn+ZJtj5JZ0w6HEUyXdQJ2b54UyXbsg+eqsrxcrFx4qZ+sF7f3LoiUZEOh1vyvQJH0VoljGKuGOkolr9Gr95mi6CbxUCDpLY8DgmeiNB7pqS0bTTnUkiJk6LmcXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lYyea+SHyUtstUQBTNwuiaui4P6HKzoY2nH6zaWhB4k=; b=PkVElaXqgFMhWUf3bwq+5RV2Mul38KwPCUiPDUEKzS6RFGzh8e6gkVyjpDl0ctzP1iVGZjjZjYTMkgVoOdGDhPIhTtNQV4rcgJUPtvreoLcEV9nbiABAD0c36+kGa97VP/WKp7J1hahfPwPRNSaQqGe4uDk/HRAAaFY21ElrwZw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by DS0PR13MB6235.namprd13.prod.outlook.com (2603:10b6:8:115::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.21; Thu, 14 Mar 2024 07:06:03 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7362.035; Thu, 14 Mar 2024 07:06:03 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , stable@dpdk.org, Long Wu , Peng Zhang Subject: [PATCH 3/8] net/nfp: fix unreachable control flow Date: Thu, 14 Mar 2024 15:05:31 +0800 Message-Id: <20240314070536.3169210-4-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20240314070536.3169210-1-chaoyong.he@corigine.com> References: <20240314070536.3169210-1-chaoyong.he@corigine.com> X-ClientProxiedBy: SG2PR06CA0191.apcprd06.prod.outlook.com (2603:1096:4:1::23) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|DS0PR13MB6235:EE_ X-MS-Office365-Filtering-Correlation-Id: fd7aa263-f6d1-43f4-b5c1-08dc43f535d9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: phrayM7vJkD0MqsmdWg82EtEUNKF8zBhc9vH7GyDr5uzG/qgRjLA4OYKy/RYjwcDJt8/uNmxTkXn1hkMzuQgBhEvyjVEqpdNAVtbv3Wc37Eb3rnfBG9ion9clsC8h6vfT/m0wv7HUoAH7IrtT2xD40b8Cf8TmQHwRHZr0bSjEMdysEmCQmEfGqWtOQl/z52VB2tJXb7E0i6eJvXOljMM0VyVPR1h+5BCZRbJ3QJZuPXAibUdC7sHMIaH4dpFOr5pOEFU0c3xJTZt58pbQTeJpFh0/ys27pOsSXqp6/exB6OX869l4g0wgf7VwckET/5qvtLx4WJI6sbhwDd2bMJR3TVAla8TGxrp2wLG3yz6W6rOToWZ4F4WczGcydYWdPtEKA2UE4jyFzncOSeycIJZR3jttOajt/I9iOH+DB2v2Ql9ZIwFd6+6dESC7q4SqrQJCtH38ZVaQRguQH0xZf4IQNLAi230l1WJo7a5InHpJwr/PB5H7w2x8WyZJ2ipXVQXxZlNL8H6hTAdvzTBSHmX273Px7VfHyRGra6Udethyp/VXiwfKJrsR8X2ZnkB/HHZHFKgc/nU78ufKyMJ+vJSiIIwkV/oUyWMUeaXU+yThTnyhMNB0j2OcaYn/Bdp+SJvSl3tTSz82usaROUKMoY6SHAMYIdIP3HgCKnrBBTuZqyA8LL7+qUpwANOxYjaCusTnQja8+1AB7m8y5uTvl93ug== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(52116005)(1800799015)(38350700005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: uSGeRxeooDHqb+dN4NHOIdjjCCBymT7RK2rrWASM9OA4Xkvjnkl9aGRRdRzN9YtaJIfcUSF36wNPp6ENVfF8AitW1I9INM6+rQoQFQ6N0c/uQcPmajgvnUxVE0ih8hRW5+6kdYnIhBYvztHbGB9ezz4Tl8/k6X+VBLTANPg/DnCx5uqsWDIiHrR04iUsfXPr+k2aJ/W9sN/lYnsaQOXmG7B72hAXI3+BWR1s29n98ez0rxIShVOLZK5P1snejCsvZCooFXXd1nMIA5YZCu5tqqGgtOyDMVMdUYftVjSVsdG2s43hlC5bIbeqFQJlpW+mhLcSj7POosbTrO8P9NGZovEpe51xIpuUaeWUhRzZnhpDUaJjsakjGj+nuKFpi/gzXxCstmuoQqZGv4VtDpzuT0cYzNpNv9hcjUoQxf7IY2RYtBbGsn7ylHjXW8W7lupKVlWUxuiGMQhaUdDv8C0knrNSq/HBuT6XA8nV0h8KrmBDXXaOHId8Cfa5pa46f8LibK5Hvh7ocWo/VDMiRUQ8nax2UPfT83VT6IC33i3Y6i/ZkEsAsHdOao0WB67ESbwZoLLgSbaKPR0sdYm1sWiP9uAPNtFkhpvu5c/uBHb0cTzdb2hMImCWhZwCG12ZyV5ZcyI2Dj5erCWlA+wUYpLclpizhb4bzY3prQpfNvHopgltsqKqAFeK9EM8HzcnwKgQdibi9qt+bU6GgeK9o2U/BtA9FoUI0o0J18vG7vb+OahvW13tQIGroeJzrrtUTj0DNc0q7YOsrIwRuQeNKuzw/M9gwDR5TjywfwRgBAoF02QBZjNxK822WQalOM/xo+k95brFEeiQIum+A/4sOlSvvpjpTAhXU1uz38kqfSv9kuDrKonax35czDl3hLJTU+zP15itUuael7WK1SNJZ/UTB5oj54w3KEeNyrQbrtbJD/lL2yI6l31d+sfsPrA7/Aantb+EU/0j7GRQ73Y+sJVWT6rbYiUoLLXSE+D4VoyeXh3gZqNRdT/9+Zc5ch37Ko2UhFiydiFZn5LVUZTI0Jq4keeGS+hXgknfRkn+BKeSTENezqGBpJZ0yqyNR3DOyuOvD+vIe7i+eDjAObrT2bYMpysd/SWB8k3iQqdZw0r1Nm9KQEpyv8bpARegzmSFtq8HtMVQqG+W5FP/Hz786diLTxEcmvHQgMFpDCSF64ddt2jT3H/mUQgnaurEohcurAwneCdjZ+6kKcZFdUyvUoYyfbbZ9+unpdq7sgtLZAyP+6Xg/erV6M4yEGWpAxfJzraUh839fBwzlLjSsuVZfRsOGuqZUt9KOPMAk4lbSUNe7Lkz0+/RQ8ACRETqfLG0Ce+H/xozTsdsAbBdrjhrPNlgaKNXfxhO+Np9XoadUzjc8VKEwKFoFJGj5d+Kql19yPLd9R/N+oq5AIdqDVoGN6RjYRATxOj2iTA/i7z04uY7z5Q5m37Wlr4iDocGP2VuYwsCyT+enbf7oIN8tXxk67tjAqC91+rq0XJq6WsLy2XgErYYdXBJ2ZN0KADhLUISbrSm5buXTG7iMclY3XVnCUT1kYXJgIBfef4Q/jVXESPioFko72NNZbUVVC1QBMzKSQvbcVV7easfoqcSXdA1+0PrvA== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd7aa263-f6d1-43f4-b5c1-08dc43f535d9 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 07:06:03.2254 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ftSGTXyTNxGeKaC+f+qlmAToBLIwch85biSXwLWLdGAtVWmK/ErbS4b2BeihbaI9kWZ8DwfXcXby4RJ2EuvD/AEomzMi7Hk0UAo5b+seYyk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR13MB6235 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org CI found there has unreachable control flow, fix it by remove the missing delete 'return' statement. Coverity issue: 414938 Fixes: 369945667251 ("net/nfp: fix resource leak for device initialization") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index 31c54a595c..568de1d024 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -936,7 +936,6 @@ nfp_net_init(struct rte_eth_dev *eth_dev) err = nfp_net_tlv_caps_parse(eth_dev); if (err != 0) { PMD_INIT_LOG(ERR, "Failed to parser TLV caps"); - return err; goto free_area; }