From patchwork Mon Mar 11 12:55:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Herbelot X-Patchwork-Id: 138152 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DA7443C87; Mon, 11 Mar 2024 13:56:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21EC9402DC; Mon, 11 Mar 2024 13:56:01 +0100 (CET) Received: from mail-ed1-f100.google.com (mail-ed1-f100.google.com [209.85.208.100]) by mails.dpdk.org (Postfix) with ESMTP id 15B714026B for ; Mon, 11 Mar 2024 13:56:00 +0100 (CET) Received: by mail-ed1-f100.google.com with SMTP id 4fb4d7f45d1cf-563c403719cso5155095a12.2 for ; Mon, 11 Mar 2024 05:56:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1710161759; x=1710766559; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JV1bOh+18yH50lGzPqLw5N+G8nhvfDeQ4I45+SJ4aEA=; b=HHYAYcDB4VpBsGXEJdq1G6KLztLzCBjkbeAYc/eVHh/MTQASOREgyQKqC+88x2IlfD uDwuHyGNOqstXG0Ukfu5c7dYcP/vhTQON2tX8wtAdFmn4ggJaEoFM8EhhQrxgRSH4vGh +YGX32qnE2R9G+eDcAHe0bswp7uFvteYDP/eF16j/drjzuG/cHAizX/NUurRFPz5Z9br iJCoX5Jw6uxYktHsxo7ga2iGSvrOzNq5j+SUMRXRUqmRuNwhMkMRQeFStjzsoeSSjrVh CImjVCG/71vFhIDQsymFzfNLOKjUNwlSx7id98dhN4frcSQ8HOdgxms+5AdC7d+FnDhB Nl8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710161759; x=1710766559; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JV1bOh+18yH50lGzPqLw5N+G8nhvfDeQ4I45+SJ4aEA=; b=feOhOsljRWyTIe4ahgaaa+BEbREDRrIWIS0BnpIbL8rJT07d0b1m5Uh6COx37di4x1 9YFIYMaETxGIBLq1zGp1pQuBg9fDWh59VTXRk6UaqK/rkG0uFRJAaHPXpcZhy5F41w31 xhxqh/CjYNrxb/BIzpmMPq4bJupRsfhm7OLoX8iSrDVSh6L7sfDB0zBhKbV3MXXnifEi EJUoghPrZ3rd4q47iBu197ozKGiERMg4kK8Ju8osqozVPru3wVArcNhnEmmINztLYQrN Mgmq7TbJCiiBuMX8fV4h89GZDLAeBNeUr38UfsKZwAQJrH+hb1/eXtV/1aIMYxTBiukf GFAA== X-Gm-Message-State: AOJu0YzNukHTncn8RY+kFFv1aRh1n5IKoI1lzoScUPJl3wF19a0sumYn oQZgQK1kccgRNZ62QedE/A9Hax98LrLVOF6vGXIV+fc8fpp2v0W7kiwfhr7aBf8+hsbcKlpD4Uf ZBVRdPLE+K7pBjv/Ztic4OP38GZRRgKw= X-Google-Smtp-Source: AGHT+IHLw4YtkkTLvDsUjt5UqrMMyWmdsC4R9be/nia43SrbB3t6EjFuePZGnXGRlvAB7EnURLgmTy0KynJM X-Received: by 2002:a17:906:730b:b0:a45:ac3b:4aca with SMTP id di11-20020a170906730b00b00a45ac3b4acamr279172ejc.44.1710161759597; Mon, 11 Mar 2024 05:55:59 -0700 (PDT) Received: from smtpservice.6wind.com ([185.13.181.2]) by smtp-relay.gmail.com with ESMTP id cr16-20020a170906d55000b00a45b930c16fsm145201ejc.1.2024.03.11.05.55.59; Mon, 11 Mar 2024 05:55:59 -0700 (PDT) X-Relaying-Domain: 6wind.com Received: from localhost (vader.dev.6wind.com [10.17.1.39]) by smtpservice.6wind.com (Postfix) with ESMTP id 5117460235; Mon, 11 Mar 2024 13:55:59 +0100 (CET) From: Thierry Herbelot To: dev@dpdk.org Cc: Thierry Herbelot , Thomas Monjalon , Harman Kalra , Ferruh Yigit , Olivier Matz Subject: [V4] ethdev: restore eth_da init at startup of rte_eth_devargs_parse() Date: Mon, 11 Mar 2024 13:55:18 +0100 Message-Id: <20240311125518.2714496-1-thierry.herbelot@6wind.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240311115722.2708497-1-thierry.herbelot@6wind.com> References: <20240311115722.2708497-1-thierry.herbelot@6wind.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Commit 9a9eb104edf6 ("ethdev: parse multiple representor devargs") removes the following variable initialization in rte_eth_devargs_parse(): memset(eth_da, 0, sizeof(*eth_da)); Restore the memset, as this causes regression in ixgbe PCI probe. As the listed commit introduces a new argument: nb_da, the memset takes it into account. Fixes: 9a9eb104edf6 ("ethdev: parse multiple representor devargs") Signed-off-by: Thierry Herbelot Signed-off-by: Olivier Matz Reviewed-by: Ferruh Yigit --- V4: use nb_da to define the size of the memset V3: fix variable name V2: fix git hash length lib/ethdev/ethdev_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ethdev/ethdev_driver.c b/lib/ethdev/ethdev_driver.c index 1660dd3f2a46..f48c0eb8bc5a 100644 --- a/lib/ethdev/ethdev_driver.c +++ b/lib/ethdev/ethdev_driver.c @@ -617,6 +617,8 @@ rte_eth_devargs_parse(const char *dargs, struct rte_eth_devargs *eth_devargs, unsigned int i; int result = 0; + memset(eth_devargs, 0, nb_da * sizeof(*eth_devargs)); + result = eth_dev_devargs_tokenise(&args, dargs); if (result < 0) goto parse_cleanup;