From patchwork Mon Mar 11 11:57:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Herbelot X-Patchwork-Id: 138151 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16C5D43C87; Mon, 11 Mar 2024 12:57:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A45894064E; Mon, 11 Mar 2024 12:57:57 +0100 (CET) Received: from mail-ej1-f98.google.com (mail-ej1-f98.google.com [209.85.218.98]) by mails.dpdk.org (Postfix) with ESMTP id 0AD294026B for ; Mon, 11 Mar 2024 12:57:57 +0100 (CET) Received: by mail-ej1-f98.google.com with SMTP id a640c23a62f3a-a4627a7233aso134937366b.1 for ; Mon, 11 Mar 2024 04:57:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1710158276; x=1710763076; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/utpYsVcA5JmLalbombk9Xu1b/54h6UZTpyPyUygTfQ=; b=RdojYDssCabNPgQGXCNpXOR80Vsb+yLskYD5HiOThL7Bgh69t+SRKzMekUO30sPRUw cEkUy5qo9G0bOmLkaJ+nW6OQ46OKkw0amyUabGzxKyIqwEgN1DBJEZF5SEget1lqPPdd 9bLJXQ2/Dpb9qlHs2fJQdLlVl5NlFbXu/zQ6cALGS7J9z/IYPoDxpYEuP7oSQrzR8klg 68EdMJlB/jk64ZYiJXqD06qfUnXreYEtGNLQnKqrvoiRYkTCl6hNbdphR+nzPYSmh+i2 2MKRZCLTNp1bWNZKxr1A78LborXWnMoq2Kc1F3Wmc82tUWfuNSwsejuTq69CPR7/jfq0 TI4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710158276; x=1710763076; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/utpYsVcA5JmLalbombk9Xu1b/54h6UZTpyPyUygTfQ=; b=eli6sd6Kazdf1Vx70QIbkXlP2gLL5TvQrL+cvore0mYlQCDGDYci4KHXArR7yLjJ67 t9rVLf29v5YDRBLDZZ+E/M/n8OQ2qpNuIyfQbsFfmin1b3yRiwAWZLG0BYX9MjrjtzNf Iei4yktoldmkseRqW8ttMG/CnJv6wE4MaEGN6WUb6yzyII8WhefS1MdO83ZCMpGxzuEx KaQilav1u1jytqzViNWnqgaf7QVBseNtu0c12Hz4+kKUVpTD9685nl3rSaiTum8fs/k+ JnGdXl+BfQ4Mbh39kSpp4RzexpC0UAfDY1trntvwv20rkMo9NAyqoV2YV1Y+kAjHVCXY cNng== X-Gm-Message-State: AOJu0YxKIggvwWVERALBfYbWjE246uC6FtXMWDMHeRirw7R9bTnU3xGP S7qmqgO6v3IgM++dvdtwZsqlzD12sMbNSen64QhQzKhtlZvZWaXUy07Z27q6tJwfRRicuqf6iE3 7E5Dx3IAj3+K/9QScw3q0q3kBT8eGSpw= X-Google-Smtp-Source: AGHT+IGmqoKQA7pLJAM/utFOgZD4iUvUqkoOWEaUVJ6i1C9qlm6BJHKK5cEmKAOi5x2DWQ+cT1aXBPmM7IZ5 X-Received: by 2002:a17:907:160c:b0:a44:52ec:b9e7 with SMTP id cw12-20020a170907160c00b00a4452ecb9e7mr6290103ejd.16.1710158276554; Mon, 11 Mar 2024 04:57:56 -0700 (PDT) Received: from smtpservice.6wind.com ([185.13.181.2]) by smtp-relay.gmail.com with ESMTP id gs43-20020a1709072d2b00b00a45e3cbf28bsm141616ejc.174.2024.03.11.04.57.56; Mon, 11 Mar 2024 04:57:56 -0700 (PDT) X-Relaying-Domain: 6wind.com Received: from localhost (vader.dev.6wind.com [10.17.1.39]) by smtpservice.6wind.com (Postfix) with ESMTP id 472AB60235; Mon, 11 Mar 2024 12:57:56 +0100 (CET) From: Thierry Herbelot To: dev@dpdk.org Cc: Thierry Herbelot , Thomas Monjalon , Harman Kalra , Ferruh Yigit Subject: [V3] ethdev: restore eth_devargs init at startup of rte_eth_devargs_parse() Date: Mon, 11 Mar 2024 12:57:22 +0100 Message-Id: <20240311115722.2708497-1-thierry.herbelot@6wind.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240311115129.2708247-1-thierry.herbelot@6wind.com> References: <20240311115129.2708247-1-thierry.herbelot@6wind.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Commit 9a9eb104edf6 ("ethdev: parse multiple representor devargs") removes the following variable initialization in rte_eth_devargs_parse(): memset(eth_da, 0, sizeof(*eth_da)); Restore the memset, as this causes regression in ixgbe PCI probe. Fixes: 9a9eb104edf6 ("ethdev: parse multiple representor devargs") Signed-off-by: Thierry Herbelot --- V3: fix variable name V2: fix git hash length lib/ethdev/ethdev_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ethdev/ethdev_driver.c b/lib/ethdev/ethdev_driver.c index 1660dd3f2a46..18f1144dcdeb 100644 --- a/lib/ethdev/ethdev_driver.c +++ b/lib/ethdev/ethdev_driver.c @@ -617,6 +617,8 @@ rte_eth_devargs_parse(const char *dargs, struct rte_eth_devargs *eth_devargs, unsigned int i; int result = 0; + memset(eth_devargs, 0, sizeof(*eth_devargs)); + result = eth_dev_devargs_tokenise(&args, dargs); if (result < 0) goto parse_cleanup;