From patchwork Mon Mar 11 02:32:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 138145 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B05643C7F; Mon, 11 Mar 2024 03:33:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E7246402D8; Mon, 11 Mar 2024 03:33:13 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2102.outbound.protection.outlook.com [40.107.212.102]) by mails.dpdk.org (Postfix) with ESMTP id 812DB40278; Mon, 11 Mar 2024 03:33:12 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YoifKDw9J0TNM+N65BsS8X7SYkojUQXFLTUp5KUE9W3zlnUU21qYVlB5T5watdXVj6W/oYolFF7CrtlscW9PU95CaLhHVbL3ytc+yAqvKfjSYC5/UmCQfm/6A1Ooe/x7NZlARb5eAlStAK3Q+1ngts6nA3gqhJuBmNPbkxuPuODk51OlFois75IAVQ4tk1xT+OVgSYu8LxHY997A+cvtGye+CjHwUqahfxzXdHLeOx5281/pohj7enULaH1QBFMF5CirNTGBh3zDwmBaKp5XYvP0ZCkUuGacZ/ylT5gWzPh+cGcjdPD0run3Q9y1q93kGwgVJVALa0pOXuWvgzvrcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=de5wj93YZsBJGEp27C16V2gP7L/BrkvRqMYCHXg03Oc=; b=i3L8pYtwnpnJGWnv+pJdjxXMDsUi/hEJgqC5wnL3HGJqZlNh12G84vOLqBtUqGFzIQK7BpaHpLHwbU3HB/AYEbsqI8AHsXI9h5lvRxRWrg8XUzSRgEIEt+YcL4f47Im7J96naOmAk54RuHEQ43Y6lPCgE28I7yUH6rLgJ7l+0iRvMvlLu0jnjywZu0o5dbDFJQWQMLKkyd8aqkuwADfyZJk6vLgnlxQ/bLVY+2lGkHoZwxrSGrrp6SUrlW6xB6yR4PiZdUi2q80IbvviefFu4ooQ9KjDtR05dHTPSD8yKqb8X7oALCWH5Y3An45HLGRZcWy6eCvyMfzOGjIPOt7xhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=de5wj93YZsBJGEp27C16V2gP7L/BrkvRqMYCHXg03Oc=; b=ncC8YN2YOKfS/p4+6SYHMd8k+sEyAJkbKjrsqUCR4/b3lyZJjAHMuC0jddhFqMHJpVihz+QNVP9v72i9PamQni9q3S6y/YqcpDpb5cAO0J/EIERPtMJiA5Qp9y/QSMQKtewGkNVEjDV9EHbRVK8lJvQA70Hq3wwmn7QVcJnNHwU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by SA1PR13MB6056.namprd13.prod.outlook.com (2603:10b6:806:330::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.24; Mon, 11 Mar 2024 02:33:09 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7339.035; Mon, 11 Mar 2024 02:33:09 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Shihong Wang , stable@dpdk.org, Akhil Goyal , Radu Nicolau , Chaoyong He , Peng Zhang Subject: [PATCH] examples/ipsec-secgw: fix Rx queue ID in Rx callback Date: Mon, 11 Mar 2024 10:32:47 +0800 Message-Id: <20240311023247.2520028-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 X-ClientProxiedBy: PH0PR07CA0072.namprd07.prod.outlook.com (2603:10b6:510:f::17) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|SA1PR13MB6056:EE_ X-MS-Office365-Filtering-Correlation-Id: e39e00ea-8c35-43ec-faa0-08dc417396c1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dNxN3U19oQw/OoOaiU+mClIL2slJuDiFZU3oC527jZw2o3f26PDJ8s9RqqbpuB+2Ae/kmUKMBxjP8bsRK7d5l62YluD9mIqg/lQs2pdXx/NTH7Farlhk+jz3OFhQ3XAFzrwSDwfNb/nx4vk54c5WncZg1BRz6zuFHfL3m0FFW46RQimVSzK7zL6nXZ4jc6jBmXABah7kUqvI/m8FFr5+NufDGFGkZ7QvMS/+gLAn23mYH5tQFBxzZ20UsN2ZhtEKqk+NN5rg0aaIUDS4OcciQ83hY4oLaHsHQetyVJdJFxXF0T9nU7N6bRIBOmj3mwZkhiW8esfKoPR2euXSLSssw0KFU8nnZyNM2lr4Cy85QAi5FI7saoR2TrSI6qv2zH9cbD0h1ws85OYOXCXtcKZ5+AtX1yMbwGTwNlbm9Me9QeP5cO2CwKgHwLfKOZV97Ys/+pzXYZT/6zKoHKTvRXNRTYFgD9r1ZCMX6V88dnpA7jxRxRXB9gXwNIBhCDKpd4bvouOxLCeSLVdtoQRWOJF+7bOL0jN+1c2PiSFarnaH3wDIPihqSj8197Xb/kwtyQrX3c5wTtgclnHBAu2hCzxVOafUGZTuXeQG7EdJJIzZeTETRclJ1XPMOW605UrgBQr/HawvbWp076HoeNS0c0M+Hn9PX89dMK9ZxomZluS8M7wS+sSzoKD3vFyX+j/fdFRTBc+ktuoK0oDEmx2LHauFJSinR8ce55H3LHOYjsNPUYs= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(52116005)(1800799015)(376005)(38350700005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: s8JW3/gz+h7I5En0363xWpawBtsK0hxQLavS6CT6TX6OdgjIjl425opIKHYuk41ckYvxgJEG3xyZ9hj/F+ohHQ2eFKHwRnRxebfxFys4T5PmJyT7lRhImP7qCWkIRc7gYFaPi59OIezEbWK35Gym77gJ7lDG3uufCYdmOX7E1q7WaD8Y0F1h16vx5oWNUJQBF/3o4h99TxWhD1Z4frwLgiECYHZ6aE6M+6EoF1qlj+lXcnoB6ZH68WjezKYADxBoeRC3pYYM7DWvaiNPHo/BCZ6RzyWTZ4BdYXZi0ExTYSY4c/PX/b6593NImBE61VdcKr2+cMt7K6H9bG3SZNv4OFKWUiJovdXQM4R7oNIe5da1/UsTdjN2v8N/HcbusVpF17RxRMKcOBeq7BnqGSyM4QOtH0deIl8Q6IhjTIpQbo0pWEM9z6AYjN2ScSFtm2a0+3SbWS3xGK1/7+L3JHC+PaRm26yzIhDiWT6Mw5SG9E1VQ6etSf8bJEvfgoiy9deIjeI1oUEL5gWg92JvB2QXXfi1bQGZYy5AZ1AAM/owZ1qJueX0GZjoEwjwa83bsp8aEnp/BK5uA586+4BCND+9JBl4knCIQ5xfBtVa1NL3zV9xDScHFWEJCvVYX6SAuXVyDUw7aP7cvQBYvy+kXkKfqxV6tm/4PaeFrzmUvhTG/OHWxA2yoKZcSbbk5+vGgOwPRcnLUcUqCTpoRKLEJ6YcZHyjoPEbOs1FmpJtwWXNP7Wr4ZjKVY6kznBrqBxsyZtGfxT7TbthAMdCOjQ1HsIsTSuErARty+W2olSbr/9dnCCc2WeF05V8+8ymDzZQ+yx/EJgl98NAtxwBTByccyfr+JK+XV0Pf07NVaTvZPL3Qd1QSIK5JRrnYQuvE8Mh6VDC1kPy7/D5Lj05Wh5IxG7VluttoW7l5gtQ4YqAUs5bk8zi7CDi6g1Lsj+7KjJffUExvbiRVri41s7Ymfi7qYFv9ITJD4f6L3rQ/VNBLvCdjiTT1ib/YEHkg/n3o6+wag6KCDAmHhSoyCXhf0teTvtAQbxOpmbSEwwGw2y2/eDRvM7PoNNbT1d4jv7vIi4EH3yFx/Ep58iUcVZMz1eDl6DZ5+ruv5CzkmwnyfETFRFkI4n8sdWU6ii8gz6HWPFOILThD7DJs7cRsYp0GKWpYcsaqsQpSdtN+NPnbWH0jwzMpE5RYrfXJtsLFVQTbbhz6BJJEmuQo6poAIhfrGeFNQlv+yhJFR+U5pAyzi887H9jTPox1jVblObGyldZOVLWvh/zbMM2osE49wMi9aU69EreYvP/sXbSCGLP2VnLFq/rv/2XM/eBSI0qr6YoCWSTS2BatLgGeKWwuQi9LG3ESFwdUsKAml9PWc9/e3UZ9eJt/FHNFKdc3c/2jKkal2u458L7bon9VBu2nnt48o0Le4Qa5Il8e4Ux+FzyCXudlAjKh+QX5EY5J0jymxD9tO/YyBwP4wzrAiR91iA/fu8ULWArfEZJAM3X6Zj1KH1s+W7XJ/SSk3xw5USTWUJ+nRKz6ikKua2NAyRyzk35pfIndt0VymEOTGOixvi0ir/6FJygw5Q5McUGcPXI4pDr4BQen2P7g+lg+OQVk2BiJE/LrYXlHw== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: e39e00ea-8c35-43ec-faa0-08dc417396c1 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 02:33:08.9606 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WN03dc0SRsZ0g1YgG7jH/FNk/ewfFIrF81vVrop07LUsgzhEU3qycbFumn3sxQOfuJLTg0ecir8gXBOSaiM8fvSXNR4+LOv5B5SBoyPOuAs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB6056 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Shihong Wang The Rx queue ID on the core and on the port are not necessarily equal, for example, there are two RX queues on core0, queue0 and queue1, queue0 is the rx_queueid0 on port0 and queue1 is the rx_queueid0 on port1. The 'rte_eth_add_rx_callback()' function is based on the port registration callback function, so should be the RX queue ID on the port. Fixes: d04bb1c52647 ("examples/ipsec-secgw: use HW parsed packet type in poll mode") Cc: stable@dpdk.org Cc: Akhil Goyal Cc: Radu Nicolau Signed-off-by: Shihong Wang Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang --- examples/ipsec-secgw/ipsec-secgw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index a61bea400a..45a303850d 100644 --- a/examples/ipsec-secgw/ipsec-secgw.c +++ b/examples/ipsec-secgw/ipsec-secgw.c @@ -2093,10 +2093,10 @@ port_init(uint16_t portid, uint64_t req_rx_offloads, uint64_t req_tx_offloads, /* Register Rx callback if ptypes are not supported */ if (!ptype_supported && - !rte_eth_add_rx_callback(portid, queue, + !rte_eth_add_rx_callback(portid, rx_queueid, parse_ptype_cb, NULL)) { printf("Failed to add rx callback: port=%d, " - "queue=%d\n", portid, queue); + "rx_queueid=%d\n", portid, rx_queueid); }