From patchwork Mon Mar 11 01:54:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 138144 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5432C43C7F; Mon, 11 Mar 2024 02:54:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE3BE402D8; Mon, 11 Mar 2024 02:54:39 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100]) by mails.dpdk.org (Postfix) with ESMTP id DBC7340278; Mon, 11 Mar 2024 02:54:38 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dhCm87kC6MG+ne+XXTSqH/swL9zHg65fXcEhR3fdPbU9fHQb9jfMlVOhHrYEE+SsaCEWxyN0jZMzOG9GSCl+Wv+SNpB6KpJP+VnTUdGvHFjS8zKfFBY9X62MyyxBT0CN4eezpxhcm38+G6qnkRJcO4n5ltfeBQU9TwCcrd+wtV83HPzkiKBP3XSIPOtsQsUGSHteXxFT5rpgbdT5PB0ulW1MDY6gVyMiXWozKSG+zFGcmblDtv/8xO3/SxNyHz9guYK5bJ3c9fzJ8hMAnmHeSkl2g/PTp6qiBB0y2kd1jdYrPsOZXxrCbCIld7kum04y1NvgcjeiJd3qiapFWz6ImA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=26JL/NkCFqRViB9XSOwOZaRV8lZoea3FuXAVYSSbSqA=; b=ih9oJ4mwgd27bZP7GBT6pSeWH6WY833T89iQJEOgbPUwCtcv95OUAXLFAKgG02tYQqZRrlQkP/ZfMVnrHvRdCZbkRzsMV07PevJWOaxfop1ihDCwwZHnQrT9QJpPXFTSMBO5LbxQj0rsqjNTBwiAJtTwyWd2HX4Y24tQKew6Xuw2BIgccRV43VMa+5kWKAmnyZj5Rpw01lcNUpJxubQSV6MInf5DFfbiETT+p9XH2/8VpyFlxdhHQk15fiGvUSFh0qAC6O9lfPD0ND2wB68LYJFF8nhZDbfZ8ovsaQ7gW93lVomkb/3wiJ9j/1YUgVhfh1EVGShkVvywbSjyj3I/Ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=26JL/NkCFqRViB9XSOwOZaRV8lZoea3FuXAVYSSbSqA=; b=pYDY8cVq6CEUd6UUiDSbA6A58bjL508VmLjTXjtwq8OK7tIwXAV4XSLD9lddQT4/s4YxKAjuAuGkJ/0jBbtXnw+eUd38LTb9teAfbm3lBz8IxcFDc+Nq4Ar2mCF9LKIO7QARvTfXu9fSBrmEpsFyz6vbaVxOqKBQ+GqPA1qaIOc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by CH3PR13MB6724.namprd13.prod.outlook.com (2603:10b6:610:1e3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.35; Mon, 11 Mar 2024 01:54:35 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7339.035; Mon, 11 Mar 2024 01:54:35 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Qin Ke , Chaoyong He , stable@dpdk.org, Long Wu , Peng Zhang Subject: [PATCH] net/nfp: fix getting firmware VNIC version Date: Mon, 11 Mar 2024 09:54:14 +0800 Message-Id: <20240311015414.2514845-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 X-ClientProxiedBy: MW4PR03CA0293.namprd03.prod.outlook.com (2603:10b6:303:b5::28) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|CH3PR13MB6724:EE_ X-MS-Office365-Filtering-Correlation-Id: 723b3b82-9557-4495-daad-08dc416e33ed X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W6q4OaJt7kLjjAd7+w+BeVSuvuUzQ2qtuuuLqhlPxrqFx10+EXTpn1D3hV0b0IO4gjU5lpz4Ls62DDVPgYF6th7bSoNm8bGdIBlyrloAdeXjP6RjkAuuEkafo+xIZe7vJSrToIVZBORXzMp1+T3/yyCoYWKX1RYV69yIe+2JuobxhQns/ATjUApFqZVu0IRMvCoutuKVifFptd4XV6x7jnyH9HwYQJyawE3GQslOIg5dx/5iFqalU4dyCpAdKcyTzy6xcCmLgoU9Ak0qfZCL1Kf5Jd5SemXGyb9HNxN2OUVgjGVEcNfQ+uVALQBs5BOdo1dUXFMkH3EzzHPYjlsNLQXCjslMKOy74VQ/alevi5ZefQwvaLFTiQLPXv2IsISUMCFJ9rTKyZmPnBcG9KHK49KcfHhhBmXAm3XGlG+2iY4B7yRBdLw9W7gIZ1nI7LqquZgFZloALcxvba6b1zXMS1Qlno/f8usKY/0sLBznnEHbfojy1xeJcmTUbZAB1S8X/jSt0J16O8rn5swkWZMUzVDWDUVBpLXDBZUBzgUdihunu9qCyX7jchRyM/FVAFahvfLjrm/9GNSJXNqrTfRodVJtwslwZXU5tvt/1UAoqysjQPcCeBu78dcWDtL7+eboWQ/Ychu/hEu6WzLfUbD5HHF+jjiyorlZdrpPdFHWLNrL5gP07ylIRoK2m0loKZFEwjM62b8u3scoXvp4fB/tsw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(52116005)(1800799015)(376005)(38350700005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: KDynBpQaUGVFJ9Vv7N3C+qZR7SY1v7P/1oEOrN/7gYHBRM/f+OPj3GNaPoUTDL+mL7STWMK8R0AuLZXWBUxUjuaAlWZM+t9CtZ+ZRyzze8dSewE8gzK3t4t65p/4d/F/Lob2SXdZtMiriUQu4wkYWiYoDMNEYvJoM5wo1huhZwYsE3mFF00bYxmFA4x5Z+pMIuf0J0hR+r+i9GwYZpn+TOQP+mDsj2YphYsu3zO7ISPUcj+k5aPeTowA1Qu9mUr0IdrUDntblZnMkh/yiIA986dnfI8VBTYzBUChGDHpcKwlOIeM2WJ6UD/L8Cuk2J/1dX1WXQKdIfSjMi8iGCjEBSWQDyKnvDhG/jCAtyva5Hp0nLltBtbNumjqtsH4zmxy5X9j/QlomIGR/aYWiOiIXxeIxuaqgZaUIXtaFtR1NQv0KYmd9udQiX3VMtwO5szJKUPVjI1EWXZz0FpngWqdOn5dWTrbgMkeF14L4FU4+ugXUWuDfr3uLBueC5lmajXgbgCLKaZ8iPGvXz1QvhdueXYrDe3axDhjS/dx18NOUZNHhmZrs4lux2ocqYVtX/3y82FavJzE1hl3yhVrsvS8Y7XhkPe+yg+0k9mpMIcf7/0A9AVJbmayWs13a6lksUfJtCXUlt6f3ptlz5fctl6UTz98OHz5KFj1l6br8ZPgkw+w+CAoKpmAkS5R4/DgwCLd9KwmWH/ApwWZwnhJggkIJ76P5aX5FkX7oTQxPfijtsLGvnvlmcMdEePx5GqRsSuZO86/1WfDH+rP3Vp9ERkGI+MvfPdmFiGKarMzvGuiPxz32ikLMOsx+VPulQObMqhH2c63IkAp2C4eDAgZAkjCvoW+obbtKaA9UMOX6Iq1aPYstNVYulNV+DSCoVZrfuEQSh/0Jqz3jlzam8g3jbrrOtEXFQJUq5s7l8uSZ1KXzIxFKfVB9BSJzwR1g2HL9w0MdYPd9KkSVf5JBexkTtORzs680K9tBI35efi/dWOxCRnB5oeWwU9k5PdiAAKz9BPjeCH8cjLcH3emdTnFLA9OaBd2sbj1JHjBUSzS9I4xe/XiPDn2J8ZaVDX9T/Jwae/ikIwafdStoJa0WD5Ns7u3BQ+ulmewT4FYmuSzclg/yEZ2prkot6TH71YuUEfYGAo1fhbC6Wv0X3Xf1yjf+nHFWi6wcuqe8xitfPHw8nc9Ve4FhJtE5EumwkxUSPM76g2RArmecxeggFq6g7HkRLZjPB4o7NwnjtMw2i3NHgOA06UvBgK0hQqPQTlxA2RTNwpD7RHgqYi7GkOPuMWW9wbVgFLxk3OJXjHubSpNQS73rgJ+lFkYKWSNE7JkW+kzlc05rzfTjqcDBleuJjmbBE+hN0FMXIBkgZj/gEu8YaB7c4e3bCXy8jStSkEIZI7rZQk9V9YWV0FMFo4H6giRSpgIuTXnf4eCYB2c9+3OteJzn12ynj+wmmc1DJyZEYQ7EEQnWLFnM4WG1+N/+awg7LoMiVTWWahjtBLZVmk4+OQrvRviCytYueUV6zpP84LgHpfDzk6YlcPXZwqVBMYq8gLopTsRsIMTxuNV1D73Vr37jGkXiw+MXy9GQ8rl20i00sPCjSP4g8csOJ8C/L12nGuf8A== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 723b3b82-9557-4495-daad-08dc416e33ed X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 01:54:35.6641 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /4Xx/AfErJCAWqTBLPhGzdp0TN5pkWGg1ImXKFCbu/rs8FWWe4GPjz2dKZpfgv5RS/7LFxEGF3jLubm0wA0hP8qSdk7RwE06lLsCk+JgnTg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR13MB6724 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Qin Ke When getting firmware VNIC version, the logic for representor ports and other ports is inverse, fix it. Fixes: c4de52eca76c ("net/nfp: remove redundancy for representor port") Cc: Chaoyong He Cc: stable@dpdk.org Signed-off-by: Qin Ke Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_net_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c index 20e628bfd1..bd43925960 100644 --- a/drivers/net/nfp/nfp_net_common.c +++ b/drivers/net/nfp/nfp_net_common.c @@ -2155,7 +2155,7 @@ nfp_net_firmware_version_get(struct rte_eth_dev *dev, hw = nfp_net_get_hw(dev); - if (rte_eth_dev_is_repr(dev)) { + if (!rte_eth_dev_is_repr(dev)) { snprintf(vnic_version, FW_VER_LEN, "%d.%d.%d.%d", hw->ver.extend, hw->ver.class, hw->ver.major, hw->ver.minor);