From patchwork Fri Mar 1 05:20:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ma, WenwuX" X-Patchwork-Id: 137650 X-Patchwork-Delegate: bruce.richardson@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C49043BB1; Fri, 1 Mar 2024 06:34:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 417104025C; Fri, 1 Mar 2024 06:34:08 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mails.dpdk.org (Postfix) with ESMTP id 6347C400D5 for ; Fri, 1 Mar 2024 06:34:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709271246; x=1740807246; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=avC9YS0VEU6v1Tw8BkXQytmY2la9m5Cg+bRm0yXBq5I=; b=Fq8+h0YLxBtr4+3meSEwM8l5ftMRZhZfWRJjvqWPeRMr6zsi0Lb9sAS3 Mn2B+PMO6IqO8kSTxXewFZBpfcut+FVm7EmLUZWvzpToLMUTrPgtlqief iMEOt4ST9AALDGVOO2l8wIvBWvVLIAUG75dz64aHLSAIcepbYyD9qc7dO HCg11/N9pnGypTP2wf1o1VDDORzQa3gcbWPdDQ48qk6DvaMgP5H2n4NdJ S5JyQEuzFKdFuGgefiXV1wZFJnk4cEmeFlVwKXswU/Kfa1i/GGo18gr7P fTufUD0/6Y1IoMtrrgwdh+jpWDonV84Bt9L00XOIw6NhlyajAA53U6v/2 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10999"; a="3656930" X-IronPort-AV: E=Sophos;i="6.06,195,1705392000"; d="scan'208";a="3656930" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 21:33:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,195,1705392000"; d="scan'208";a="31265108" Received: from unknown (HELO localhost.localdomain) ([10.239.252.55]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 21:33:49 -0800 From: Wenwu Ma To: dev@dpdk.org Cc: songx.jiale@intel.com, Wenwu Ma Subject: [PATCH] net/ice: fix null pointer dereferences Date: Fri, 1 Mar 2024 13:20:29 +0800 Message-Id: <20240301052029.543989-1-wenwux.ma@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch fixes two null pointer dereferences detected by coverity scan. Coverity issue: 414096 Fixes: 6ccef90ff5d3 ("net/ice: support VSI level bandwidth config") Signed-off-by: Wenwu Ma --- drivers/net/ice/ice_tm.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c index fbab0b8808..e10ac855f9 100644 --- a/drivers/net/ice/ice_tm.c +++ b/drivers/net/ice/ice_tm.c @@ -616,7 +616,10 @@ static int ice_set_node_rate(struct ice_hw *hw, ICE_MAX_BW, rate); if (status) { - PMD_DRV_LOG(ERR, "Failed to set max bandwidth for node %u", tm_node->id); + if (tm_node != NULL) + PMD_DRV_LOG(ERR, "Failed to set max bandwidth for node %u", tm_node->id); + else + PMD_DRV_LOG(ERR, "Failed to set max bandwidth"); return -EINVAL; } @@ -630,7 +633,10 @@ static int ice_set_node_rate(struct ice_hw *hw, ICE_MIN_BW, rate); if (status) { - PMD_DRV_LOG(ERR, "Failed to set min bandwidth for node %u", tm_node->id); + if (tm_node != NULL) + PMD_DRV_LOG(ERR, "Failed to set min bandwidth for node %u", tm_node->id); + else + PMD_DRV_LOG(ERR, "Failed to set min bandwidth"); return -EINVAL; }