From patchwork Wed Feb 28 10:25:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Etelson X-Patchwork-Id: 137421 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5848343C21; Wed, 28 Feb 2024 11:26:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 42EE7410E7; Wed, 28 Feb 2024 11:26:16 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2081.outbound.protection.outlook.com [40.107.244.81]) by mails.dpdk.org (Postfix) with ESMTP id 971DC4113D for ; Wed, 28 Feb 2024 11:26:10 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gpSo/pYOkPlP9zdDnV7vMOaVrXFpbbjIMHvPT6R4CsBdO227jmB6FHS7uzmyMMuq9FA9Q7ef/Wf7/sPq6AOO2y5lIek6OOpu+h9p6MQuFc8qVCcv4mNZXOni123sZfHo0HR5SbzJnWrRz8CIFXnZH6L71urQjEDXAk6AoGHTffCTUnb7KxshDMNy/KmcqlWTpwp+8tjLBvdWsEc6H0Nysk/i+j3cSYWgzvPp+7JdqZJV09vB3qX3yWbkwEUcP4u4f3Lz64c6IvZrNBh8bcIZ7zDP6tyEB+p/90LijSnAaj4lmxUXEQ6hJIPri11vOxC+wxq0aUKMdz+BEwk/HHmWjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/NHocJFdwyH7kRXN3FYPhBnacIMi3VasUtxeVf2V30o=; b=CKWZ1jy8tyr3B+6mo4WfZFZjRt8OotGJ9af/GICC7dinUDle8C4H5wGqexkI0Jfj2T6WFsH8F0Xu0DjoYBRkvvAaVJyjBriDWcckMU+X2aE0xUUR2POAob9J71yHhISSheo08dqQ61U8Ldyu/ZafxfgGYXtOGdp/qhIdyYmyb6huacrOOr+RzNGhPrT24u4JxQdHv1pZtf+HFX+CyTYF/X4HzWRDE7VgBdehNNXm00GRwgKMqN28qFLdsuPug6YbSYR/aPZyTaZUl/BKYuv+4SCjQ4rQUU+oSpueTNEUjvdeEH0OmIBAl+AO3ggoeuCKFLA0pF3fh5eQTBHGSOaOCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/NHocJFdwyH7kRXN3FYPhBnacIMi3VasUtxeVf2V30o=; b=i+4KBnXwMGgGQ/MFsIXOSxWIPR0GyX3n/60eaEcwTFvvy30LNA5fkL6jVx3T/SdxRCyGD6hmrUAObIbIQQa/CxPHe7H8KFWuNbuyw2QB0k9BwRkRJUHKT6R6wu+ZE3bOHGGOPxn/RHJjPRxm8BlyrMH23iLgj5xHzuDc1XaeKtaQjExKZwJRSyDDt5t4wEwMZrubEm8ECawgebFZhOvK+KXU5NuNSrWFxD/W63Sh+U251UCQO9FUFwPl3BH4xfNf8zC2OY5HevrvBgL606vw+N3WIvHA9aVHKvrEjh8nzEypgjUb3vNgVTC+i3hS21f87OBJey3xjZnZUwR8X5o4+w== Received: from SJ0PR05CA0187.namprd05.prod.outlook.com (2603:10b6:a03:330::12) by MN2PR12MB4568.namprd12.prod.outlook.com (2603:10b6:208:260::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.39; Wed, 28 Feb 2024 10:26:07 +0000 Received: from SJ1PEPF00001CE3.namprd05.prod.outlook.com (2603:10b6:a03:330:cafe::6b) by SJ0PR05CA0187.outlook.office365.com (2603:10b6:a03:330::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.25 via Frontend Transport; Wed, 28 Feb 2024 10:26:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF00001CE3.mail.protection.outlook.com (10.167.242.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25 via Frontend Transport; Wed, 28 Feb 2024 10:26:06 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 28 Feb 2024 02:25:52 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Wed, 28 Feb 2024 02:25:49 -0800 From: Gregory Etelson To: CC: , , , Dariusz Sosnowski , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Matan Azrad Subject: [PATCH v2 1/4] net/mlx5: add resize function to ipool Date: Wed, 28 Feb 2024 12:25:23 +0200 Message-ID: <20240228102526.434717-2-getelson@nvidia.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240228102526.434717-1-getelson@nvidia.com> References: <20240202115611.288892-2-getelson@nvidia.com> <20240228102526.434717-1-getelson@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE3:EE_|MN2PR12MB4568:EE_ X-MS-Office365-Filtering-Correlation-Id: 48074558-16c6-4572-7974-08dc3847acbc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6/bhJ/b1349fkmXK9aZ88fBgVKPMoN0Qr0Ksj01NOjvpBhWQP6e25CmJYhqeqnvfH1PXMv7igAUhzHjZKy9Qy7w0FwkPodzhV1pSq7trjK/P3nTRZjw7seTy3L0BPh6ui1FxoAJQ6+NDhNJCrAC6EMEksovn6wPitz2KOCu7YZCXcSkxc3nWWU5mYr8swnojDJfZmCE0ozRDLeSnpU9DsPwZwAz1Q7auRaCGsW2Wn+4Whjjglr/YHnG1TC3p0/Nl0bSSV0vLG/rBRTD3Al+NScZkeOgUwABQQImkGyqx5ACShe1b6cj3sxJV62dzfIqL43cTwvMSe2p1kBSPhmLTkFVD7+AUKcCp3eQ4ms6uQGmspUfFXXKB58pdjSRknJZy49oWR79PZbS0G90Zs6ktV9mYzHUiMCTjgIx1C2GNUDmXzhUGErZ4ceqxtyPkvK8YbVMNY2kiy6M+df/Yvi2wMTx1HrZwnoj/6+DHVqU7L8I/JkNl94wATLHlgf1G1jNQvrOo03ZomBLzWAp0D1/iMWuPqZc78yIO6zKykWwspI2w8xwlRs++LW1HyZRXPGaaIXhOHJpGH7DdkhMAmy0+YmULunobBVPD1pcnfLwv5581b2w8GHgil44rXIib9MPzjembo4GWhoEju5pHA48PnzgPOcxqlIkkXZ++J2Iczv3stm8MhTTi1mbkIpQpxqrAEwEqOHUHxe9nLvILzpGBF+Gin/1JqC3KN7SxXVHvE54g44bWi15TdWZNx5KBDbJ3 X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(82310400014)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2024 10:26:06.9134 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 48074558-16c6-4572-7974-08dc3847acbc X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE3.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4568 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Maayan Kashani Before this patch, ipool size could be fixed by setting max_idx in mlx5_indexed_pool_config upon ipool creation. Or it can be auto resized to the maximum limit by setting max_idx to zero upon ipool creation and the saved value is the maximum index possible. This patch adds ipool_resize API that enables to update the value of max_idx in case it is not set to maximum, meaning not in auto resize mode. It enables the allocation of new trunk when using malloc/zmalloc up to the max_idx limit. Please notice the resize number of entries should be divisible by trunk_size. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_utils.c | 29 +++++++++++++++++++++++++++++ drivers/net/mlx5/mlx5_utils.h | 16 ++++++++++++++++ 2 files changed, 45 insertions(+) diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.c index 4db738785f..e28db2ec43 100644 --- a/drivers/net/mlx5/mlx5_utils.c +++ b/drivers/net/mlx5/mlx5_utils.c @@ -809,6 +809,35 @@ mlx5_ipool_get_next(struct mlx5_indexed_pool *pool, uint32_t *pos) return NULL; } +int +mlx5_ipool_resize(struct mlx5_indexed_pool *pool, uint32_t num_entries) +{ + uint32_t cur_max_idx; + uint32_t max_index = mlx5_trunk_idx_offset_get(pool, TRUNK_MAX_IDX + 1); + + if (num_entries % pool->cfg.trunk_size) { + DRV_LOG(ERR, "num_entries param should be trunk_size(=%u) multiplication\n", + pool->cfg.trunk_size); + return -EINVAL; + } + + mlx5_ipool_lock(pool); + cur_max_idx = pool->cfg.max_idx + num_entries; + /* If the ipool max idx is above maximum or uint overflow occurred. */ + if (cur_max_idx > max_index || cur_max_idx < num_entries) { + DRV_LOG(ERR, "Ipool resize failed\n"); + DRV_LOG(ERR, "Adding %u entries to existing %u entries, will cross max limit(=%u)\n", + num_entries, cur_max_idx, max_index); + mlx5_ipool_unlock(pool); + return -EINVAL; + } + + /* Update maximum entries number. */ + pool->cfg.max_idx = cur_max_idx; + mlx5_ipool_unlock(pool); + return 0; +} + void mlx5_ipool_dump(struct mlx5_indexed_pool *pool) { diff --git a/drivers/net/mlx5/mlx5_utils.h b/drivers/net/mlx5/mlx5_utils.h index 82e8298781..f3c0d76a6d 100644 --- a/drivers/net/mlx5/mlx5_utils.h +++ b/drivers/net/mlx5/mlx5_utils.h @@ -427,6 +427,22 @@ void mlx5_ipool_flush_cache(struct mlx5_indexed_pool *pool); */ void *mlx5_ipool_get_next(struct mlx5_indexed_pool *pool, uint32_t *pos); +/** + * This function resize the ipool. + * + * @param pool + * Pointer to the index memory pool handler. + * @param num_entries + * Number of entries to be added to the pool. + * This number should be divisible by trunk_size. + * + * @return + * - non-zero value on error. + * - 0 on success. + * + */ +int mlx5_ipool_resize(struct mlx5_indexed_pool *pool, uint32_t num_entries); + /** * This function allocates new empty Three-level table. *