From patchwork Tue Feb 20 08:49:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Mattias_R=C3=B6nnblom?= X-Patchwork-Id: 136894 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F14143B51; Tue, 20 Feb 2024 09:57:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4FCBB40DD8; Tue, 20 Feb 2024 09:57:14 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2040.outbound.protection.outlook.com [40.107.20.40]) by mails.dpdk.org (Postfix) with ESMTP id 6ECB540691 for ; Tue, 20 Feb 2024 09:57:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wg4Fk2dN6VZzgVk26pzDdxtU38NBwiKMTxP+YcUJhAsyQEFlvrT8yr1LauwLkDaGRRaeiIZIJSXDuFBbS7cC3ec1C5AIGjYK1s7lKrEu0ZqR9DcL/qkZpo/qzjUAamdC5gVgI7OW2VfOX9nMFr4yOz7mBTWA+Nvt/gdMVOldYpgIYiPxSso6f6sLk0kxHeW2JLH3TqlNTOU5N+ao7kXhXlm2GD2OiFE7TM4sI6c5oXoAaiIOMv56mZb3Pawju/QCNvNMDf87ybN8TpvHnsOjNIZOp2w8upnpZHUPdNSyG6HwHbKP159h05UNqQkNPbsNFJc/613NHqM30PG4FHZnxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XtXEWg+/T4E4itTAs6atvniqRZGc93gwtZptQTWWciM=; b=GwO1hPcAYfp9+7cqZBOaxPZC+D/tcl0wDqTeL7szRcMFRcv/dAUsN1IHO8vQic/Urluh3z8STWxZVHvtk/jNZr26MFjsb7qkHVdX0gTYI95wKQ6Yp3CiVkXH7DEwhtD4dQ0iuLt6w98Zb6GODQYW3c8bvxCnkfp/7hScei3aUXYZihAGBUQp2j+AYBGDTHJ2rGlnnhQf+4mmtncGknEjiAe7HZfe5GQvdoHB+ASixvl8tzSVbLcA7EGP0RdKpj/BGz1+FIA/gXprXxi9NOO1rRnCCwFJhDZjd8dTto8AnamO4bGQU3c3vbLFvtHMLbobfXF2T06vAZIZVtplPHeOCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XtXEWg+/T4E4itTAs6atvniqRZGc93gwtZptQTWWciM=; b=tKDu4zqqXTQyQiMdFru39vL1pPErsK/NY59GLk7kdcny1oD+CDg4quN12En4oYPgz1i3ff3IKIUNXKci8nxVzJGqN8bh6t4YZpE3RsSAtnW2XkDL4Z/BLeJH0kSYUuCu4ec89QECWKYYyYZazvdijSn+hDUzVfaOAQxS5kdGxWX6WKZqVOpGMYGtISFfxVUDaPLSmF/DS9T4ddPNr2J22Beuif/5h3YSg2ymX/3KcAfYxjPhiR8Br1TYHLAMJs74ZE9gppUuTtnTgyZepi8nPLmGIPXkbnexN6fipYzaGuw3wv7IftPTf5Iyg/WUUwkx34KhVH5NwHBw50yCmvk9lw== Received: from AS9PR06CA0151.eurprd06.prod.outlook.com (2603:10a6:20b:45c::8) by GVXPR07MB10109.eurprd07.prod.outlook.com (2603:10a6:150:123::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.26; Tue, 20 Feb 2024 08:57:08 +0000 Received: from AMS0EPF000001B7.eurprd05.prod.outlook.com (2603:10a6:20b:45c:cafe::ad) by AS9PR06CA0151.outlook.office365.com (2603:10a6:20b:45c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.39 via Frontend Transport; Tue, 20 Feb 2024 08:57:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by AMS0EPF000001B7.mail.protection.outlook.com (10.167.16.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25 via Frontend Transport; Tue, 20 Feb 2024 08:57:07 +0000 Received: from seliicinfr00050.seli.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.67) with Microsoft SMTP Server id 15.2.1258.12; Tue, 20 Feb 2024 09:57:07 +0100 Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100]) by seliicinfr00050.seli.gic.ericsson.se (Postfix) with ESMTP id 506951C006A; Tue, 20 Feb 2024 09:57:07 +0100 (CET) From: =?utf-8?q?Mattias_R=C3=B6nnblom?= To: CC: , =?utf-8?q?Morten_Br=C3=B8rup?= , Stephen Hemminger , =?utf-8?q?Mattias_R=C3=B6nn?= =?utf-8?q?blom?= Subject: [RFC v3 6/6] eal: keep per-lcore power intrinsics state in lcore variable Date: Tue, 20 Feb 2024 09:49:08 +0100 Message-ID: <20240220084908.488252-7-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240220084908.488252-1-mattias.ronnblom@ericsson.com> References: <20240219094036.485727-2-mattias.ronnblom@ericsson.com> <20240220084908.488252-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS0EPF000001B7:EE_|GVXPR07MB10109:EE_ X-MS-Office365-Filtering-Correlation-Id: 21ab12c7-2051-4b53-af83-08dc31f1eaf5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lPULQ4dcRyupeCQ1f8z+D4WmMqPz1QfIz2/ZDCnZwLRUWXkzISCPZy8dXcoQx8YbcE3hhUeDFo/Ma82TXlzDFUmB2TEbmjbrLTbok9wzsKqNBkf62LLVQZj72NfAyQZs+uHtUG/rcg0b/wk6lnAcsSMhAEKbZjStRmZYM3fAlGbs0MI9bp3Z+9IWHy8uZ/UEkFopsAY7E2tiRLc2XdbQd1DaCs5cS4i53k1XGLnoYSue+XeC9EG7cygyJ55KtWCwtcLBbUb8n3YI4B72QDIfFo7TjZtQjeHIaUH3wXMONQ9oQfKPqPjOrVnk0Vd4TMRQrqAa7+qXKuYxIbrul/uyJQZbJmIwQphLF9kPcNogHn3rxigyD6Ch2Qp6lRxI744QdxYKES7WtuXDr5tEvR2QbOGvQKqrkM85KiAOnKUgzPz7kxmj+VEXvBROjH91car2MSZ2rNyDDvTwgVbBgZp28M6OzaPSNHZDKzjlTcdoNE7fQGhwBDn9DD/KPWq9EZONJ0udYQUlwCYqL9ut2Qnn8xhIFi6CySyYjFGxyl5DKJUMqgV0IL2w9dA8VbYmiPzV+/zxfrchjdBDZm1EPxzPIMBFJH/B9bwuHjzgPb8cQWL0mEssxAoc9j2ZiWo/fA2iofG/NEqGQrMtk0IzkjUzXA== X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230031)(36860700004)(46966006)(40470700004); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 08:57:07.7991 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 21ab12c7-2051-4b53-af83-08dc31f1eaf5 X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001B7.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR07MB10109 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Keep per-lcore power intrinsics state in a lcore variable to reduce cache working set size and avoid any CPU next-line-prefetching causing false sharing. Signed-off-by: Mattias Rönnblom --- lib/eal/x86/rte_power_intrinsics.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/lib/eal/x86/rte_power_intrinsics.c b/lib/eal/x86/rte_power_intrinsics.c index 532a2e646b..f4659af77e 100644 --- a/lib/eal/x86/rte_power_intrinsics.c +++ b/lib/eal/x86/rte_power_intrinsics.c @@ -4,6 +4,7 @@ #include #include +#include #include #include @@ -12,10 +13,14 @@ /* * Per-lcore structure holding current status of C0.2 sleeps. */ -static struct power_wait_status { +struct power_wait_status { rte_spinlock_t lock; volatile void *monitor_addr; /**< NULL if not currently sleeping */ -} __rte_cache_aligned wait_status[RTE_MAX_LCORE]; +}; + +RTE_LCORE_VAR_HANDLE(struct power_wait_status, wait_status); + +RTE_LCORE_VAR_INIT(wait_status); /* * This function uses UMONITOR/UMWAIT instructions and will enter C0.2 state. @@ -170,7 +175,7 @@ rte_power_monitor(const struct rte_power_monitor_cond *pmc, if (pmc->fn == NULL) return -EINVAL; - s = &wait_status[lcore_id]; + s = RTE_LCORE_VAR_LCORE_PTR(lcore_id, wait_status); /* update sleep address */ rte_spinlock_lock(&s->lock); @@ -262,7 +267,7 @@ rte_power_monitor_wakeup(const unsigned int lcore_id) if (lcore_id >= RTE_MAX_LCORE) return -EINVAL; - s = &wait_status[lcore_id]; + s = RTE_LCORE_VAR_LCORE_PTR(lcore_id, wait_status); /* * There is a race condition between sleep, wakeup and locking, but we @@ -301,8 +306,8 @@ int rte_power_monitor_multi(const struct rte_power_monitor_cond pmc[], const uint32_t num, const uint64_t tsc_timestamp) { - const unsigned int lcore_id = rte_lcore_id(); - struct power_wait_status *s = &wait_status[lcore_id]; + struct power_wait_status *s = RTE_LCORE_VAR_PTR(wait_status); + uint32_t i, rc; /* check if supported */