[2/6] app/testpmd: add modify IPv4 next protocol command line

Message ID 20240206121736.27391-2-viacheslavo@nvidia.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series [1/6] ethdev: add modify IPv4 next protocol field |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Slava Ovsiienko Feb. 6, 2024, 12:17 p.m. UTC
  Add new modify field action type string: "ipv4_proto".

Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
 app/test-pmd/cmdline_flow.c | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Ori Kam Feb. 6, 2024, 1:03 p.m. UTC | #1
Hi Slava

> -----Original Message-----
> From: Slava Ovsiienko <viacheslavo@nvidia.com>
> Sent: Tuesday, February 6, 2024 2:18 PM
> Subject: [PATCH 2/6] app/testpmd: add modify IPv4 next protocol command
> line
> 
> Add new modify field action type string: "ipv4_proto".
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
>  app/test-pmd/cmdline_flow.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 4062879552..03b418a5d8 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -962,6 +962,7 @@ static const char *const modify_field_ids[] = {
>  	"geneve_opt_type", "geneve_opt_class", "geneve_opt_data",
> "mpls",
>  	"tcp_data_off", "ipv4_ihl", "ipv4_total_len", "ipv6_payload_len",
>  	"random",
> +	"ipv4_proto",
>  	NULL
>  };
> 
> --
> 2.18.1

Acked-by: Ori Kam <orika@nvidia.com>
Best,
Ori
  
Dariusz Sosnowski Feb. 7, 2024, 11:34 a.m. UTC | #2
> -----Original Message-----
> From: Ori Kam <orika@nvidia.com>
> Sent: Tuesday, February 6, 2024 14:03
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Raslan Darawsheh
> <rasland@nvidia.com>; Dariusz Sosnowski <dsosnowski@nvidia.com>
> Subject: RE: [PATCH 2/6] app/testpmd: add modify IPv4 next protocol
> command line
> 
> Hi Slava
> 
> > -----Original Message-----
> > From: Slava Ovsiienko <viacheslavo@nvidia.com>
> > Sent: Tuesday, February 6, 2024 2:18 PM
> > Subject: [PATCH 2/6] app/testpmd: add modify IPv4 next protocol
> > command line
> >
> > Add new modify field action type string: "ipv4_proto".
> >
> > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> > ---
> >  app/test-pmd/cmdline_flow.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> > index 4062879552..03b418a5d8 100644
> > --- a/app/test-pmd/cmdline_flow.c
> > +++ b/app/test-pmd/cmdline_flow.c
> > @@ -962,6 +962,7 @@ static const char *const modify_field_ids[] = {
> >  	"geneve_opt_type", "geneve_opt_class", "geneve_opt_data", "mpls",
> >  	"tcp_data_off", "ipv4_ihl", "ipv4_total_len", "ipv6_payload_len",
> >  	"random",
> > +	"ipv4_proto",
> >  	NULL
> >  };
> >
> > --
> > 2.18.1
> 
> Acked-by: Ori Kam <orika@nvidia.com>
Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>

Best regards,
Dariusz Sosnowski
  

Patch

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 4062879552..03b418a5d8 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -962,6 +962,7 @@  static const char *const modify_field_ids[] = {
 	"geneve_opt_type", "geneve_opt_class", "geneve_opt_data", "mpls",
 	"tcp_data_off", "ipv4_ihl", "ipv4_total_len", "ipv6_payload_len",
 	"random",
+	"ipv4_proto",
 	NULL
 };