From patchwork Mon Feb 5 17:43:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136405 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BA4C43A3D; Mon, 5 Feb 2024 19:05:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 186A6427E8; Mon, 5 Feb 2024 19:04:02 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 8C33D41132 for ; Mon, 5 Feb 2024 19:03:55 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1d72f71f222so37530245ad.1 for ; Mon, 05 Feb 2024 10:03:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1707156235; x=1707761035; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=venPue0YKmgFqmTkb3A+szF8IVhNfbQaBZV5vfYyiy4=; b=wZAv5sh+Gd4YvwuyEpUUmT3CtLcyllD9hCTrVPnoHfAJ5S2l57ZPomO+QC7Cdi/JXf iZBDZWoal8SZx7Oz2QreClqOZUmB/rw/3yvQQRx3zdxSgYwN8H2xZ33j2YTwuktdYw/A QBcA0hezq22XgILe2y1QUrHIdKtRgp3TWIBSihNG7/WcvHEkatbQgSFAkVMDm+q7RxUO ZBY8pJFfhDIq5GQrMQP8wik+DipYWd6lnLMAJADeuhRWmMN35gqjsBvSYzYctk3TYbOD BVL+6kzCrQS62MlH+WkBDmUTSZxzgvVyLku8ubo3DGu6PuImgZMoE9xXV4CxBzwy+9gT u2DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707156235; x=1707761035; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=venPue0YKmgFqmTkb3A+szF8IVhNfbQaBZV5vfYyiy4=; b=EWCm/6YHXAemDwteKw8IDPsgKvcSi31un1ocg7aphyKDLFMPWGRhf8x+8zighbwNdV zoracP7gR0LDpzf43fx1xt6saGKU3O5fF+xNzHBn+SrsWKDIjFIjsnlhDlHM+avjSVuQ Dx/dcLx3Sf39Hb//yUevxJC6I08FD2TNjJXmwMzcWNSoDHDuF7SduSQvQliCradyiOIC RIit/EvKHeH+BDVhbNDl5+xX6Pw1uZsOHckFsVEd0Pe+9HiKXNJC3m+eXEtv+cVudQic Iwe3jfoslYdbHIqalRovKGIw+1mRPYvpizvkIi8dONONRunpK5vjiVfycilhQjLKySQV uSLw== X-Gm-Message-State: AOJu0YzzuSnaBYLEbNl+d481k6WqF1+ML/gK98XDT29ut/peZTd+IUfp KhxgMwvrVMCQz8Pzl1u4Sm13nM6hiqw3QLR+Xm4T0ZaWuX2Mw9IC6pxZYa5rY5rKsMcZPyhV5o0 AkIQ= X-Google-Smtp-Source: AGHT+IHEgyoedR3OMk42gXPTUT1d1uzyErdegPMT31igivisZpdDKyfVYn9bf6087l9MUK8ENp8htw== X-Received: by 2002:a17:903:2782:b0:1d9:a674:aa77 with SMTP id jw2-20020a170903278200b001d9a674aa77mr242862plb.24.1707156234783; Mon, 05 Feb 2024 10:03:54 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWf2uwE0rDa7I8+ds7efKnlKv/jOJRfPv2Efb4xXhJmvimq97XkF7j+NkEHzqQ+kNHD04e/pTcEu8jIqVjk84LaOp0QlAa0bMzuXdyzuOhbrva9HRpZ3LDdgvr/ffOjEAez1Rl/pNqjPUEorowvSWkOUxpofFjQHhiR+rOGR0BZ+aI5P6uoDbg0bq6E Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id x8-20020a170902b40800b001d9b0a15bbfsm144867plr.262.2024.02.05.10.03.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 10:03:54 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao Subject: [PATCH v9 18/23] cnxk: replace term sanity Date: Mon, 5 Feb 2024 09:43:46 -0800 Message-ID: <20240205180328.131019-19-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240205180328.131019-1-stephen@networkplumber.org> References: <0230331200824.195294-1-stephen@networkplumber.org> <20240205180328.131019-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Do not use non-inclusive naming. Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_nix_tm_ops.c | 2 +- drivers/common/cnxk/roc_npa.c | 4 ++-- drivers/net/cnxk/cnxk_ethdev.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_tm_ops.c b/drivers/common/cnxk/roc_nix_tm_ops.c index e1cef7a670b6..6060dba0d799 100644 --- a/drivers/common/cnxk/roc_nix_tm_ops.c +++ b/drivers/common/cnxk/roc_nix_tm_ops.c @@ -527,7 +527,7 @@ roc_nix_tm_hierarchy_disable(struct roc_nix *roc_nix) node->flags &= ~NIX_TM_NODE_ENABLED; } - /* Verify sanity of all tx queues */ + /* Verify all tx queues */ for (i = 0; i < sq_cnt; i++) { sq = nix->sqs[i]; if (!sq) diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c index 6c14c499019a..5e38ecf0414e 100644 --- a/drivers/common/cnxk/roc_npa.c +++ b/drivers/common/cnxk/roc_npa.c @@ -458,7 +458,7 @@ npa_aura_pool_pair_alloc(struct npa_lf *lf, const uint32_t block_size, char name[PLT_MEMZONE_NAMESIZE]; const struct plt_memzone *mz; - /* Sanity check */ + /* argument checks */ if (!lf || !block_size || !block_count || !pool || !aura || !aura_handle) return NPA_ERR_PARAM; @@ -1096,7 +1096,7 @@ npa_dev_init(struct npa_lf *lf, uintptr_t base, struct mbox *mbox) uint8_t aura_sz; int rc; - /* Sanity checks */ + /* Input checks */ if (!lf || !base || !mbox) return NPA_ERR_PARAM; diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c index 5e11bbb017ea..798567592efe 100644 --- a/drivers/net/cnxk/cnxk_ethdev.c +++ b/drivers/net/cnxk/cnxk_ethdev.c @@ -636,7 +636,7 @@ cnxk_nix_rx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t qid, struct rte_mempool *lpb_pool = mp; struct rte_mempool *spb_pool = NULL; - /* Sanity checks */ + /* input checks */ if (rx_conf->rx_deferred_start == 1) { plt_err("Deferred Rx start is not supported"); goto fail; @@ -1205,7 +1205,7 @@ cnxk_nix_configure(struct rte_eth_dev *eth_dev) rc = -EINVAL; - /* Sanity checks */ + /* baseline checks */ if (rte_eal_has_hugepages() == 0) { plt_err("Huge page is not configured"); goto fail_configure;