From patchwork Sat Feb 3 04:11:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136372 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00C7243A57; Sat, 3 Feb 2024 05:14:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 223B542EDC; Sat, 3 Feb 2024 05:13:47 +0100 (CET) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id 9B93542EBF for ; Sat, 3 Feb 2024 05:13:38 +0100 (CET) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1d7881b1843so23930645ad.3 for ; Fri, 02 Feb 2024 20:13:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933618; x=1707538418; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IliaEP2TEKKFe31xugoOmaiAaNmKUbc7ILbkzWi/uR4=; b=ZheOS06X14VM0545TadRv4dpwEDjPVPNuTuwGjGXYcAK46Z2G3H7oTlq4eJS9WARXk e1dcPkAiVXH3E56yUrFAa/mWKVpin8E26K4n0v5FMNP3JMBVogkZuAqyc14IGv5cmukx M4V7DZ7Pa8tjIXhWYavdK5IgsVKJUNEhNEdmv+9qE5Mfx4DwINhHXJVpFQ1YWJNf4yVp sCZhPed3jV3JPB1mP4eW+pizprmNrvUCKZ4/SoHLGOWWiIkDLy036/ZlDMoEksyvfn/K qvLeVNclHnJT+6wO2kf8GmjKQINPGrwNe2BaUF45Vmps61gHb1ugS5g7zhtMpGUNwyOv JnVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933618; x=1707538418; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IliaEP2TEKKFe31xugoOmaiAaNmKUbc7ILbkzWi/uR4=; b=RyshDh0Tf0Zl+sjtLl7Qnl8oGNKH4kCK+LAjG5vB2qy2Nz56rH04TM6XB2D4v4FLG9 o6eE6s+jVN1KUJMw78saeEMorL79C/E9k2by5s3CaJryKd9i8O1dysjSmTCTWqloOymR 80QfX/3sfUbyZL7aJMGTDcFe/VXgaj02qzHpt2FjZPdM49CTJDd9vjjhNUZUNYMhNde2 /R5jg0hIECHSoLRxZJugXHx43m6RSVu1hxwlOEaL/JJPlqSlDFAUQgY+mxviTd4FXZWA MJi6NL1OaOZuoiIGaBuSZAnGG5p2SyCZ6ZTK+opsxRsstHt/Sf09RhKHgKToplmzmuJa MVQw== X-Gm-Message-State: AOJu0YyuPTmIwemtVzHbfuv7KbbWlkFFLKco/XXpUY0DBi9gOsh/GEln 8fRnpL/lB4/q/vkVjUHhpvSY+MYkUOG6EOmrbeUIg0OrfoDUHyyO+LKJvDGMWn1aa/oykg7nL5X TUmI= X-Google-Smtp-Source: AGHT+IFc0zYnHrgOlimmo1g7t8oCmdSVL5OI8Zv/a3oofHoxVnFJyvzXfPDJoSN39Q7xk6RaJYUfuw== X-Received: by 2002:a17:902:d4d2:b0:1d9:55b:6a17 with SMTP id o18-20020a170902d4d200b001d9055b6a17mr4399645plg.18.1706933617859; Fri, 02 Feb 2024 20:13:37 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWWAZjQhKvTb22gYFNLJ1Hu78oTUj++7k7ywP54XshSEo4MGd+hkC8g86GGRtoKaY0/fk2CB5amnONrAssT6B2aJV4= Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.13.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:13:37 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jerin Jacob Subject: [PATCH v7 17/19] event/skeleton: replace logtype PMD with dynamic type Date: Fri, 2 Feb 2024 20:11:50 -0800 Message-ID: <20240203041230.285599-18-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041230.285599-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The skeleton is supposed to match current best practices. Change it to use dynamic logtype. Signed-off-by: Stephen Hemminger --- drivers/event/skeleton/skeleton_eventdev.c | 4 ++-- drivers/event/skeleton/skeleton_eventdev.h | 8 ++++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/event/skeleton/skeleton_eventdev.c b/drivers/event/skeleton/skeleton_eventdev.c index 7df032b7daa1..848b3be82c40 100644 --- a/drivers/event/skeleton/skeleton_eventdev.c +++ b/drivers/event/skeleton/skeleton_eventdev.c @@ -457,8 +457,7 @@ skeleton_eventdev_probe(struct rte_vdev_device *vdev) const char *name; name = rte_vdev_device_name(vdev); - RTE_LOG(INFO, PMD, "Initializing %s on NUMA node %d\n", name, - rte_socket_id()); + PMD_DRV_LOG(INFO, "Initializing %s on NUMA node %d", name, rte_socket_id()); return skeleton_eventdev_create(name, rte_socket_id(), vdev); } @@ -479,3 +478,4 @@ static struct rte_vdev_driver vdev_eventdev_skeleton_pmd = { }; RTE_PMD_REGISTER_VDEV(EVENTDEV_NAME_SKELETON_PMD, vdev_eventdev_skeleton_pmd); +RTE_LOG_REGISTER_DEFAULT(skeleton_eventdev_logtype, INFO); diff --git a/drivers/event/skeleton/skeleton_eventdev.h b/drivers/event/skeleton/skeleton_eventdev.h index 9193f45f4782..9c1ed4ec5755 100644 --- a/drivers/event/skeleton/skeleton_eventdev.h +++ b/drivers/event/skeleton/skeleton_eventdev.h @@ -8,9 +8,12 @@ #include #include +extern int skeleton_eventdev_logtype; + #ifdef RTE_LIBRTE_PMD_SKELETON_EVENTDEV_DEBUG #define PMD_DRV_LOG(level, fmt, args...) \ - RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args) + rte_log(RTE_LOG_ ## level, skeleton_eventdev_logtype, \ + "%s(): " fmt "\n", __func__, ## args) #define PMD_DRV_FUNC_TRACE() PMD_DRV_LOG(DEBUG, ">>") #else #define PMD_DRV_LOG(level, fmt, args...) do { } while (0) @@ -18,7 +21,8 @@ #endif #define PMD_DRV_ERR(fmt, args...) \ - RTE_LOG(ERR, PMD, "%s(): " fmt "\n", __func__, ## args) + rte_log(RTE_LOG_ERR, skeleton_eventdev_logtype, \ + "%s(): " fmt "\n", __func__, ## args) struct skeleton_eventdev { uintptr_t reg_base;