From patchwork Fri Jan 5 22:28:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135767 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB1EC432AF; Fri, 5 Jan 2024 23:29:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A46E04067C; Fri, 5 Jan 2024 23:29:23 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 466FF40608 for ; Fri, 5 Jan 2024 23:29:21 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1d4c27cd502so256255ad.0 for ; Fri, 05 Jan 2024 14:29:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1704493760; x=1705098560; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oHHRZ/j+OCFdnV0SJbRo04U6hX3EuEMvbdmx20NspBs=; b=1oUt4i4ihZB84hmrQKkv8g06RuxVV7LcHQzY/h0sgWGD0zze1eJe++knOADvExgWRx TjxFqKzlv8epAPibPGhKWoVTiuhgMnYD5W90GC1WObrTikVILXS58Nx07o43nl+6txAT G8LHl7P3a1pPEDMUCvNmvGhqjiA9d32uwWXHZzTmt1166UoOcjLnuo7oJig+PW9jrNbx dwbWulLL8S8Awcw/Tq4o7VrzoBAFi1mY3eIFBVAFAMXDxpKg3rljKTsCmfWHnbLKWdzq l2gcrx6mbCdbxdBlUl5qqG2S1tpPQ/X5hVPUl/w3mX6djFR6n8VfVC8O5rbmnAXHVm99 BDlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704493760; x=1705098560; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oHHRZ/j+OCFdnV0SJbRo04U6hX3EuEMvbdmx20NspBs=; b=BphEKY+70dgd7eQRZCzfHaNxy5z1mrb37d9DbCgmZGyluEQW9I5C7gpMk4F7jYpLZn MC+3uijL1YXGseWuarYb3e1za2hyERnP/Oqmd4yZBBqRUp7zMyQ1UipL6K8vcYFJ9nXj PIDpOGKPKZJpq8O7ErQ3M/ODWS0gRl5u+aXShu07TEgmKFEvUsw5Y8vYYaH7SEtJXoYX DFIGwgftvJC44pUaoIidhTeXchviFf5+nBGumKfFDv6WnZlWlXeMVHxUD5AHnSE6FZ5u 4ebi2YYcWwZrY4IyoYCXXy7WryhX7NyeWm/49OpblcbCL0c9u+AxQzqVBhQ2gFuYNwWh +SuQ== X-Gm-Message-State: AOJu0YzRnEnPDamLZGVAzFr+3vTgNTLKckuu1avx0bjBRTMisSO9QYxJ ryj1eTZBwepeOpjOQjx3t/DZ/ot8ivKh/m8AwcPUfyQduFo= X-Google-Smtp-Source: AGHT+IEV5Go8JL+2i8ecezs37gQz/HjwVESMm9Z6Ljw5FHidH6posEU8ly87X3vkMwAj2OIn93Sb4A== X-Received: by 2002:a17:902:a384:b0:1d4:2f1c:825a with SMTP id x4-20020a170902a38400b001d42f1c825amr136185pla.102.1704493760745; Fri, 05 Jan 2024 14:29:20 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id b11-20020a170902d50b00b001d3e2578e66sm1871132plg.243.2024.01.05.14.29.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jan 2024 14:29:20 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [RFC 2/5] tap: remove unnecessary bzero() calls in bpf api Date: Fri, 5 Jan 2024 14:28:08 -0800 Message-ID: <20240105222909.139674-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240105222909.139674-1-stephen@networkplumber.org> References: <20240105222909.139674-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The structures are already fully initialized, bzero() or memset is redundant. Signed-off-by: Stephen Hemminger --- drivers/net/tap/tap_bpf_api.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/tap/tap_bpf_api.c b/drivers/net/tap/tap_bpf_api.c index a6adec855dda..d176da0802eb 100644 --- a/drivers/net/tap/tap_bpf_api.c +++ b/drivers/net/tap/tap_bpf_api.c @@ -120,7 +120,6 @@ static int bpf_load(enum bpf_prog_type type, { union bpf_attr attr = {}; - bzero(&attr, sizeof(attr)); attr.prog_type = type; attr.insn_cnt = (__u32)insns_cnt; attr.insns = ptr_to_u64(insns); @@ -153,7 +152,6 @@ int tap_flow_bpf_rss_map_create(unsigned int key_size, { union bpf_attr attr = {}; - bzero(&attr, sizeof(attr)); attr.map_type = BPF_MAP_TYPE_HASH; attr.key_size = key_size; attr.value_size = value_size; @@ -181,8 +179,6 @@ int tap_flow_bpf_update_rss_elem(int fd, void *key, void *value) { union bpf_attr attr = {}; - bzero(&attr, sizeof(attr)); - attr.map_type = BPF_MAP_TYPE_HASH; attr.map_fd = fd; attr.key = ptr_to_u64(key);