From patchwork Wed Jan 3 07:47:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhichao Zeng X-Patchwork-Id: 135701 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F8FC43807; Wed, 3 Jan 2024 08:37:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8784240685; Wed, 3 Jan 2024 08:37:37 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 833B140689 for ; Wed, 3 Jan 2024 08:37:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704267455; x=1735803455; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=VTui1t5brGXeeuunmjmEpmKHoGrMplQ8wSzJUy++324=; b=RR602aafNfxOLNQ6twCRXUWLHFNTnpf3OCneRVWM0llofzeCPQ1Vc6S4 +/JZAf8thoiV7lL2TEY9bfJdbz4EN9ba0jG/SGgVPmdIUgmMwWBPJH9WA PAipBRx6kx+ircs2ZOsVwc/kJ+gMJTEJuGrNw+YxnWIekU6mMHcbHxXv0 nKpFkXIv8sLSNcD4Rqzv/tcNjYN3h0MgQRIU9kO3U9d9Zgs8I8oo6bbGG 8eGEZ/6SBYJzWptwNdPuK00yTvwLSZqAzQwm8cRzxCxBSsVpJ0TZ/9zXK xInyo6iP03yPUSZM0TiLKfudxUbtlK0CTfpaO98YqxiKWb64/Ady9d+VV w==; X-IronPort-AV: E=McAfee;i="6600,9927,10941"; a="387428608" X-IronPort-AV: E=Sophos;i="6.04,327,1695711600"; d="scan'208";a="387428608" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2024 23:37:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10941"; a="779913082" X-IronPort-AV: E=Sophos;i="6.04,327,1695711600"; d="scan'208";a="779913082" Received: from unknown (HELO zhichao-dpdk..) ([10.239.252.103]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2024 23:37:31 -0800 From: Zhichao Zeng To: dev@dpdk.org Cc: qi.z.zhang@intel.com, Zhichao Zeng , Simei Su , Wenjun Wu , Qiming Yang , Yuying Zhang , Beilei Xing , Jingjing Wu Subject: [PATCH v6 3/3] net/iavf: add Tx LLDP command Date: Wed, 3 Jan 2024 15:47:21 +0800 Message-Id: <20240103074721.832061-4-zhichaox.zeng@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240103074721.832061-1-zhichaox.zeng@intel.com> References: <20231228032211.1127554-1-zhichaox.zeng@intel.com> <20240103074721.832061-1-zhichaox.zeng@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch adds an IAVF testpmd command "set tx lldp on" which will register an mbuf dynfield IAVF_TX_LLDP_DYNFIELD to indicate the need to test transmit LLDP packet. It needs to stop and restart Tx port to select correct Tx path. Signed-off-by: Zhichao Zeng --- doc/guides/nics/intel_vf.rst | 17 +++++++ drivers/net/iavf/iavf_testpmd.c | 81 +++++++++++++++++++++++++++++++++ drivers/net/iavf/meson.build | 3 ++ 3 files changed, 101 insertions(+) create mode 100644 drivers/net/iavf/iavf_testpmd.c diff --git a/doc/guides/nics/intel_vf.rst b/doc/guides/nics/intel_vf.rst index ad08198f0f..ce96c2e1f8 100644 --- a/doc/guides/nics/intel_vf.rst +++ b/doc/guides/nics/intel_vf.rst @@ -627,6 +627,23 @@ Inline IPsec Support documentation. +Diagnostic Utilities +-------------------- + +Register mbuf dynfield to test Tx LLDP +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +Register an mbuf dynfield IAVF_TX_LLDP_DYNFIELD on dev_start to indicate +the need to send LLDP packet, this dynfield needs to be set to 1 when +preparing packet. + +For dpdk-testpmd application, it needs to stop and restart Tx port +to take effect. + +Usage:: + + testpmd>set tx lldp on + Limitations or Knowing issues ----------------------------- diff --git a/drivers/net/iavf/iavf_testpmd.c b/drivers/net/iavf/iavf_testpmd.c new file mode 100644 index 0000000000..07aac07fc3 --- /dev/null +++ b/drivers/net/iavf/iavf_testpmd.c @@ -0,0 +1,81 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright(c) 2010-2016 Intel Corporation. + */ + +#include + +#include + +#include +#include + +#include "iavf.h" +#include "testpmd.h" +#include "iavf_rxtx.h" + +struct cmd_enable_tx_lldp_result { + cmdline_fixed_string_t set; + cmdline_fixed_string_t tx; + cmdline_fixed_string_t lldp; + cmdline_fixed_string_t what; +}; + +static cmdline_parse_token_string_t cmd_enable_tx_lldp_set = + TOKEN_STRING_INITIALIZER(struct cmd_enable_tx_lldp_result, + set, "set"); +static cmdline_parse_token_string_t cmd_enable_tx_lldp_tx = + TOKEN_STRING_INITIALIZER(struct cmd_enable_tx_lldp_result, + tx, "tx"); +static cmdline_parse_token_string_t cmd_enable_tx_lldp_lldp = + TOKEN_STRING_INITIALIZER(struct cmd_enable_tx_lldp_result, + lldp, "lldp"); +static cmdline_parse_token_string_t cmd_enable_tx_lldp_what = + TOKEN_STRING_INITIALIZER(struct cmd_enable_tx_lldp_result, + what, "on#off"); + +static void +cmd_enable_tx_lldp_parsed(void *parsed_result, + __rte_unused struct cmdline *cl, __rte_unused void *data) +{ + struct cmd_enable_tx_lldp_result *res = parsed_result; + const struct rte_mbuf_dynfield iavf_tx_lldp_dynfield = { + .name = IAVF_TX_LLDP_DYNFIELD, + .size = sizeof(uint8_t), + .align = __alignof__(uint8_t), + .flags = 0 + }; + int offset; + + if (strncmp(res->what, "on", 2) == 0) { + offset = rte_mbuf_dynfield_register(&iavf_tx_lldp_dynfield); + printf("rte_pmd_iavf_tx_lldp_dynfield_offset: %d", offset); + if (offset < 0) + fprintf(stderr, + "rte mbuf dynfield register failed, offset: %d", offset); + } +} + +static cmdline_parse_inst_t cmd_enable_tx_lldp = { + .f = cmd_enable_tx_lldp_parsed, + .data = NULL, + .help_str = "set iavf tx lldp on|off", + .tokens = { + (void *)&cmd_enable_tx_lldp_set, + (void *)&cmd_enable_tx_lldp_tx, + (void *)&cmd_enable_tx_lldp_lldp, + (void *)&cmd_enable_tx_lldp_what, + NULL, + }, +}; + +static struct testpmd_driver_commands iavf_cmds = { + .commands = { + { + &cmd_enable_tx_lldp, + "set tx lldp (on|off)\n" + " Set iavf Tx lldp packet(currently only supported on)\n\n", + }, + { NULL, NULL }, + }, +}; +TESTPMD_ADD_DRIVER_COMMANDS(iavf_cmds) diff --git a/drivers/net/iavf/meson.build b/drivers/net/iavf/meson.build index a6ce2725c3..83aebd5596 100644 --- a/drivers/net/iavf/meson.build +++ b/drivers/net/iavf/meson.build @@ -8,6 +8,9 @@ endif cflags += ['-Wno-strict-aliasing'] includes += include_directories('../../common/iavf') + +testpmd_sources = files('iavf_testpmd.c') + deps += ['common_iavf', 'security', 'cryptodev'] sources = files(