From patchwork Wed Dec 27 04:21:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 135592 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB349437A1; Wed, 27 Dec 2023 05:22:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 55E7140685; Wed, 27 Dec 2023 05:21:36 +0100 (CET) Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by mails.dpdk.org (Postfix) with ESMTP id 6CD10402F1 for ; Wed, 27 Dec 2023 05:21:31 +0100 (CET) Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-4279f38b5a3so36140531cf.2 for ; Tue, 26 Dec 2023 20:21:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1703650890; x=1704255690; darn=dpdk.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=UJIugBuBqtxbuUvkeVJI+0oJ96+JHmPs5Ns2P14pQIU=; b=fuD8Iy/6qvCEiNrFyE42PWy8i/NXRpdqX6qTkI3+IkCakYK64rJTv7V3XgxaxxAYmM 0l1EroLDJJSRKHyXE90BdUJ2b2Eh36fyClvS/sw4PKF8k+LzhcSu18f3ZF+T0fceE/H7 r3MYHaR/Pvu/zLcm/6Fe8UOJ4iZB2rf6/ogrs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703650890; x=1704255690; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UJIugBuBqtxbuUvkeVJI+0oJ96+JHmPs5Ns2P14pQIU=; b=SaSWYqZlYJZt0bSZ9IFQzx2NP5OO+gNqtMmSUJnQbuvsS1bDjv40N/Hi4aeMb+UkSc R4sAnxwfrf9BDlkw2bnl3lXTm1KvdB0hQQ4xTl/qzCucHvJkPPvEuHDGjyV4bHjQbWqD HGbHmI0XO8wmvYnjvn0VjkZCnqiUrgz5N5OZ6MaRQ1jyQQBdiKlCIhKthmTOtM0/C5M9 DsBMsuBtpNkA0ywK4PhPz4jEIR6yJFo0mZmXaDieqLpnfSK9qSbv20Esd2kphwhG2H0c v9fjHdDOJoJU2tx++rO+8DpZmX7eEvsj9mu6ROnN/vm2wpkTga0HzrEQsMrXXSeKSO/v jdjg== X-Gm-Message-State: AOJu0YzWWEtLxu4WL9IH9DXkapbvCxUsDRMYRxiDEJdxTK6GnNH1hLky b5YWDe7H6VJ/+z/l1g1eWJ4dWtNMQvqzK5/JuMtx0KwYi40AVB8ed3UoGZuX7ykrL3zaKsjtMb+ eNHoQlL0ntbHYOUkFphmdkC5AVA+3UyI/Iz31EiphjsCSZeUac0Amrd8XV76ZWnHaFq7jwNDoq9 w= X-Google-Smtp-Source: AGHT+IHDZKGVRN/XZUV1s8jzMBxbZixQc77ZSgwTQ1FLVajweCf5GalMS+M2yS1Bx0XQEkswq1eKLQ== X-Received: by 2002:a05:622a:607:b0:425:f204:906d with SMTP id z7-20020a05622a060700b00425f204906dmr11678455qta.118.1703650890580; Tue, 26 Dec 2023 20:21:30 -0800 (PST) Received: from localhost.localdomain ([2605:a601:a780:1400:c066:75e3:74c8:50e6]) by smtp.gmail.com with ESMTPSA id bt7-20020ac86907000000b00427e120889bsm1415488qtb.91.2023.12.26.20.21.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 20:21:29 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Kalesh AP , stable@dpdk.org, Somnath Kotur Subject: [PATCH v3 04/18] net/bnxt: fix setting 50G and 100G forced speed Date: Tue, 26 Dec 2023 20:21:05 -0800 Message-Id: <20231227042119.72469-5-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20231227042119.72469-1-ajit.khaparde@broadcom.com> References: <20231227042119.72469-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Kalesh AP Thor based NICs can support PAM4 as well as NRZ link negotiation. While PAM4 can negotiate speeds at 50G, 100G and 200G, the PMD will use NRZ signaling for 50G and 100G speeds. PAM4 signaling will be used only for 200G speed negotiations. Driver has to check for NRZ speed support first while forcing speed. Fixes: c23f9ded0391 ("net/bnxt: support 200G PAM4 link") Cc: stable@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 8f99582819..c31a5d4226 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -3158,6 +3158,8 @@ static uint16_t bnxt_check_eth_link_autoneg(uint32_t conf_link) static uint16_t bnxt_parse_eth_link_speed(uint32_t conf_link_speed, struct bnxt_link_info *link_info) { + uint16_t support_pam4_speeds = link_info->support_pam4_speeds; + uint16_t support_speeds = link_info->support_speeds; uint16_t eth_link_speed = 0; if (conf_link_speed == RTE_ETH_LINK_SPEED_AUTONEG) @@ -3195,23 +3197,23 @@ static uint16_t bnxt_parse_eth_link_speed(uint32_t conf_link_speed, HWRM_PORT_PHY_CFG_INPUT_FORCE_LINK_SPEED_40GB; break; case RTE_ETH_LINK_SPEED_50G: - if (link_info->support_pam4_speeds & - HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_PAM4_SPEEDS_50G) { - eth_link_speed = HWRM_PORT_PHY_CFG_INPUT_FORCE_PAM4_LINK_SPEED_50GB; - link_info->link_signal_mode = BNXT_SIG_MODE_PAM4; - } else { + if (support_speeds & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_50GB) { eth_link_speed = HWRM_PORT_PHY_CFG_INPUT_FORCE_LINK_SPEED_50GB; link_info->link_signal_mode = BNXT_SIG_MODE_NRZ; + } else if (support_pam4_speeds & + HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_PAM4_SPEEDS_50G) { + eth_link_speed = HWRM_PORT_PHY_CFG_INPUT_FORCE_PAM4_LINK_SPEED_50GB; + link_info->link_signal_mode = BNXT_SIG_MODE_PAM4; } break; case RTE_ETH_LINK_SPEED_100G: - if (link_info->support_pam4_speeds & - HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_PAM4_SPEEDS_100G) { - eth_link_speed = HWRM_PORT_PHY_CFG_INPUT_FORCE_PAM4_LINK_SPEED_100GB; - link_info->link_signal_mode = BNXT_SIG_MODE_PAM4; - } else { + if (support_speeds & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_100GB) { eth_link_speed = HWRM_PORT_PHY_CFG_INPUT_FORCE_LINK_SPEED_100GB; link_info->link_signal_mode = BNXT_SIG_MODE_NRZ; + } else if (support_pam4_speeds & + HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_PAM4_SPEEDS_100G) { + eth_link_speed = HWRM_PORT_PHY_CFG_INPUT_FORCE_PAM4_LINK_SPEED_100GB; + link_info->link_signal_mode = BNXT_SIG_MODE_PAM4; } break; case RTE_ETH_LINK_SPEED_200G: