From patchwork Fri Dec 22 21:56:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 135533 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9550643762; Fri, 22 Dec 2023 22:57:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 72D9A4069F; Fri, 22 Dec 2023 22:57:13 +0100 (CET) Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) by mails.dpdk.org (Postfix) with ESMTP id A212D4026C for ; Fri, 22 Dec 2023 22:57:10 +0100 (CET) Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-593fbe8147fso1248587eaf.2 for ; Fri, 22 Dec 2023 13:57:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1703282229; x=1703887029; darn=dpdk.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=+Pt8rhGq2/mZumAbuu0kAOAB6T7/7IJCJpLh3W0v3kM=; b=IKiqzTIlTDeZ1ihWVC2GasFTwDGN1XDMAYsNs7UIukqiosyvMGh4vxrh2DxnyefZAA Wa9Yv7u0KOdNk4ODYUumGNJ0y8G5XofuusKn9qPOj3e5nf6vSV4vl1H1pK3ClE771jbG THVuf7u+PGztOq7WMhCaMHDetTGF9YDpNb6yo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703282229; x=1703887029; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+Pt8rhGq2/mZumAbuu0kAOAB6T7/7IJCJpLh3W0v3kM=; b=Btf4EKUr9IAU+rR1RmSkQdI9h2K5KVoNNFY2exAMYr/vCucjZWp9jEwqKQ/8LbnF1o yOF66XMQCVDuStqSckO/V9oC3lV1SDUl+hmYE2U/Av+a/K4cNnsd0Bs9WXcH14iTjwbZ 4rmlGxKY80JUWqf5Q6NXZdEyYpY1Jy7cUkgqTlQJ8sC2VoIyVFm5qB6FH+ET1wue87bP ROXJhPJwdbBuf8UFEINpR6a2FuKGXlmbmyxulHccSe3Q5Ofz2pfvPSBJ80ml8N2W0tc4 DJF4sGSnkkM6pHMDZ09TxwK7bRvGnJXlj4t7EDguI/sn48Z3BwJam4U2hC4lAvv0UROK bAqw== X-Gm-Message-State: AOJu0Yzx2US6WxuIdyD/IR2E1b1SagpxckwS/toTX+rzKAoh5EQ+vJAB ies10ECgCA1LMDFck4wac9dl/TK6dZG1IRJj//CYSavcn8oLsl2AAclgVwUoxjiBGP2CI85sv2g oRdnZ+SqlC9FlsoE+jmUKZFRjgttYZ88MDZeQEBO4n6YpCnecBLPLCrEzCk4BeqW98J6otxGX/m w= X-Google-Smtp-Source: AGHT+IHwIOgP9m0J7smVfAQmlesShksdhNF+S20L7NUs7MLmEraIMgmpFFnPkF4ONAO8YgUAmFsxpQ== X-Received: by 2002:a05:6358:921d:b0:174:c22e:992a with SMTP id d29-20020a056358921d00b00174c22e992amr2381006rwb.3.1703282229021; Fri, 22 Dec 2023 13:57:09 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id sr5-20020a17090b4e8500b0028afd8b1e0bsm3540700pjb.57.2023.12.22.13.57.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 13:57:08 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Kalesh AP Subject: [PATCH v2 03/18] net/bnxt: fix a typo while parsing link speed Date: Fri, 22 Dec 2023 13:56:44 -0800 Message-Id: <20231222215659.64993-4-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20231222215659.64993-1-ajit.khaparde@broadcom.com> References: <20231222215659.64993-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Kalesh AP While setting forced speed, the speed should have mapped to macro "HWRM_PORT_PHY_CFG_INPUT_FORCE_xxx" instead of "HWRM_PORT_PHY_CFG_INPUT_AUTO_xxx". We do not see any issue as both these macros are defined to the same value. Fixing it for better convey the intent. Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 378be997d3..8f99582819 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -3168,15 +3168,15 @@ static uint16_t bnxt_parse_eth_link_speed(uint32_t conf_link_speed, case RTE_ETH_LINK_SPEED_100M_HD: /* FALLTHROUGH */ eth_link_speed = - HWRM_PORT_PHY_CFG_INPUT_AUTO_LINK_SPEED_100MB; + HWRM_PORT_PHY_CFG_INPUT_FORCE_LINK_SPEED_100MB; break; case RTE_ETH_LINK_SPEED_1G: eth_link_speed = - HWRM_PORT_PHY_CFG_INPUT_AUTO_LINK_SPEED_1GB; + HWRM_PORT_PHY_CFG_INPUT_FORCE_LINK_SPEED_1GB; break; case RTE_ETH_LINK_SPEED_2_5G: eth_link_speed = - HWRM_PORT_PHY_CFG_INPUT_AUTO_LINK_SPEED_2_5GB; + HWRM_PORT_PHY_CFG_INPUT_FORCE_LINK_SPEED_2_5GB; break; case RTE_ETH_LINK_SPEED_10G: eth_link_speed = @@ -3184,11 +3184,11 @@ static uint16_t bnxt_parse_eth_link_speed(uint32_t conf_link_speed, break; case RTE_ETH_LINK_SPEED_20G: eth_link_speed = - HWRM_PORT_PHY_CFG_INPUT_AUTO_LINK_SPEED_20GB; + HWRM_PORT_PHY_CFG_INPUT_FORCE_LINK_SPEED_20GB; break; case RTE_ETH_LINK_SPEED_25G: eth_link_speed = - HWRM_PORT_PHY_CFG_INPUT_AUTO_LINK_SPEED_25GB; + HWRM_PORT_PHY_CFG_INPUT_FORCE_LINK_SPEED_25GB; break; case RTE_ETH_LINK_SPEED_40G: eth_link_speed =