From patchwork Thu Dec 21 18:05:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 135479 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E654143752; Thu, 21 Dec 2023 19:06:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3DDB842E98; Thu, 21 Dec 2023 19:05:43 +0100 (CET) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id 0764A4028B for ; Thu, 21 Dec 2023 19:05:41 +0100 (CET) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1d40eec5e12so5001595ad.1 for ; Thu, 21 Dec 2023 10:05:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1703181940; x=1703786740; darn=dpdk.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=HvwWUXgOFwgC+wOhVBlK+yDfKOxB9bB/Mwbs7jXXb9k=; b=RzJrMH2NxYvmZdDZSwLJ5cKK+OuIXa9L32r8A9AD1+5cAPqUrC4VZrI4MK193Fx9z+ Nk528E+N2FtlbwG6fBFTpUs7cBT/tyYq2be46cg7cQlpVPjTww+8KYJcyjiEWrLH+9D3 ZefQmO7Qbh90QswL9vFWti0s9ZLdIWIbvZuhw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703181940; x=1703786740; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HvwWUXgOFwgC+wOhVBlK+yDfKOxB9bB/Mwbs7jXXb9k=; b=fa09qDPTeGINZkufG/tKEIA3VCeDyIdllbuz5oDMYENJWBbb2ssVeAlHo1st2HgIAm XrbwVfcgX5srX64yEN6dpaeRFMIJce7s8jHns+sH9WcEMixBNWEkkAqmxNavl77CRRVd oKNn0r50UfApxol8L/pK3La+O36wjTuKlz/HKB13Ab5zN+jMbIbkyudUF1bo9A4ATRWd 79Yy0un8rFXUqIqXrrWlFJULEqVPxaNhL+B+xQWR8L6YouTUKB1FPJ1YekNEZsQu8lbD CdXSh7kvMjUX5oN7RKbMi8AJt6e5Obx98qrBhquTIEOINyW931ci2oVFSbj5r6Op7Q0P pC4w== X-Gm-Message-State: AOJu0YxQ7eMslDxLKT3kLzDHM2uFByEybCVqhO3/vlg+3AKB7YxIvvB/ zfZw8mnT8h0pY7IMueKO6/Z05pvSwxiOGkFQ1yCOVu/sV0Iaqw4/epDbZ/WFzbOKQnBoITA4fEU S9x1xT2TeJq+e9XvJEBFGLJpkD9QES+zW5ETuXVHUKZx9k/xJ8btuoy2mt18POzcgunYF7zmAWh U= X-Google-Smtp-Source: AGHT+IHvHApJD9bEIDj+Dm49Coyu5AdNnVmoWH+Z8ltlI/5dutsv1ZQA8Cn3gUNKsoH81AtZxoSv4w== X-Received: by 2002:a17:902:b48e:b0:1d3:6c56:1d13 with SMTP id y14-20020a170902b48e00b001d36c561d13mr6808plr.93.1703181939634; Thu, 21 Dec 2023 10:05:39 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id j17-20020a170902da9100b001d3b3ac2d7bsm1916379plx.245.2023.12.21.10.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 10:05:38 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Kalesh AP , stable@dpdk.org, Somnath Kotur Subject: [PATCH 04/18] net/bnxt: fix setting 50G and 100G forced speed Date: Thu, 21 Dec 2023 10:05:15 -0800 Message-Id: <20231221180529.18687-5-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20231221180529.18687-1-ajit.khaparde@broadcom.com> References: <20231221180529.18687-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Kalesh AP Thor based NICs can support PAM4 as well as NRZ link negotiation. While PAM4 can negotiate speeds at 50G, 100G and 200G, the PMD will use NRZ signaling for 50G and 100G speeds. PAM4 signaling will be used only for 200G speed negotiations. Driver has to check for NRZ speed support first while forcing speed. Fixes: c23f9ded0391 ("net/bnxt: support 200G PAM4 link") Cc: stable@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 8f99582819..c31a5d4226 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -3158,6 +3158,8 @@ static uint16_t bnxt_check_eth_link_autoneg(uint32_t conf_link) static uint16_t bnxt_parse_eth_link_speed(uint32_t conf_link_speed, struct bnxt_link_info *link_info) { + uint16_t support_pam4_speeds = link_info->support_pam4_speeds; + uint16_t support_speeds = link_info->support_speeds; uint16_t eth_link_speed = 0; if (conf_link_speed == RTE_ETH_LINK_SPEED_AUTONEG) @@ -3195,23 +3197,23 @@ static uint16_t bnxt_parse_eth_link_speed(uint32_t conf_link_speed, HWRM_PORT_PHY_CFG_INPUT_FORCE_LINK_SPEED_40GB; break; case RTE_ETH_LINK_SPEED_50G: - if (link_info->support_pam4_speeds & - HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_PAM4_SPEEDS_50G) { - eth_link_speed = HWRM_PORT_PHY_CFG_INPUT_FORCE_PAM4_LINK_SPEED_50GB; - link_info->link_signal_mode = BNXT_SIG_MODE_PAM4; - } else { + if (support_speeds & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_50GB) { eth_link_speed = HWRM_PORT_PHY_CFG_INPUT_FORCE_LINK_SPEED_50GB; link_info->link_signal_mode = BNXT_SIG_MODE_NRZ; + } else if (support_pam4_speeds & + HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_PAM4_SPEEDS_50G) { + eth_link_speed = HWRM_PORT_PHY_CFG_INPUT_FORCE_PAM4_LINK_SPEED_50GB; + link_info->link_signal_mode = BNXT_SIG_MODE_PAM4; } break; case RTE_ETH_LINK_SPEED_100G: - if (link_info->support_pam4_speeds & - HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_PAM4_SPEEDS_100G) { - eth_link_speed = HWRM_PORT_PHY_CFG_INPUT_FORCE_PAM4_LINK_SPEED_100GB; - link_info->link_signal_mode = BNXT_SIG_MODE_PAM4; - } else { + if (support_speeds & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_100GB) { eth_link_speed = HWRM_PORT_PHY_CFG_INPUT_FORCE_LINK_SPEED_100GB; link_info->link_signal_mode = BNXT_SIG_MODE_NRZ; + } else if (support_pam4_speeds & + HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_PAM4_SPEEDS_100G) { + eth_link_speed = HWRM_PORT_PHY_CFG_INPUT_FORCE_PAM4_LINK_SPEED_100GB; + link_info->link_signal_mode = BNXT_SIG_MODE_PAM4; } break; case RTE_ETH_LINK_SPEED_200G: