diff mbox series

bus/ifpga: remove dead code

Message ID 20231218154527.1507785-1-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series bus/ifpga: remove dead code |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-abi-testing success Testing PASS
ci/intel-Functional fail Functional issues
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS

Commit Message

David Marchand Dec. 18, 2023, 3:45 p.m. UTC 
  This macro was never used.

Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/bus/ifpga/ifpga_logs.h | 4 ----
 1 file changed, 4 deletions(-)

Comments

Bruce Richardson Dec. 18, 2023, 3:47 p.m. UTC | #1 
On Mon, Dec 18, 2023 at 04:45:26PM +0100, David Marchand wrote:
> This macro was never used.
> 
> Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  drivers/bus/ifpga/ifpga_logs.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Xu, Rosen Dec. 19, 2023, 1:18 a.m. UTC | #2 
Hi

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Monday, December 18, 2023 11:45 PM
> To: dev@dpdk.org
> Cc: Xu, Rosen <rosen.xu@intel.com>; Tianfei Zhang
> <tianfei.zhang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [PATCH] bus/ifpga: remove dead code
> 
> This macro was never used.
> 
> Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  drivers/bus/ifpga/ifpga_logs.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/bus/ifpga/ifpga_logs.h b/drivers/bus/ifpga/ifpga_logs.h
> index 873e0a4f2f..248bccba5d 100644
> --- a/drivers/bus/ifpga/ifpga_logs.h
> +++ b/drivers/bus/ifpga/ifpga_logs.h
> @@ -9,10 +9,6 @@
> 
>  extern int ifpga_bus_logtype;
> 
> -#define IFPGA_LOG(level, fmt, args...) \
> -	rte_log(RTE_LOG_ ## level, ifpga_bus_logtype, "%s(): " fmt "\n", \
> -		__func__, ##args)
> -
>  #define IFPGA_BUS_LOG(level, fmt, args...) \
>  	rte_log(RTE_LOG_ ## level, ifpga_bus_logtype, "%s(): " fmt "\n", \
>  		__func__, ##args)
> --
> 2.43.0

Acked-by: Rosen Xu <rosen.xu@intel.com>
David Marchand Jan. 19, 2024, 11:08 a.m. UTC | #3 
On Mon, Dec 18, 2023 at 4:45 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> This macro was never used.
>
> Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/bus/ifpga/ifpga_logs.h b/drivers/bus/ifpga/ifpga_logs.h
index 873e0a4f2f..248bccba5d 100644
--- a/drivers/bus/ifpga/ifpga_logs.h
+++ b/drivers/bus/ifpga/ifpga_logs.h
@@ -9,10 +9,6 @@ 
 
 extern int ifpga_bus_logtype;
 
-#define IFPGA_LOG(level, fmt, args...) \
-	rte_log(RTE_LOG_ ## level, ifpga_bus_logtype, "%s(): " fmt "\n", \
-		__func__, ##args)
-
 #define IFPGA_BUS_LOG(level, fmt, args...) \
 	rte_log(RTE_LOG_ ## level, ifpga_bus_logtype, "%s(): " fmt "\n", \
 		__func__, ##args)