From patchwork Tue Nov 7 23:41:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joshua Washington X-Patchwork-Id: 133961 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF8E0432CC; Wed, 8 Nov 2023 00:42:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9AB03410E3; Wed, 8 Nov 2023 00:42:25 +0100 (CET) Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by mails.dpdk.org (Postfix) with ESMTP id 5896E40041 for ; Wed, 8 Nov 2023 00:42:24 +0100 (CET) Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-5af16e00fadso85554577b3.0 for ; Tue, 07 Nov 2023 15:42:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699400543; x=1700005343; darn=dpdk.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=jSpj11nuBWcCPxmXOqK0iLNXE3jx+dSwzCfI7WmIsvw=; b=l1Qv5namkrcqFc646zNfQ1YiEaGYxiVejnZIpCrqQrmNMYeGdVbSljNKum9Pi/GE0L sFKzQTjQahE2gbgK8yjSCzirFHMm/O+Kno1bA7FAh5IO8BCJUMOyNYAJnz8XInbHxEg/ qXPCGmCFKyKrrDhrHNLG+uicPgv2+V1TYv4cIgO9Ha+lC1GTAMeODt24yaCRsTaeqAjW LFiePjYJAsmPXvq7UMFWV4ReTL5F1AccjHvI++QlbWkhMX6yPbp0OGR+mDwHV+aYYsx9 /gHctjZV3DrENJIt5spYv6sjcerLFM5u8vPwW7wSkmZ2UFCwEfJr5Yw+Qp8OWeZ6mS5n JZUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699400543; x=1700005343; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=jSpj11nuBWcCPxmXOqK0iLNXE3jx+dSwzCfI7WmIsvw=; b=hOYXUll0NB0303joH+Vo1NC958zsy056C/XnIefAXVYN1Y8b6KL24JI2ptAmTQnXTH hMeYg+LH1ImMUnyuWQP1/J77Kk7kRg/rhAGsl2TZEcL4JzayYTFHXjv2F0HWFbbmEJiI sN0KvJtwvEmt+Qn2sQ5zsfjx6IDOBDHdlUDLZQ7mfSrzLBMvrMAyD1UcMEf2jZ69UZHH 18mMFacRBOOuaK+qKYr192VxNZYnv8M4mKwFjNBtJ1WW4DxnF3nWTPaZ1xyd2RzjfyG2 K+6bM62gm5xXmy2s5kWBhiUmzHDHKNs3yNDFPNEwnUtpgyc138ff3T7Zq0h3Hj6QekB+ SNCg== X-Gm-Message-State: AOJu0YzIJQJTng8Y1G+CEdVFfWHTVXIttCfw5TDuoG5kAaXMbkYNBxSc wPBdWlQk/FHenYiDsPSQ327q/QI+eC8Ymg== X-Google-Smtp-Source: AGHT+IGoL/oemZr4OFj7WUF70NKPIcXdOHohQxKIt1d8wCJGUEyooGND2vfzGmj3ep14v2P9K70k1pmob96rFg== X-Received: from joshwash.sea.corp.google.com ([2620:15c:11c:202:74f2:7b5:42ea:65e8]) (user=joshwash job=sendgmr) by 2002:a25:d34f:0:b0:da0:3e20:658d with SMTP id e76-20020a25d34f000000b00da03e20658dmr4633ybf.10.1699400543722; Tue, 07 Nov 2023 15:42:23 -0800 (PST) Date: Tue, 7 Nov 2023 15:41:40 -0800 Mime-Version: 1.0 X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog Message-ID: <20231107234207.643574-1-joshwash@google.com> Subject: [PATCH] ethdev: account for smaller MTU when setting default From: Joshua Washington To: Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Rosen Xu , Ajit Khaparde , Somnath Kotur , Huisong Li Cc: dev@dpdk.org, Rushil Gupta , Joshua Washington X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently, if not specified in the user configuration, rte_eth_dev_configure() sets the MTU of the device to RTE_EHTER_MTU. This value could potentially be larger than the MTU that the device supports. This change updates the configured MTU to be the minimum of the maximum suported MTU and the default DPDK MTU. Fixes: 1bb4a528c4 ("ethdev: fix max Rx packet length") Signed-off-by: Joshua Washington Signed-off-by: Rushil Gupta --- lib/ethdev/rte_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index 9163ef47ea..bba94311d3 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -1419,7 +1419,8 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q, } if (dev_conf->rxmode.mtu == 0) - dev->data->dev_conf.rxmode.mtu = RTE_ETHER_MTU; + dev->data->dev_conf.rxmode.mtu + = RTE_MIN(RTE_ETHER_MTU, dev_info.max_mtu); ret = eth_dev_validate_mtu(port_id, &dev_info, dev->data->dev_conf.rxmode.mtu);