[v4,4/5] common/nfp: use new API to parse kvargs
Checks
Commit Message
The nfp_parse_class_options() function could handle both key=value and
only-key, so it should use rte_kvargs_process_opt() instead of
rte_kvargs_process() to parse.
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
drivers/common/nfp/nfp_common_pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On Sun, 5 Nov 2023 05:45:38 +0000
Chengwen Feng <fengchengwen@huawei.com> wrote:
> if (rte_kvargs_count(kvargs, RTE_DEVARGS_KEY_CLASS) != 0) {
> - rte_kvargs_process(kvargs, RTE_DEVARGS_KEY_CLASS,
> - nfp_kvarg_dev_class_handler, &dev_class);
> + rte_kvargs_process_opt(kvargs, RTE_DEVARGS_KEY_CLASS,
> + nfp_kvarg_dev_class_handler, &dev_class);
> }
Since kvargs_process() already does a scan, the kvargs_count() cause an extra pass.
Hi Stephen,
On 2023/11/6 11:19, Stephen Hemminger wrote:
> On Sun, 5 Nov 2023 05:45:38 +0000
> Chengwen Feng <fengchengwen@huawei.com> wrote:
>
>> if (rte_kvargs_count(kvargs, RTE_DEVARGS_KEY_CLASS) != 0) {
>> - rte_kvargs_process(kvargs, RTE_DEVARGS_KEY_CLASS,
>> - nfp_kvarg_dev_class_handler, &dev_class);
>> + rte_kvargs_process_opt(kvargs, RTE_DEVARGS_KEY_CLASS,
>> + nfp_kvarg_dev_class_handler, &dev_class);
>> }
>
> Since kvargs_process() already does a scan, the kvargs_count() cause an extra pass.
will fix in v5
Thanks
Chengwen
>
> .
>
@@ -171,8 +171,8 @@ nfp_parse_class_options(const struct rte_devargs *devargs)
return dev_class;
if (rte_kvargs_count(kvargs, RTE_DEVARGS_KEY_CLASS) != 0) {
- rte_kvargs_process(kvargs, RTE_DEVARGS_KEY_CLASS,
- nfp_kvarg_dev_class_handler, &dev_class);
+ rte_kvargs_process_opt(kvargs, RTE_DEVARGS_KEY_CLASS,
+ nfp_kvarg_dev_class_handler, &dev_class);
}
rte_kvargs_free(kvargs);