From patchwork Wed Oct 25 13:36:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Brandes, Shai" X-Patchwork-Id: 133308 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98BFC431FC; Wed, 25 Oct 2023 15:37:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E320F42DDB; Wed, 25 Oct 2023 15:36:43 +0200 (CEST) Received: from smtp-fw-33001.amazon.com (smtp-fw-33001.amazon.com [207.171.190.10]) by mails.dpdk.org (Postfix) with ESMTP id E751C42DA6 for ; Wed, 25 Oct 2023 15:36:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1698241003; x=1729777003; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=v/bYiicxGaz5mvPhBhhGqHEEnt8TVk7qf1AB+y7Srac=; b=jqSpzgMR77PgrJzLItz0My/kfcBPz6ZZd5CGqnnyodY6HMM87PUzsDRe 2ngLxWj0sqPPCsTPR9bG7wov6eRB+QUPc4/ZC4w9aBDH8kHteSI73cFi+ HzYR+muy+JV7w3bbt/uYL01Y//JfRvVkB7qAqBD7vRkyepldy+r9VWTG0 Y=; X-IronPort-AV: E=Sophos;i="6.03,250,1694736000"; d="scan'208";a="310281809" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-pdx-2c-m6i4x-dc7c3f8b.us-west-2.amazon.com) ([10.43.8.6]) by smtp-border-fw-33001.sea14.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2023 13:36:35 +0000 Received: from smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev (pdx2-ws-svc-p26-lb5-vlan2.pdx.amazon.com [10.39.38.66]) by email-inbound-relay-pdx-2c-m6i4x-dc7c3f8b.us-west-2.amazon.com (Postfix) with ESMTPS id 4E9CCA0452; Wed, 25 Oct 2023 13:36:33 +0000 (UTC) Received: from EX19MTAEUA001.ant.amazon.com [10.0.43.254:35417] by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.38.116:2525] with esmtp (Farcaster) id 206413a3-5e01-414e-9695-9906c31a6719; Wed, 25 Oct 2023 13:36:32 +0000 (UTC) X-Farcaster-Flow-ID: 206413a3-5e01-414e-9695-9906c31a6719 Received: from EX19D023EUA003.ant.amazon.com (10.252.50.101) by EX19MTAEUA001.ant.amazon.com (10.252.50.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Wed, 25 Oct 2023 13:36:31 +0000 Received: from EX19MTAUEB001.ant.amazon.com (10.252.135.35) by EX19D023EUA003.ant.amazon.com (10.252.50.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Wed, 25 Oct 2023 13:36:31 +0000 Received: from HFA15-CG15235BS.amazon.com (10.106.83.33) by mail-relay.amazon.com (10.252.135.35) with Microsoft SMTP Server id 15.2.1118.39 via Frontend Transport; Wed, 25 Oct 2023 13:36:30 +0000 From: To: CC: , , , , Subject: [PATCH v2 3/5] net/ena: report Rx overrun errors in xstats Date: Wed, 25 Oct 2023 16:36:07 +0300 Message-ID: <20231025133609.17931-4-shaibran@amazon.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20231025133609.17931-1-shaibran@amazon.com> References: <20231025133609.17931-1-shaibran@amazon.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Shai Brandes RX overrun error occur when a packet arrives but there are not enough free buffers in the RX ring to receive it. The driver publishes the extended statistics with the RX buffer overrun errors as reported by the device. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- doc/guides/rel_notes/release_23_11.rst | 1 + drivers/net/ena/ena_ethdev.c | 4 ++++ drivers/net/ena/ena_ethdev.h | 1 + 3 files changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst index eefbcc08fe..f622d93384 100644 --- a/doc/guides/rel_notes/release_23_11.rst +++ b/doc/guides/rel_notes/release_23_11.rst @@ -148,6 +148,7 @@ New Features * Upgraded ENA HAL to latest version. * Added support for connection tracking allowance utilization metric. + * Added support for reporting rx overrun errors in xstats. * **Updated Solarflare net driver.** diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index daec7f7d16..b3ebda6049 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -90,6 +90,7 @@ static const struct ena_stats ena_stats_global_strings[] = { ENA_STAT_GLOBAL_ENTRY(dev_start), ENA_STAT_GLOBAL_ENTRY(dev_stop), ENA_STAT_GLOBAL_ENTRY(tx_drops), + ENA_STAT_GLOBAL_ENTRY(rx_overruns), }; /* @@ -3894,15 +3895,18 @@ static void ena_keep_alive(void *adapter_data, struct ena_admin_aenq_keep_alive_desc *desc; uint64_t rx_drops; uint64_t tx_drops; + uint64_t rx_overruns; adapter->timestamp_wd = rte_get_timer_cycles(); desc = (struct ena_admin_aenq_keep_alive_desc *)aenq_e; rx_drops = ((uint64_t)desc->rx_drops_high << 32) | desc->rx_drops_low; tx_drops = ((uint64_t)desc->tx_drops_high << 32) | desc->tx_drops_low; + rx_overruns = ((uint64_t)desc->rx_overruns_high << 32) | desc->rx_overruns_low; adapter->drv_stats->rx_drops = rx_drops; adapter->dev_stats.tx_drops = tx_drops; + adapter->dev_stats.rx_overruns = rx_overruns; } /** diff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h index 9268d44dde..3f29764ca6 100644 --- a/drivers/net/ena/ena_ethdev.h +++ b/drivers/net/ena/ena_ethdev.h @@ -219,6 +219,7 @@ struct ena_stats_dev { * As a workaround it is being published as an extended statistic. */ u64 tx_drops; + u64 rx_overruns; }; struct ena_stats_metrics {