From patchwork Wed Oct 25 07:48:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiawei Wang X-Patchwork-Id: 133277 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F3D5431F8; Wed, 25 Oct 2023 09:49:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 08864402C8; Wed, 25 Oct 2023 09:49:01 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 964FA402BD for ; Wed, 25 Oct 2023 09:48:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RHpQ0pvXrmBe5zagmNaCb2kdlFrkTRjKIFKnrOseO2Nw8qdZays4L/CRLODW4STuuKlLxAqJAhuMEHpdmQPcRBUIHeGn3QN6RhfkzmPdmzVYBu8iCgG/lVbGoQD9RGUcI3go79yWLF8+q9ooOrOcFk1/cQj3/HNpvnnKWiS6+kfjvi3x7wx7hRG+pI6R5aAKMKYrLe1sq6qtEdXneq+E4g2Amr3N4R85Pn1P06mVTWZSKIrCpx8fe1tLmviDn9bru961Qj97rBSMwAwmCP+vz/NVUV3JIATiaGfWz6i1mpAV1/UO9Wf+o7TOYOe+gCYxPGVywXonsN7AYL7U0URIEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NPc/YKILDDJVBxSxpCwjeS8QwEcZlyXEz0yUvuY4pXU=; b=W9U+wLptn0Zz7rZLBDtcy3tvt2RzqvVSI3mSeATh2tJDWcvKugXtdb9EaQFNw04mxq70LUt/KZN3gn1vmSeA7aqmG6e6aVtqF5dVD860XvHdqqDCZ9XKN2m+nnduL50qnNJAegAWbLQWFrsgqujJWxYTdZzq6CDdZu1PmLLKYF/D4WhLZ7a9xE7gj1mZrlN7jxY7SvJrZL8VMnbJrG2mZecBFyvMOXaWseaUops58FLV2+5L/8B4B9Zzfx4Kt6ngC0TxfQVrWgBPUwu3WYhiYHZqQbBa4wM5QlWHV4RKm7yWbd7saLG5LM2ZKTjqonDZhhR2DgxZqtutaAnkWoFRnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NPc/YKILDDJVBxSxpCwjeS8QwEcZlyXEz0yUvuY4pXU=; b=ZsiDsax9n6LtxubpvMTPK6XMu1Z0Weli4193acQebHWJ1CGrmWLTv8O7Sn0sNZnQViNhffBXOJbV2Lmju5IRH+AN3/if1RfpPxIJg961W67fXVrsxjMnRDGgI1qmFNeGQimMitoNnQdeMGQV58oq5Vo7U5l5hTFSF9ykBIYwJIKHBwlIS+cwcdoE8EqWJlwZWcQBi9qoF7XWtrBchWj+xlQLN0Lclt/+RMoWYnsp9CSb9xDnycLQRW0HnR8PyV9ihYgoO4cb7zx8b4GCRCR1i4E2p43t9qoGdHYvVOgOXjThzKQdr8eON08qTUYGTy5MHG2xUszO35mWwJzOaipIDQ== Received: from CYZPR19CA0015.namprd19.prod.outlook.com (2603:10b6:930:8e::11) by MN0PR12MB6272.namprd12.prod.outlook.com (2603:10b6:208:3c0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Wed, 25 Oct 2023 07:48:56 +0000 Received: from CY4PEPF0000EE3D.namprd03.prod.outlook.com (2603:10b6:930:8e:cafe::68) by CYZPR19CA0015.outlook.office365.com (2603:10b6:930:8e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.36 via Frontend Transport; Wed, 25 Oct 2023 07:48:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000EE3D.mail.protection.outlook.com (10.167.242.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Wed, 25 Oct 2023 07:48:55 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 25 Oct 2023 00:48:46 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 25 Oct 2023 00:48:44 -0700 From: Jiawei Wang To: , CC: , Subject: [PATCH] net/mlx5: fix device checking for send to kernel action Date: Wed, 25 Oct 2023 10:48:31 +0300 Message-ID: <20231025074831.6098-1-jiaweiw@nvidia.com> X-Mailer: git-send-email 2.18.1 MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE3D:EE_|MN0PR12MB6272:EE_ X-MS-Office365-Filtering-Correlation-Id: db0d4df0-16cb-43b9-dbe2-08dbd52ed700 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2t9HzD8Ulqj22eKTy1Twm3w91NQJw7a59dY5RQfnTEh5BHfZq33P0NsruEc+9OPefirwW8RmT83P546nuiN1CU7/x1ETU8bp7SFW3gosx2gjJBuEKn99xXhd62dYPGEYiyRJ2aTkdiG/nDqrdK8wSQdFEgH4+lGdZXyfFKHHKAC21wNwYDEs8xGPQExuWQ9Jd+eyMOM5l3psvhj/od3PQFsWz1hXG5JGsBD4WoI9hFsdF2FQZN/4qVIcjOjfpOcQH/pyFDgG2Dqgp7Y5+rToE5fMnqyP51GMsjT5l62YSCnW9MRa5lZSMVIRk1QZ0DRHJFGZikkOJ9zv3k/dLHEPf5g2+wUmkFaHYnEgLchYHTxIu/iImD7b2iciCDLZFppsH/hUV0ZZXZjjTjhRlQqvQAEnsie32wPanryj+Motee81JqVKeiLHp1/n25PAtsJXCZyr6QnsbDjRL6GsLwZ81zDOKFP63JmC60wWk1lkdYTzHqaXzz9NS0GcUoQPxK2/3/qIvRjSjruZ3F78yZY2I2SVcZJdhCRRRBDpPFWYlH7+7zQgR3SoXjaNhvDkkRau58/WLWOtX2OZXnq0tH8smcQrVojwx36unkmWj1ztrJWG3A21aQ7vdYUTcadSTtVRo9rlx1lklyfcO9N4q8Tw3m+HT0Uj8wXKkm5h82kCwoYa8VVTYp4Jy+AsYkFzX/bQLPv5xQ0Pvykj0MOGT2+B79gb4EFvYBRY/22FaLgwZG321H8DMuIaQjC8NB8DwYvv X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(376002)(136003)(346002)(396003)(39860400002)(230922051799003)(64100799003)(451199024)(82310400011)(1800799009)(186009)(40470700004)(46966006)(36840700001)(356005)(7636003)(336012)(82740400003)(6636002)(6666004)(478600001)(40460700003)(36756003)(426003)(55016003)(7696005)(107886003)(47076005)(1076003)(8676002)(4326008)(26005)(54906003)(16526019)(6286002)(110136005)(70206006)(316002)(41300700001)(5660300002)(8936002)(2616005)(70586007)(36860700001)(83380400001)(86362001)(2906002)(40480700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 07:48:55.3864 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: db0d4df0-16cb-43b9-dbe2-08dbd52ed700 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE3D.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6272 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The previous commit extended the send to kernel support on FDB table. This action creation failed at MLX5 core kernel module, due to the VF/SF ports do NOT belong to E-Switch mode. The failure caused the kernel stuck with the older MLX5 core kernel version. This patch adds the checking to avoid creating action at the VF/SF ports on the FDB table. Fixes: b2cd39187cd4 ("net/mlx5: extend send to kernel action support") Signed-off-by: Jiawei Wang Acked-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow_hw.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 6fcf654e4a..89b6f546ae 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -5957,8 +5957,11 @@ flow_hw_create_send_to_kernel_actions(struct mlx5_priv *priv __rte_unused) #ifdef HAVE_MLX5DV_DR_ACTION_CREATE_DEST_ROOT_TABLE int action_flag; int i; + bool is_vf_sf_dev = priv->sh->dev_cap.vf || priv->sh->dev_cap.sf; for (i = MLX5DR_TABLE_TYPE_NIC_RX; i < MLX5DR_TABLE_TYPE_MAX; i++) { + if (is_vf_sf_dev && MLX5DR_TABLE_TYPE_FDB == i) + continue; action_flag = mlx5_hw_act_flag[1][i]; priv->hw_send_to_kernel[i] = mlx5dr_action_create_dest_root(priv->dr_ctx,