From patchwork Tue Oct 24 02:54:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 133238 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 005D1431EB; Tue, 24 Oct 2023 04:55:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 41A3442D45; Tue, 24 Oct 2023 04:54:40 +0200 (CEST) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id 94E2340EF1 for ; Tue, 24 Oct 2023 04:54:37 +0200 (CEST) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6b87c1edfd5so3098707b3a.1 for ; Mon, 23 Oct 2023 19:54:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1698116076; x=1698720876; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nPUV3R0J/IEovMk82s4xxf5K18pUfR5DDwiPDvPaeYU=; b=f6U57kV7f54XzTLUv6SbYG0z64RSpgNSiJy5KJ+Mn5PxurCd2mC3exM8mqA/lTzJc/ +cO05VstLSj+qGrEP/yLY5sY4cBgQ21Ygdaj0uq4j8eNHHrT/0hxPCqLX1seBcyHZEPK PSNXQibAEuzg7fbHN9ZpEbbRcCsjtz16Ai/ud5IJP+r3M5qX95JrgQKVDiVRoHodurol oqWIgGL1vJwJjot4+51zR1tF4Syv71lhuIEOuv8ZUZFDIFBxBN2ZRtrToT3Z+vIEkwQc f17jA2tEbr9fxxqgwqY7nG/SBSt0JMfO4eaYf+huLPb43S5GP9Ym0+ZbQdfq85Rh5SJT DxWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698116076; x=1698720876; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nPUV3R0J/IEovMk82s4xxf5K18pUfR5DDwiPDvPaeYU=; b=Ep8mT+YN/DlHZ5KI2moEsBn2aMbxeMsyMxCUpozgL/qpZx5W8Hdo5JcIkdq9qw1Cns xHHyTC6Db9FciUfXrdsYeQsj1uLLLuKcgeBQdMWSDzlaRIlgjjffeIMnS8FGWJsL254+ 0DNPcsdoAzbUPrADRvQR9oDRYPYKM5YWFMaaegKO3xBZEIpY8KeGjmlOfCcXzU+EJfoL 6Wo9mPM1I02OJXLBi5Pl1TptfKQUkd8JbGXdFMn2BKCJ+4Mzl+G0kIszI7A6xt3pAYSN uZFItF+8ZzavZ7E6aXFzIl5/9lYWOtUsUyvFmFOk3zMooGL6r1z9yeSjDe1jDkAV8cIZ E4ZQ== X-Gm-Message-State: AOJu0YzHugNJRK1llM62giZBM5CWh/GQTCN60M2mG9ByavciEZJxfKzN pocLwF/rN8zJ0O/v27AKd+IBv1QiL3aPLJPRHsYJrw== X-Google-Smtp-Source: AGHT+IGTrbXpxOWV2DqMQGUHDGsLiVjz0bNMJ7CdtdV5MhY9Kic+j4pKU9/AykLNWscNAEXQGp7+og== X-Received: by 2002:a05:6a21:4886:b0:16b:d3d5:a5c5 with SMTP id av6-20020a056a21488600b0016bd3d5a5c5mr1461151pzc.52.1698116076571; Mon, 23 Oct 2023 19:54:36 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id b22-20020aa79516000000b0069b772c4325sm6802348pfp.87.2023.10.23.19.54.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 19:54:35 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Bruce Richardson , Reshma Pattan Subject: [PATCH v7 04/25] pdump: make API's stable Date: Mon, 23 Oct 2023 19:54:01 -0700 Message-Id: <20231024025422.126021-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231024025422.126021-1-stephen@networkplumber.org> References: <20230808173527.186042-1-stephen@networkplumber.org> <20231024025422.126021-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The filtering API's were added in 22.11 and can now be marked as not experimental. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/pdump/rte_pdump.h | 12 ------------ lib/pdump/version.map | 11 +++-------- 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/lib/pdump/rte_pdump.h b/lib/pdump/rte_pdump.h index b1a391830c1d..414931a12cce 100644 --- a/lib/pdump/rte_pdump.h +++ b/lib/pdump/rte_pdump.h @@ -83,9 +83,6 @@ rte_pdump_enable(uint16_t port, uint16_t queue, uint32_t flags, void *filter); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Enables packet capturing on given port and queue with filtering. * * @param port_id @@ -109,7 +106,6 @@ rte_pdump_enable(uint16_t port, uint16_t queue, uint32_t flags, * @return * 0 on success, -1 on error, rte_errno is set accordingly. */ -__rte_experimental int rte_pdump_enable_bpf(uint16_t port_id, uint16_t queue, uint32_t flags, uint32_t snaplen, @@ -169,9 +165,6 @@ rte_pdump_enable_by_deviceid(char *device_id, uint16_t queue, void *filter); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Enables packet capturing on given device id and queue with filtering. * device_id can be name or pci address of device. * @@ -196,7 +189,6 @@ rte_pdump_enable_by_deviceid(char *device_id, uint16_t queue, * @return * 0 on success, -1 on error, rte_errno is set accordingly. */ -__rte_experimental int rte_pdump_enable_bpf_by_deviceid(const char *device_id, uint16_t queue, uint32_t flags, uint32_t snaplen, @@ -242,9 +234,6 @@ struct rte_pdump_stats { }; /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Retrieve the packet capture statistics for a queue. * * @param port_id @@ -254,7 +243,6 @@ struct rte_pdump_stats { * @return * Zero if successful. -1 on error and rte_errno is set. */ -__rte_experimental int rte_pdump_stats(uint16_t port_id, struct rte_pdump_stats *stats); diff --git a/lib/pdump/version.map b/lib/pdump/version.map index 225830dc85a7..ea5bd157cdb1 100644 --- a/lib/pdump/version.map +++ b/lib/pdump/version.map @@ -4,17 +4,12 @@ DPDK_24 { rte_pdump_disable; rte_pdump_disable_by_deviceid; rte_pdump_enable; + rte_pdump_enable_bpf; + rte_pdump_enable_bpf_by_deviceid; rte_pdump_enable_by_deviceid; rte_pdump_init; + rte_pdump_stats; rte_pdump_uninit; local: *; }; - -EXPERIMENTAL { - global: - - rte_pdump_enable_bpf; - rte_pdump_enable_bpf_by_deviceid; - rte_pdump_stats; -};