From patchwork Tue Oct 24 02:39:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 133234 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAA42431EB; Tue, 24 Oct 2023 04:40:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B511427E0; Tue, 24 Oct 2023 04:40:08 +0200 (CEST) Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mails.dpdk.org (Postfix) with ESMTP id 08AE3402CB for ; Tue, 24 Oct 2023 04:40:04 +0200 (CEST) Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-27d18475ed4so2944332a91.0 for ; Mon, 23 Oct 2023 19:40:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1698115203; x=1698720003; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nPUV3R0J/IEovMk82s4xxf5K18pUfR5DDwiPDvPaeYU=; b=AbJZ9bqJxF4uFaCmh0SUUOIS3B5VmPiGLd5KfT+tAvxhj0xDNX9IWSh5OSXZt7W+vp woUAOwkSminvdC2lsE1lbocIE7NnAzOH+/xiDk5hUcpjSOBMUlUUMAa55WyIpvoVKWtf 4jpmbtBkN+bjGg5A4/8Rp/9JyatisclwTeV8l5kSDSSOjLuPOXAInHpGtqljcYTWN6ig 2oiNzkPiU/IURDF7Jsxo6LNAaVLBlqOPKiHbDk1pyIWO3DbChxQzc99J+qNcyrq9Tji1 Mw3dK6ttpP9LpcisgUQSyzM6/T2WR+lZW3tk7/jI+X6IGguWHmv4UD7QOuJN7Hy/ZjxG VM6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698115203; x=1698720003; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nPUV3R0J/IEovMk82s4xxf5K18pUfR5DDwiPDvPaeYU=; b=cDwqtuVqLit0RFSBayYoIGVeAmuViUIssEjofK54j53slzGpemRlc22xWsdgSJauCN 3SqFN15VEZz99X8B0GrsRbN7VXDEjrAwvNTlKN8s6CmljaYkAA/MhMH/GbwNdeWoqm4C cE4uRGuvZeDi0NRu8PcTLH1lGnb2wbawB4H5SJd9YWg6lIDv5pHcjE2aT82D+rASKZch cA3a/qfqr2CnPPhKEXtmGqP5wy7xb0Ol6xNzKOOxsZ5SNcg4ZFHU02te85gtkKlcgMKI uWR91RVZcZseu/5rbsG5mUuLC5hOt2mzYPU9IBO/DN3Kiub38bJOsEUwxQXpgpG/LxC6 Empg== X-Gm-Message-State: AOJu0Yz1kC5dodkA69Dr2rPv5kbnMcdKT8Lz2t0vdn0uuXhlEBey6/9Y 9dkidWCGZr1DERp4Zm3tEPiPvsXjG2S82aganHNJFQ== X-Google-Smtp-Source: AGHT+IEMEPkoJjdLbLIPbr16mokBBBLFcLOBiYHR6BprG7ulvDi5KXF3KZAXMGoy5njnAYTbw1gZXA== X-Received: by 2002:a17:90a:359:b0:27e:277:3014 with SMTP id 25-20020a17090a035900b0027e02773014mr8545598pjf.11.1698115203067; Mon, 23 Oct 2023 19:40:03 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id 21-20020a17090a01d500b0027732eb24bbsm9069186pjd.4.2023.10.23.19.40.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 19:40:02 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Bruce Richardson , Reshma Pattan Subject: [PATCH v6 04/25] pdump: make API's stable Date: Mon, 23 Oct 2023 19:39:26 -0700 Message-Id: <20231024023947.15859-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231024023947.15859-1-stephen@networkplumber.org> References: <20230808173527.186042-1-stephen@networkplumber.org> <20231024023947.15859-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The filtering API's were added in 22.11 and can now be marked as not experimental. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/pdump/rte_pdump.h | 12 ------------ lib/pdump/version.map | 11 +++-------- 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/lib/pdump/rte_pdump.h b/lib/pdump/rte_pdump.h index b1a391830c1d..414931a12cce 100644 --- a/lib/pdump/rte_pdump.h +++ b/lib/pdump/rte_pdump.h @@ -83,9 +83,6 @@ rte_pdump_enable(uint16_t port, uint16_t queue, uint32_t flags, void *filter); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Enables packet capturing on given port and queue with filtering. * * @param port_id @@ -109,7 +106,6 @@ rte_pdump_enable(uint16_t port, uint16_t queue, uint32_t flags, * @return * 0 on success, -1 on error, rte_errno is set accordingly. */ -__rte_experimental int rte_pdump_enable_bpf(uint16_t port_id, uint16_t queue, uint32_t flags, uint32_t snaplen, @@ -169,9 +165,6 @@ rte_pdump_enable_by_deviceid(char *device_id, uint16_t queue, void *filter); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Enables packet capturing on given device id and queue with filtering. * device_id can be name or pci address of device. * @@ -196,7 +189,6 @@ rte_pdump_enable_by_deviceid(char *device_id, uint16_t queue, * @return * 0 on success, -1 on error, rte_errno is set accordingly. */ -__rte_experimental int rte_pdump_enable_bpf_by_deviceid(const char *device_id, uint16_t queue, uint32_t flags, uint32_t snaplen, @@ -242,9 +234,6 @@ struct rte_pdump_stats { }; /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Retrieve the packet capture statistics for a queue. * * @param port_id @@ -254,7 +243,6 @@ struct rte_pdump_stats { * @return * Zero if successful. -1 on error and rte_errno is set. */ -__rte_experimental int rte_pdump_stats(uint16_t port_id, struct rte_pdump_stats *stats); diff --git a/lib/pdump/version.map b/lib/pdump/version.map index 225830dc85a7..ea5bd157cdb1 100644 --- a/lib/pdump/version.map +++ b/lib/pdump/version.map @@ -4,17 +4,12 @@ DPDK_24 { rte_pdump_disable; rte_pdump_disable_by_deviceid; rte_pdump_enable; + rte_pdump_enable_bpf; + rte_pdump_enable_bpf_by_deviceid; rte_pdump_enable_by_deviceid; rte_pdump_init; + rte_pdump_stats; rte_pdump_uninit; local: *; }; - -EXPERIMENTAL { - global: - - rte_pdump_enable_bpf; - rte_pdump_enable_bpf_by_deviceid; - rte_pdump_stats; -};