From patchwork Tue Oct 24 02:39:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 133232 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8674C431EB; Tue, 24 Oct 2023 04:40:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61D6B40E64; Tue, 24 Oct 2023 04:40:05 +0200 (CEST) Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mails.dpdk.org (Postfix) with ESMTP id F389E40A71 for ; Tue, 24 Oct 2023 04:40:01 +0200 (CEST) Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-27d087c4276so2650678a91.0 for ; Mon, 23 Oct 2023 19:40:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1698115201; x=1698720001; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tys2+Rbas78abmp2lZkxnmA5eQ/E9vQyCtq1vgD2nPg=; b=fF7KXL5R7cyTPVYsCUTqb3/VsADmohQtFg4xB+z+X7aKsnwcVHVX0puwKKhwAATb3o 2utiz+9nom0d/gXeD5tVjUmy3WpUWful36XMtp9wHDPFHRiFNe6B+x7J6ItnXFwOoNWx SaQISTu6aL9JPFaplFMtdn77J+9CBT4M0KFJNKk6++tJPMc++NIw/vv7JELGAwQE8SZZ zYEoV+hXlB4hY6bcxeFEDrAivfp5UCE7olSMEv7r/McPsepQuPyz0Wf34s28gLiRVrtb m0CmynP1i9MfUftrUnTPp9Cg46TEtrMQAoe7wGV8vhx4VfyEL0xbr4jPkn2kYlEHf4Ln p0Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698115201; x=1698720001; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tys2+Rbas78abmp2lZkxnmA5eQ/E9vQyCtq1vgD2nPg=; b=qZ/TFb/UhwwlklfBYCN1qC5z9D4JeugR1yv035HUa/Q2mHkk5ASoLWIyhjEHzIRC0T drpzmGHOEx/Xg/se0SEyAhyR4vfz/FtdTq0Lg4S+IbqJkBq3N9lY+vc28AuvVjsP1bPH KIs0hG8Y25Yqe6jTbGWmSBn0+7pst8S3g4zHPORlHE8XrH5s6NGXHEm4XGfWzCn8yQJ1 7BjHivhabQBJe143/bUnEfm4wnkkCK6G5J5uUkK/+1UT+VeCNbX0tvqmLLMSprREO2Bz 4TDUsb+TEH9M988s4kJPyz8+5n5KNLaXHHMG6CJTQzB+M2Fa2vbnBUjb2mtxeAveEZ+C 9Jqw== X-Gm-Message-State: AOJu0Yxq1BKak1yDX0dRwTXGqMbeDZGGDEhkubc6bWlRrLMfu7lVbY2k qvfYC79u9NaeiqyAYw/VdpgtI8WU5n2S475MDZAfwQ== X-Google-Smtp-Source: AGHT+IGMCusKE+v0VfQiaresRyGUNMwfT8Y3SOkcyVjHoZ6Y0XnYwLANY2aTmMaSoi+8iVbeY3Bpaw== X-Received: by 2002:a17:90a:9d85:b0:27d:839:52ae with SMTP id k5-20020a17090a9d8500b0027d083952aemr8108236pjp.32.1698115200875; Mon, 23 Oct 2023 19:40:00 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id 21-20020a17090a01d500b0027732eb24bbsm9069186pjd.4.2023.10.23.19.40.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 19:40:00 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Bruce Richardson Subject: [PATCH v6 02/25] cmdline: make experimental API's stable Date: Mon, 23 Oct 2023 19:39:24 -0700 Message-Id: <20231024023947.15859-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231024023947.15859-1-stephen@networkplumber.org> References: <20230808173527.186042-1-stephen@networkplumber.org> <20231024023947.15859-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org These API's have all ben around for several releases. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/cmdline/cmdline.h | 1 - lib/cmdline/cmdline_parse.h | 4 ---- lib/cmdline/cmdline_rdline.h | 4 ---- lib/cmdline/version.map | 26 ++++++++------------------ 4 files changed, 8 insertions(+), 27 deletions(-) diff --git a/lib/cmdline/cmdline.h b/lib/cmdline/cmdline.h index 992c84591456..dd41e1054378 100644 --- a/lib/cmdline/cmdline.h +++ b/lib/cmdline/cmdline.h @@ -39,7 +39,6 @@ void cmdline_printf(const struct cmdline *cl, const char *fmt, ...) int cmdline_in(struct cmdline *cl, const char *buf, int size); int cmdline_write_char(struct rdline *rdl, char c); -__rte_experimental struct rdline * cmdline_get_rdline(struct cmdline *cl); diff --git a/lib/cmdline/cmdline_parse.h b/lib/cmdline/cmdline_parse.h index a852ac411c59..41b4db1f76f9 100644 --- a/lib/cmdline/cmdline_parse.h +++ b/lib/cmdline/cmdline_parse.h @@ -155,9 +155,6 @@ typedef cmdline_parse_inst_t *cmdline_parse_ctx_t; int cmdline_parse(struct cmdline *cl, const char *buf); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Try to parse a buffer according to the specified context, but do not * perform any function calls if parse is successful. * @@ -166,7 +163,6 @@ int cmdline_parse(struct cmdline *cl, const char *buf); * CMDLINE_PARSE_BAD_ARGS on error and returns the parsed line length (>=0) * on successful parse. */ -__rte_experimental int cmdline_parse_check(struct cmdline *cl, const char *buf); /** diff --git a/lib/cmdline/cmdline_rdline.h b/lib/cmdline/cmdline_rdline.h index 1b4cc7ce5773..c6bb6bbbb36a 100644 --- a/lib/cmdline/cmdline_rdline.h +++ b/lib/cmdline/cmdline_rdline.h @@ -58,7 +58,6 @@ typedef int (rdline_complete_t)(struct rdline *rdl, const char *buf, * * \return New rdline object on success, NULL on failure. */ -__rte_experimental struct rdline *rdline_new(rdline_write_char_t *write_char, rdline_validate_t *validate, rdline_complete_t *complete, @@ -70,7 +69,6 @@ struct rdline *rdline_new(rdline_write_char_t *write_char, * \param rdl A pointer to an initialized struct rdline. * If NULL, this function is a no-op. */ -__rte_experimental void rdline_free(struct rdline *rdl); /** @@ -163,13 +161,11 @@ char *rdline_get_history_item(struct rdline *rdl, unsigned int i); /** * Get maximum history buffer size. */ -__rte_experimental size_t rdline_get_history_buffer_size(struct rdline *rdl); /** * Get the opaque pointer supplied on struct rdline creation. */ -__rte_experimental void *rdline_get_opaque(struct rdline *rdl); #ifdef __cplusplus diff --git a/lib/cmdline/version.map b/lib/cmdline/version.map index 97166789016c..88174e39bcb7 100644 --- a/lib/cmdline/version.map +++ b/lib/cmdline/version.map @@ -30,11 +30,13 @@ DPDK_24 { cmdline_get_help_num; cmdline_get_help_portlist; cmdline_get_help_string; + cmdline_get_rdline; cmdline_in; cmdline_interact; cmdline_isendoftoken; cmdline_new; cmdline_parse; + cmdline_parse_check; cmdline_parse_etheraddr; cmdline_parse_ipaddr; cmdline_parse_num; @@ -51,37 +53,25 @@ DPDK_24 { cmdline_token_portlist_ops; cmdline_token_string_ops; cmdline_write_char; + rdline_add_history; rdline_char_in; rdline_clear_history; + rdline_free; rdline_get_buffer; + rdline_get_history_buffer_size; rdline_get_history_item; + rdline_get_opaque; + rdline_new; rdline_newline; rdline_quit; rdline_redisplay; rdline_reset; rdline_restart; rdline_stop; + vt100_init; vt100_parser; local: *; }; - -EXPERIMENTAL { - global: - - # added in 20.11 - cmdline_get_rdline; - - # added in 21.11 - rdline_new; - rdline_free; - rdline_get_history_buffer_size; - rdline_get_opaque; - - # added in 22.07 - cmdline_parse_check; - - local: *; -};