From patchwork Fri Oct 20 20:57:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 133082 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 042F7431BE; Fri, 20 Oct 2023 22:58:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BC4140EE3; Fri, 20 Oct 2023 22:58:17 +0200 (CEST) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id 6439340695 for ; Fri, 20 Oct 2023 22:58:14 +0200 (CEST) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1ca82f015e4so9679615ad.1 for ; Fri, 20 Oct 2023 13:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1697835493; x=1698440293; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KG30s56eYcCeV1hQ/wPv8yp/WPqlog+r99JuSb4a14I=; b=dJqnZ38pIETdTUC0YSMXDD/T+EVWxMh5uwn4+BIBweQF9LJ3636QS04UTJr2DoDXA1 zSc2yOpOHxDdk7cmN/KJpCAoiqYgIBAe5Ro7eqU2otSAogmuirxpIPWsX+yi6YzhPyq4 3EmnFeiKn9XrbKFDRpmECEQCRCgO9gzP66M6C3t70kmKhXDCfzMyYnfTLwp63c5hL0h2 mBGCYnYCVdxMkHFtoz7oNfHW6W46QHWZbtUCltrXJWpOnOZ0+M2MahUUUFQdUKWBPG0C C2yTeYZ0ORbNynDRMrUeVAcqt0qxe7wxPgHC4bClByEWEG+1VD6hO3/10twpTZT9qdHg bA/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697835493; x=1698440293; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KG30s56eYcCeV1hQ/wPv8yp/WPqlog+r99JuSb4a14I=; b=PxoyjU30AVz3fbQxk7CXVdGsCoHGx12HvRKtrO/n3miOPaRTpNKWpjyxLhX5FZZaMX 0HM8MJdTmDKPabZ2UBOyxoIxEpJxthYMrGIH9rv0U454wNGPSdiH2orrR2jixx+1nByc nxQ9m2m7PfKYhYpVH+SVlEPnu3yqKpmJY/ZWL9BMC5jXYLaAdpRBucuQsjRBFykZvk4w TUeC6HXZqndx08bnZBf/yCjgKvlJkz6Wqh7ZulcxfOG6N/k8vqXDcynn4G6iH/HHdYag 4VSFcAOb7e6tH4EkH9g1Mtg1T+YjWk3ukhvmr19E4fOiCFG/uiPIvDFOG38GVnYWFwbv sCTQ== X-Gm-Message-State: AOJu0Yy5JeoKr+hO6qp5g9KBiQS+YOBqY4CIhgQir3SAbKWXNF+k4SfW Yh1YoWoBgtYbyhPeiA4PTX3fIV0TJH0KizKKs1VM8Q== X-Google-Smtp-Source: AGHT+IHFUvXgHsmU0sFWtzMhiwj8FVtYml73ccxK8AetXD2nl3FtByRGqZEzpfuBDIOY2vJjV8iCKA== X-Received: by 2002:a17:902:d1d2:b0:1ca:b820:74f5 with SMTP id g18-20020a170902d1d200b001cab82074f5mr2743410plb.6.1697835493418; Fri, 20 Oct 2023 13:58:13 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id u17-20020a170902e5d100b001c61512f2a6sm1930961plf.220.2023.10.20.13.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 13:58:12 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Reshma Pattan Subject: [PATCH v5 04/26] pdump: make API's stable Date: Fri, 20 Oct 2023 13:57:37 -0700 Message-Id: <20231020205759.195126-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231020205759.195126-1-stephen@networkplumber.org> References: <20230808173527.186042-1-stephen@networkplumber.org> <20231020205759.195126-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The filtering API's were added in 22.11 and can now be marked as not experimental. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/pdump/rte_pdump.h | 12 ------------ lib/pdump/version.map | 11 +++-------- 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/lib/pdump/rte_pdump.h b/lib/pdump/rte_pdump.h index b1a391830c1d..414931a12cce 100644 --- a/lib/pdump/rte_pdump.h +++ b/lib/pdump/rte_pdump.h @@ -83,9 +83,6 @@ rte_pdump_enable(uint16_t port, uint16_t queue, uint32_t flags, void *filter); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Enables packet capturing on given port and queue with filtering. * * @param port_id @@ -109,7 +106,6 @@ rte_pdump_enable(uint16_t port, uint16_t queue, uint32_t flags, * @return * 0 on success, -1 on error, rte_errno is set accordingly. */ -__rte_experimental int rte_pdump_enable_bpf(uint16_t port_id, uint16_t queue, uint32_t flags, uint32_t snaplen, @@ -169,9 +165,6 @@ rte_pdump_enable_by_deviceid(char *device_id, uint16_t queue, void *filter); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Enables packet capturing on given device id and queue with filtering. * device_id can be name or pci address of device. * @@ -196,7 +189,6 @@ rte_pdump_enable_by_deviceid(char *device_id, uint16_t queue, * @return * 0 on success, -1 on error, rte_errno is set accordingly. */ -__rte_experimental int rte_pdump_enable_bpf_by_deviceid(const char *device_id, uint16_t queue, uint32_t flags, uint32_t snaplen, @@ -242,9 +234,6 @@ struct rte_pdump_stats { }; /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Retrieve the packet capture statistics for a queue. * * @param port_id @@ -254,7 +243,6 @@ struct rte_pdump_stats { * @return * Zero if successful. -1 on error and rte_errno is set. */ -__rte_experimental int rte_pdump_stats(uint16_t port_id, struct rte_pdump_stats *stats); diff --git a/lib/pdump/version.map b/lib/pdump/version.map index 225830dc85a7..ea5bd157cdb1 100644 --- a/lib/pdump/version.map +++ b/lib/pdump/version.map @@ -4,17 +4,12 @@ DPDK_24 { rte_pdump_disable; rte_pdump_disable_by_deviceid; rte_pdump_enable; + rte_pdump_enable_bpf; + rte_pdump_enable_bpf_by_deviceid; rte_pdump_enable_by_deviceid; rte_pdump_init; + rte_pdump_stats; rte_pdump_uninit; local: *; }; - -EXPERIMENTAL { - global: - - rte_pdump_enable_bpf; - rte_pdump_enable_bpf_by_deviceid; - rte_pdump_stats; -};