From patchwork Fri Oct 20 20:57:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 133080 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D9D5431BE; Fri, 20 Oct 2023 22:58:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 97265406B7; Fri, 20 Oct 2023 22:58:14 +0200 (CEST) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id 6C0E040284 for ; Fri, 20 Oct 2023 22:58:12 +0200 (CEST) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1c87a85332bso10335665ad.2 for ; Fri, 20 Oct 2023 13:58:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1697835491; x=1698440291; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tys2+Rbas78abmp2lZkxnmA5eQ/E9vQyCtq1vgD2nPg=; b=jxsnNQb74ojanhGG60wmSXHIY25vB7LKlVT3AJBQ06P1LhFrg6YRrEydzcRGv/IL/Z zK3gInB3IHV7WkBcyHZWMdpTxDgBGpC4GaPlQjo0KlmWkc7X82nlN1LcoF7yUa6y0NqJ 28cka8TcFx2wVAR+fEIgpch2AbBmaXkWfdyBHSF92EgyOK71Go3ga3VnVzybo+sH/0fa qKJqKYAwcC0Wh3p9xILB4EM8zp1OIYuhDDwEEW3o8o3GTchaJih1e20d7ttmWvGXlb07 NdzcPoDFwkT+4e+yMtVCGuQmoF7cukdIzbrPv97sLgeJye6K3rFLTAJ84cRtNEoeKV1o RYoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697835491; x=1698440291; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tys2+Rbas78abmp2lZkxnmA5eQ/E9vQyCtq1vgD2nPg=; b=P55s8LMaMrGnnbx55wGeMVXH/coyLdtmR0O7/KzgMZ/ELh+NwLVFpDtT7+zHrhCoa2 3G7knGdUU/kg3PJUNRAati8U6bZnjUbHLvDq4znfDF76HjGysSpTYbRohB2AxniBhLPT s5W67x4a6sBrenURdPhzZDlngEn2iypMvwX5fT/Vrvoc1sr69SVMed2Ba0KGVSDTeMy2 2Fy4o7Fc4SdeKG9yOi/wAJXEHR6EygLw6mirTYjSbBTndNEUlTH2bsCnL69AWUm5llSK b6+Do5Ig9m6IdjnAYJBUqYvj5YJDxwtdFt5fwyRdxsJFoJar26iCeq3Prs6gbVUBDaem H2/w== X-Gm-Message-State: AOJu0Yx9cfnGQJF4pb88eaGEwr12mzpvYODlpnAR7Db5mW81sMQvJJ6D 2Bp1d7SHHacA+qEvhAnxzGKGTm0kwcw3BaiRdke6Iw== X-Google-Smtp-Source: AGHT+IHEtNP1EcfuMZQxfei+PXqKArEFa2g+UpoP3U3sDODi9etsAx8/8rdMDcwRJROKPXCWjT6mDw== X-Received: by 2002:a17:902:d484:b0:1c9:cf1e:f907 with SMTP id c4-20020a170902d48400b001c9cf1ef907mr4006000plg.57.1697835491421; Fri, 20 Oct 2023 13:58:11 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id u17-20020a170902e5d100b001c61512f2a6sm1930961plf.220.2023.10.20.13.58.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 13:58:10 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Bruce Richardson Subject: [PATCH v5 02/26] cmdline: make experimental API's stable Date: Fri, 20 Oct 2023 13:57:35 -0700 Message-Id: <20231020205759.195126-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231020205759.195126-1-stephen@networkplumber.org> References: <20230808173527.186042-1-stephen@networkplumber.org> <20231020205759.195126-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org These API's have all ben around for several releases. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/cmdline/cmdline.h | 1 - lib/cmdline/cmdline_parse.h | 4 ---- lib/cmdline/cmdline_rdline.h | 4 ---- lib/cmdline/version.map | 26 ++++++++------------------ 4 files changed, 8 insertions(+), 27 deletions(-) diff --git a/lib/cmdline/cmdline.h b/lib/cmdline/cmdline.h index 992c84591456..dd41e1054378 100644 --- a/lib/cmdline/cmdline.h +++ b/lib/cmdline/cmdline.h @@ -39,7 +39,6 @@ void cmdline_printf(const struct cmdline *cl, const char *fmt, ...) int cmdline_in(struct cmdline *cl, const char *buf, int size); int cmdline_write_char(struct rdline *rdl, char c); -__rte_experimental struct rdline * cmdline_get_rdline(struct cmdline *cl); diff --git a/lib/cmdline/cmdline_parse.h b/lib/cmdline/cmdline_parse.h index a852ac411c59..41b4db1f76f9 100644 --- a/lib/cmdline/cmdline_parse.h +++ b/lib/cmdline/cmdline_parse.h @@ -155,9 +155,6 @@ typedef cmdline_parse_inst_t *cmdline_parse_ctx_t; int cmdline_parse(struct cmdline *cl, const char *buf); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Try to parse a buffer according to the specified context, but do not * perform any function calls if parse is successful. * @@ -166,7 +163,6 @@ int cmdline_parse(struct cmdline *cl, const char *buf); * CMDLINE_PARSE_BAD_ARGS on error and returns the parsed line length (>=0) * on successful parse. */ -__rte_experimental int cmdline_parse_check(struct cmdline *cl, const char *buf); /** diff --git a/lib/cmdline/cmdline_rdline.h b/lib/cmdline/cmdline_rdline.h index 1b4cc7ce5773..c6bb6bbbb36a 100644 --- a/lib/cmdline/cmdline_rdline.h +++ b/lib/cmdline/cmdline_rdline.h @@ -58,7 +58,6 @@ typedef int (rdline_complete_t)(struct rdline *rdl, const char *buf, * * \return New rdline object on success, NULL on failure. */ -__rte_experimental struct rdline *rdline_new(rdline_write_char_t *write_char, rdline_validate_t *validate, rdline_complete_t *complete, @@ -70,7 +69,6 @@ struct rdline *rdline_new(rdline_write_char_t *write_char, * \param rdl A pointer to an initialized struct rdline. * If NULL, this function is a no-op. */ -__rte_experimental void rdline_free(struct rdline *rdl); /** @@ -163,13 +161,11 @@ char *rdline_get_history_item(struct rdline *rdl, unsigned int i); /** * Get maximum history buffer size. */ -__rte_experimental size_t rdline_get_history_buffer_size(struct rdline *rdl); /** * Get the opaque pointer supplied on struct rdline creation. */ -__rte_experimental void *rdline_get_opaque(struct rdline *rdl); #ifdef __cplusplus diff --git a/lib/cmdline/version.map b/lib/cmdline/version.map index 97166789016c..88174e39bcb7 100644 --- a/lib/cmdline/version.map +++ b/lib/cmdline/version.map @@ -30,11 +30,13 @@ DPDK_24 { cmdline_get_help_num; cmdline_get_help_portlist; cmdline_get_help_string; + cmdline_get_rdline; cmdline_in; cmdline_interact; cmdline_isendoftoken; cmdline_new; cmdline_parse; + cmdline_parse_check; cmdline_parse_etheraddr; cmdline_parse_ipaddr; cmdline_parse_num; @@ -51,37 +53,25 @@ DPDK_24 { cmdline_token_portlist_ops; cmdline_token_string_ops; cmdline_write_char; + rdline_add_history; rdline_char_in; rdline_clear_history; + rdline_free; rdline_get_buffer; + rdline_get_history_buffer_size; rdline_get_history_item; + rdline_get_opaque; + rdline_new; rdline_newline; rdline_quit; rdline_redisplay; rdline_reset; rdline_restart; rdline_stop; + vt100_init; vt100_parser; local: *; }; - -EXPERIMENTAL { - global: - - # added in 20.11 - cmdline_get_rdline; - - # added in 21.11 - rdline_new; - rdline_free; - rdline_get_history_buffer_size; - rdline_get_opaque; - - # added in 22.07 - cmdline_parse_check; - - local: *; -};