From patchwork Thu Oct 19 19:10:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 133049 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8C7B431AA; Thu, 19 Oct 2023 21:13:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 590FB42EB5; Thu, 19 Oct 2023 21:10:54 +0200 (CEST) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 2C35F42E55 for ; Thu, 19 Oct 2023 21:10:45 +0200 (CEST) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1ca74e77aecso8851995ad.1 for ; Thu, 19 Oct 2023 12:10:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1697742644; x=1698347444; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M3EWFOATL+xu5m9o+dfxUdOetcAzYVAmjWVhp2j6cc0=; b=VV0EZttsNA1IKFDy7TjeGuRfOZ27Y7UYI2GMIhYmtqDXPBcLK7Dm6VXrlUDibL+WlD JaeQ5INckJn5HlZQvTMeQFBkYnph6q8ZPfq5BUCsVyIs0UQOPx7UJsoWNIpcg51De3JA ZX86vAq/wKRIFu5q3RiLj+WwD4VdrpAU7Mywblvx4JcYRXQ4dmdnd9voc8X2bVJMDnpP aTdMH6UH9gSnfuX3xX3/X0DtJWQwxs+jfxhr/U+jK/XOamhnygQPWtHno54k40VelOiT SopXZX0TwYfgXqp64UE8iQzE3c8dF5IOCgNYydDyNzJFS8STeH6dex5PQ1ctFhShoSb5 ZejQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697742644; x=1698347444; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M3EWFOATL+xu5m9o+dfxUdOetcAzYVAmjWVhp2j6cc0=; b=knpG13pWvK1CwCm7t+789yGUuL1TJqvpnzaRrLhGIKjNyjl1z6kggs2iTQCq6Bgmla LqcyJrWE2jEn65ceF53IK+ouhB36nX6mKOkBJXf0ceioVzDjBO6Z98eZAdZH00KXORwT OHymtTROMrC/2sfZ7464b80Qr3qmeGLLpPQMwfa06jkLctDLjrYuqPw6HvhFzgoN7Xs2 2DgDpzfw91mgYIQDVAN+p9fS4jgpBunbHBPrUVob1S6ZHOze7ARnoCwYx4c6JAZ2IIGh obTKCu6owtSRPBcxknwgksDwg+u4afFdFfEuZYu6i4THfTHF29Mg9VrTzp6vh/ESV4K9 1Ong== X-Gm-Message-State: AOJu0YwddA8NCjAhg0gmAc+WqHdf0qdi9UUIYcY8HoOWB2bo//y02wup oiblxKlsfDaY6BNYhchUURDEkLOUSJCxKT7A49AO1w== X-Google-Smtp-Source: AGHT+IECQEZk3bhNF3GidG2JRdtdojzBYh/3wtb+tLEdB3P1jEVY28tQ5kC40p/otT71Y4/SM4bJmw== X-Received: by 2002:a17:903:1c3:b0:1c7:22ae:4080 with SMTP id e3-20020a17090301c300b001c722ae4080mr4444176plh.0.1697742644114; Thu, 19 Oct 2023 12:10:44 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id h12-20020a170902eecc00b001a9b29b6759sm52464plb.183.2023.10.19.12.10.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 12:10:43 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Akhil Goyal Subject: [PATCH v4 20/28] security: remove experimental flag from macsec Date: Thu, 19 Oct 2023 12:10:08 -0700 Message-Id: <20231019191016.156430-21-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231019191016.156430-1-stephen@networkplumber.org> References: <20230808173527.186042-1-stephen@networkplumber.org> <20231019191016.156430-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rte_security API's for macsec were added in 22.11. Therefore remove the experimental tag. There is also one helper function for setting packet metadata that should have been marked internal. Signed-off-by: Stephen Hemminger --- lib/security/rte_security.h | 27 --------------------------- lib/security/version.map | 18 +++++++++--------- 2 files changed, 9 insertions(+), 36 deletions(-) diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h index d2d2af23d5d2..a19544906f21 100644 --- a/lib/security/rte_security.h +++ b/lib/security/rte_security.h @@ -815,7 +815,6 @@ rte_security_session_create(void *instance, * - On success returns 0 * - On failure returns a negative errno value. */ -__rte_experimental int rte_security_session_update(void *instance, void *sess, @@ -851,9 +850,6 @@ int rte_security_session_destroy(void *instance, void *sess); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Create MACsec security channel (SC). * * @param instance security instance @@ -865,15 +861,11 @@ rte_security_session_destroy(void *instance, void *sess); * - -ENOMEM if PMD is not capable to create more SC. * - other negative value for other errors. */ -__rte_experimental int rte_security_macsec_sc_create(void *instance, struct rte_security_macsec_sc *conf); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Destroy MACsec security channel (SC). * * @param instance security instance @@ -884,15 +876,11 @@ rte_security_macsec_sc_create(void *instance, * - -EINVAL if sc_id is invalid or instance is NULL. * - -EBUSY if sc is being used by some session. */ -__rte_experimental int rte_security_macsec_sc_destroy(void *instance, uint16_t sc_id, enum rte_security_macsec_direction dir); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Create MACsec security association (SA). * * @param instance security instance @@ -904,15 +892,11 @@ rte_security_macsec_sc_destroy(void *instance, uint16_t sc_id, * - -ENOMEM if PMD is not capable to create more SAs. * - other negative value for other errors. */ -__rte_experimental int rte_security_macsec_sa_create(void *instance, struct rte_security_macsec_sa *conf); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Destroy MACsec security association (SA). * * @param instance security instance @@ -923,7 +907,6 @@ rte_security_macsec_sa_create(void *instance, * - -EINVAL if sa_id is invalid or instance is NULL. * - -EBUSY if sa is being used by some session. */ -__rte_experimental int rte_security_macsec_sa_destroy(void *instance, uint16_t sa_id, enum rte_security_macsec_direction dir); @@ -1059,7 +1042,6 @@ rte_security_session_fast_mdata_set(void *sess, uint64_t fdata) } /** Function to call PMD specific function pointer set_pkt_metadata() */ -__rte_experimental int __rte_security_set_pkt_metadata(void *instance, void *sess, struct rte_mbuf *m, void *params); @@ -1230,16 +1212,12 @@ struct rte_security_stats { * - On success, return 0 * - On failure, a negative value */ -__rte_experimental int rte_security_session_stats_get(void *instance, void *sess, struct rte_security_stats *stats); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Get MACsec SA statistics. * * @param instance security instance @@ -1250,16 +1228,12 @@ rte_security_session_stats_get(void *instance, * - On success, return 0. * - On failure, a negative value. */ -__rte_experimental int rte_security_macsec_sa_stats_get(void *instance, uint16_t sa_id, enum rte_security_macsec_direction dir, struct rte_security_macsec_sa_stats *stats); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Get MACsec SC statistics. * * @param instance security instance @@ -1270,7 +1244,6 @@ rte_security_macsec_sa_stats_get(void *instance, * - On success, return 0. * - On failure, a negative value. */ -__rte_experimental int rte_security_macsec_sc_stats_get(void *instance, uint16_t sc_id, enum rte_security_macsec_direction dir, diff --git a/lib/security/version.map b/lib/security/version.map index e07fca33a1e6..54c9a556798d 100644 --- a/lib/security/version.map +++ b/lib/security/version.map @@ -1,19 +1,12 @@ DPDK_24 { global: + __rte_security_set_pkt_metadata; rte_security_capabilities_get; rte_security_capability_get; rte_security_session_create; rte_security_session_destroy; rte_security_session_get_size; - - local: *; -}; - -EXPERIMENTAL { - global: - - __rte_security_set_pkt_metadata; rte_security_dynfield_offset; rte_security_macsec_sa_create; rte_security_macsec_sa_destroy; @@ -23,8 +16,15 @@ EXPERIMENTAL { rte_security_macsec_sc_stats_get; rte_security_session_stats_get; rte_security_session_update; - rte_security_oop_dynfield_offset; + local: *; +}; + +EXPERIMENTAL { + global: + + # Added in 23.11 + rte_security_oop_dynfield_offset; rte_security_rx_inject_configure; rte_security_inb_pkt_rx_inject; };