From patchwork Thu Oct 19 16:55:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 132992 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83962431AE; Thu, 19 Oct 2023 18:56:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6060E4281D; Thu, 19 Oct 2023 18:56:19 +0200 (CEST) Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by mails.dpdk.org (Postfix) with ESMTP id 5C59440DD8 for ; Thu, 19 Oct 2023 18:56:14 +0200 (CEST) Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-6ce2ea3a944so325224a34.1 for ; Thu, 19 Oct 2023 09:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1697734573; x=1698339373; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Xn81oAq1m1gfdSq2LkJzwfUYnEjF85fpIDHQS1AtQuY=; b=mrVJpu2fedEllMmmHswmzMSUjeKjFGzztlrIXtEdpZleiigttJedE23uO2JHPa4guv Zul0FADlstMdx3n+4LgU1Mzbspc8su08g0n520p4x53bpv8Pcp14SZdCgt7xVGLq9bOp fGg56dlsE8gC1CCcDnLBv3nbOdxUYwJSt2LadIkvEX/f7dkXUhC3ag/K9L9lPT594ShR yaZY4X29LQDWwXlW1M49qeeq2LP9cEt3iaaOTfHh1hrXDR8J+rmyz7BF5Gs+RvR5Pkmf tj4aO3SxoJax7n4qM+Nyvupmq1Jo2BIzAZphxlk4L8cg9FvX0xQOuS3zBssPOq1U/v9S 6q0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697734573; x=1698339373; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xn81oAq1m1gfdSq2LkJzwfUYnEjF85fpIDHQS1AtQuY=; b=niWcN8hdov2gC/qa1ySExWc0dE1JB+TgnE5IfLmGoKLU7indK0o+rNbb9pwYF5VzMh S4jZoHF81aBMc/b22N5oIj8fd0ocNhy2oR5dxFivN/pbTuOko39Ja6B3PzS03ysjaqT1 wTLPF7AoVmfw2dHOUzInGjsOuDg9n1Lvue49qYgAn+TvPHQdBpwohp7EzDj4UOC/d1p0 EGSgkTIw2MepRIrkHLNMDtbLnHJuN11LtA1FTs4pwLw+Ic+28z5cyhx6rtPbgh4nyXBA F6y3MRDXaoVKx9gODTH6aHJQyA8JmVEwSNfwAMOIR6d+ifPPhFx0VIEQiseKX8p65SsM O5kQ== X-Gm-Message-State: AOJu0Yw5g0ooSacjGs0f4d4xcaps+arHEPWBvqf5GMx0dfCN+LeH5rCq BE35YGtr3CP4lTBwkW58akbVkz9Moqjox5cH514w/w== X-Google-Smtp-Source: AGHT+IFSCvRnyB2pcGWMLUD5z2Psn2Nc8yy8m+6c4bn6/u+ziVmaqv8dLIrNoI2lXjy4HBLtzwsDiA== X-Received: by 2002:a9d:6a95:0:b0:6c4:897a:31c4 with SMTP id l21-20020a9d6a95000000b006c4897a31c4mr2736244otq.29.1697734573487; Thu, 19 Oct 2023 09:56:13 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id y22-20020aa79436000000b00672ea40b8a9sm13988pfo.170.2023.10.19.09.56.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 09:56:13 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Reshma Pattan Subject: [PATCH v3 05/29] pdump: make API's stable Date: Thu, 19 Oct 2023 09:55:34 -0700 Message-Id: <20231019165559.115742-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231019165559.115742-1-stephen@networkplumber.org> References: <20230808173527.186042-1-stephen@networkplumber.org> <20231019165559.115742-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The filtering API's were added in 23.11 and can now be marked as not experimental. Signed-off-by: Stephen Hemminger --- lib/pdump/rte_pdump.h | 12 ------------ lib/pdump/version.map | 11 +++-------- 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/lib/pdump/rte_pdump.h b/lib/pdump/rte_pdump.h index b1a391830c1d..414931a12cce 100644 --- a/lib/pdump/rte_pdump.h +++ b/lib/pdump/rte_pdump.h @@ -83,9 +83,6 @@ rte_pdump_enable(uint16_t port, uint16_t queue, uint32_t flags, void *filter); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Enables packet capturing on given port and queue with filtering. * * @param port_id @@ -109,7 +106,6 @@ rte_pdump_enable(uint16_t port, uint16_t queue, uint32_t flags, * @return * 0 on success, -1 on error, rte_errno is set accordingly. */ -__rte_experimental int rte_pdump_enable_bpf(uint16_t port_id, uint16_t queue, uint32_t flags, uint32_t snaplen, @@ -169,9 +165,6 @@ rte_pdump_enable_by_deviceid(char *device_id, uint16_t queue, void *filter); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Enables packet capturing on given device id and queue with filtering. * device_id can be name or pci address of device. * @@ -196,7 +189,6 @@ rte_pdump_enable_by_deviceid(char *device_id, uint16_t queue, * @return * 0 on success, -1 on error, rte_errno is set accordingly. */ -__rte_experimental int rte_pdump_enable_bpf_by_deviceid(const char *device_id, uint16_t queue, uint32_t flags, uint32_t snaplen, @@ -242,9 +234,6 @@ struct rte_pdump_stats { }; /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Retrieve the packet capture statistics for a queue. * * @param port_id @@ -254,7 +243,6 @@ struct rte_pdump_stats { * @return * Zero if successful. -1 on error and rte_errno is set. */ -__rte_experimental int rte_pdump_stats(uint16_t port_id, struct rte_pdump_stats *stats); diff --git a/lib/pdump/version.map b/lib/pdump/version.map index 225830dc85a7..ea5bd157cdb1 100644 --- a/lib/pdump/version.map +++ b/lib/pdump/version.map @@ -4,17 +4,12 @@ DPDK_24 { rte_pdump_disable; rte_pdump_disable_by_deviceid; rte_pdump_enable; + rte_pdump_enable_bpf; + rte_pdump_enable_bpf_by_deviceid; rte_pdump_enable_by_deviceid; rte_pdump_init; + rte_pdump_stats; rte_pdump_uninit; local: *; }; - -EXPERIMENTAL { - global: - - rte_pdump_enable_bpf; - rte_pdump_enable_bpf_by_deviceid; - rte_pdump_stats; -};